From 174809b8a5e7d041e606d1cca1afd1fa03707b57 Mon Sep 17 00:00:00 2001 From: Armin Novak Date: Wed, 15 Jan 2025 16:00:07 +0100 Subject: [PATCH] [warnings] fix some more warnings --- channels/sshagent/client/sshagent_main.c | 2 ++ client/SDL/SDL3/sdl_clip.cpp | 3 ++- client/Wayland/wlf_cliprdr.c | 3 ++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/channels/sshagent/client/sshagent_main.c b/channels/sshagent/client/sshagent_main.c index 852a2696c..28025c262 100644 --- a/channels/sshagent/client/sshagent_main.c +++ b/channels/sshagent/client/sshagent_main.c @@ -259,10 +259,12 @@ static UINT sshagent_on_close(IWTSVirtualChannelCallback* pChannelCallback) * * @return 0 on success, otherwise a Win32 error code */ +// NOLINTBEGIN(readability-non-const-parameter) static UINT sshagent_on_new_channel_connection(IWTSListenerCallback* pListenerCallback, IWTSVirtualChannel* pChannel, BYTE* Data, BOOL* pbAccept, IWTSVirtualChannelCallback** ppCallback) +// NOLINTEND(readability-non-const-parameter) { SSHAGENT_LISTENER_CALLBACK* listener_callback = (SSHAGENT_LISTENER_CALLBACK*)pListenerCallback; WINPR_UNUSED(Data); diff --git a/client/SDL/SDL3/sdl_clip.cpp b/client/SDL/SDL3/sdl_clip.cpp index f65d29f16..6f61c9ff1 100644 --- a/client/SDL/SDL3/sdl_clip.cpp +++ b/client/SDL/SDL3/sdl_clip.cpp @@ -32,7 +32,8 @@ #define TAG CLIENT_TAG("sdl.cliprdr") #define mime_text_plain "text/plain" -#define mime_text_utf8 mime_text_plain ";charset=utf-8" +// NOLINTNEXTLINE(bugprone-suspicious-missing-comma) +const char mime_text_utf8[] = mime_text_plain ";charset=utf-8"; static const std::vector& s_mime_text() { diff --git a/client/Wayland/wlf_cliprdr.c b/client/Wayland/wlf_cliprdr.c index 6c9e9bb09..1be612b13 100644 --- a/client/Wayland/wlf_cliprdr.c +++ b/client/Wayland/wlf_cliprdr.c @@ -39,7 +39,8 @@ #define TAG CLIENT_TAG("wayland.cliprdr") #define mime_text_plain "text/plain" -#define mime_text_utf8 mime_text_plain ";charset=utf-8" +// NOLINTNEXTLINE(bugprone-suspicious-missing-comma) +static const char mime_text_utf8[] = mime_text_plain ";charset=utf-8"; // NOLINTNEXTLINE(bugprone-suspicious-missing-comma) static const char* mime_text[] = { mime_text_plain, mime_text_utf8, "UTF8_STRING",