From 2c74263b6069d71f7fa617718a3ca8f2f3bca8dd Mon Sep 17 00:00:00 2001 From: akallabeth Date: Sun, 20 Apr 2025 23:12:44 +0200 Subject: [PATCH] [ci,qa] use opaque settings helps clang-tidy to eliminate false positives by removing external access to settings struct members --- ci/cmake-preloads/config-qa-static.cmake | 1 + ci/cmake-preloads/config-qa.cmake | 1 + 2 files changed, 2 insertions(+) diff --git a/ci/cmake-preloads/config-qa-static.cmake b/ci/cmake-preloads/config-qa-static.cmake index 729158252..0dcb1e420 100644 --- a/ci/cmake-preloads/config-qa-static.cmake +++ b/ci/cmake-preloads/config-qa-static.cmake @@ -3,6 +3,7 @@ set(CMAKE_VERBOSE_MAKEFILE ON CACHE BOOL "preload") set(WITH_SERVER ON CACHE BOOL "qa default") set(WITH_SAMPLE ON CACHE BOOL "qa default") set(WITH_SIMD ON CACHE BOOL "qa default") +set(WITH_OPAQUE_SETTINGS ON CACHE BOOL "qa default") set(WITH_STREAMPOOL_DEBUG ON CACHE BOOL "preload") set(WITH_VERBOSE_WINPR_ASSERT OFF CACHE BOOL "qa default") set(ENABLE_WARNING_VERBOSE ON CACHE BOOL "preload") diff --git a/ci/cmake-preloads/config-qa.cmake b/ci/cmake-preloads/config-qa.cmake index ddebe1e9e..358872bad 100644 --- a/ci/cmake-preloads/config-qa.cmake +++ b/ci/cmake-preloads/config-qa.cmake @@ -10,6 +10,7 @@ set(WITH_PROXY ON CACHE BOOL "qa default") set(WITH_PULSE ON CACHE BOOL "qa default") set(WITH_CUPS ON CACHE BOOL "qa default") set(WITH_OPENCL ON CACHE BOOL "qa default") +set(WITH_OPAQUE_SETTINGS ON CACHE BOOL "qa default") set(WITH_PCSC ON CACHE BOOL "qa default") set(WITH_SOXR ON CACHE BOOL "qa default") set(WITH_SIMD ON CACHE BOOL "qa default")