From 4538cefd742d28c343b725f154278e779591e579 Mon Sep 17 00:00:00 2001 From: akallabeth Date: Tue, 4 Feb 2025 14:34:20 +0100 Subject: [PATCH] [warnings] remove dead code --- client/common/cmdline.c | 12 ++---------- libfreerdp/core/tcp.c | 2 -- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/client/common/cmdline.c b/client/common/cmdline.c index 6e816b042..bcbb7385c 100644 --- a/client/common/cmdline.c +++ b/client/common/cmdline.c @@ -1584,9 +1584,6 @@ static int freerdp_detect_windows_style_command_line_syntax(int argc, char** arg (*count)++; } while ((arg = CommandLineFindNextArgumentA(arg)) != NULL); - if ((status <= COMMAND_LINE_ERROR) && (status >= COMMAND_LINE_ERROR_LAST)) - detect_status = -1; - return detect_status; } @@ -1628,22 +1625,17 @@ static int freerdp_detect_posix_style_command_line_syntax(int argc, char** argv, (*count)++; } while ((arg = CommandLineFindNextArgumentA(arg)) != NULL); - if ((status <= COMMAND_LINE_ERROR) && (status >= COMMAND_LINE_ERROR_LAST)) - detect_status = -1; - return detect_status; } static BOOL freerdp_client_detect_command_line(int argc, char** argv, DWORD* flags) { - int posix_cli_status = 0; size_t posix_cli_count = 0; - int windows_cli_status = 0; size_t windows_cli_count = 0; const BOOL ignoreUnknown = TRUE; - windows_cli_status = freerdp_detect_windows_style_command_line_syntax( + const int windows_cli_status = freerdp_detect_windows_style_command_line_syntax( argc, argv, &windows_cli_count, ignoreUnknown); - posix_cli_status = + const int posix_cli_status = freerdp_detect_posix_style_command_line_syntax(argc, argv, &posix_cli_count, ignoreUnknown); /* Default is POSIX syntax */ diff --git a/libfreerdp/core/tcp.c b/libfreerdp/core/tcp.c index 22042cd18..52af82d89 100644 --- a/libfreerdp/core/tcp.c +++ b/libfreerdp/core/tcp.c @@ -1102,8 +1102,6 @@ static int get_next_addrinfo(rdpContext* context, struct addrinfo* input, struct const int family = (IPvX == 4) ? AF_INET : AF_INET6; while (addr && (addr->ai_family != family)) addr = addr->ai_next; - if (!addr) - goto fail; } break; default: