From 4fe941ee665f071e1c5de2360a764b0bfa9f869a Mon Sep 17 00:00:00 2001 From: Armin Novak Date: Thu, 8 Jan 2026 10:32:31 +0100 Subject: [PATCH] [clang,warnings] fix Wjump-misses-init --- server/proxy/pf_server.c | 54 +++++++++++++++++++++------------------- 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/server/proxy/pf_server.c b/server/proxy/pf_server.c index af4452d25..8832f67d8 100644 --- a/server/proxy/pf_server.c +++ b/server/proxy/pf_server.c @@ -423,36 +423,38 @@ static BOOL pf_server_receive_channel_data_hook(freerdp_peer* peer, UINT16 chann if (!pc) goto original_cb; - const pServerStaticChannelContext* channel = - HashTable_GetItemValue(ps->channelsByFrontId, &channelId64); - if (!channel) { - PROXY_LOG_ERR(TAG, ps, "channel id=%" PRIu64 " not registered here, dropping", channelId64); - return TRUE; - } - - WINPR_ASSERT(channel->onFrontData); - switch (channel->onFrontData(pdata, channel, data, size, flags, totalSize)) - { - case PF_CHANNEL_RESULT_PASS: + const pServerStaticChannelContext* channel = + HashTable_GetItemValue(ps->channelsByFrontId, &channelId64); + if (!channel) { - proxyChannelDataEventInfo ev = { 0 }; - - ev.channel_id = channelId; - ev.channel_name = channel->channel_name; - ev.data = data; - ev.data_len = size; - ev.flags = flags; - ev.total_size = totalSize; - return IFCALLRESULT(TRUE, pc->sendChannelData, pc, &ev); - } - case PF_CHANNEL_RESULT_DROP: + PROXY_LOG_ERR(TAG, ps, "channel id=%" PRIu64 " not registered here, dropping", + channelId64); return TRUE; - case PF_CHANNEL_RESULT_ERROR: - default: - return FALSE; - } + } + WINPR_ASSERT(channel->onFrontData); + switch (channel->onFrontData(pdata, channel, data, size, flags, totalSize)) + { + case PF_CHANNEL_RESULT_PASS: + { + proxyChannelDataEventInfo ev = { 0 }; + + ev.channel_id = channelId; + ev.channel_name = channel->channel_name; + ev.data = data; + ev.data_len = size; + ev.flags = flags; + ev.total_size = totalSize; + return IFCALLRESULT(TRUE, pc->sendChannelData, pc, &ev); + } + case PF_CHANNEL_RESULT_DROP: + return TRUE; + case PF_CHANNEL_RESULT_ERROR: + default: + return FALSE; + } + } original_cb: WINPR_ASSERT(pdata->server_receive_channel_data_original); return pdata->server_receive_channel_data_original(peer, channelId, data, size, flags,