From 761c62f754182008b520bc22bf63bc779e38ea99 Mon Sep 17 00:00:00 2001 From: akallabeth Date: Fri, 14 Feb 2025 09:09:19 +0100 Subject: [PATCH] [common,settings] add comments for compat entries --- libfreerdp/common/settings_getters.c | 4 ++++ tools/update-settings-tests | 2 ++ 2 files changed, 6 insertions(+) diff --git a/libfreerdp/common/settings_getters.c b/libfreerdp/common/settings_getters.c index ac8b12b19..f41b8a9aa 100644 --- a/libfreerdp/common/settings_getters.c +++ b/libfreerdp/common/settings_getters.c @@ -2002,9 +2002,11 @@ UINT32 freerdp_settings_get_uint32(WINPR_ATTR_UNUSED const rdpSettings* settings case FreeRDP_VCFlags: return settings->VCFlags; + // API Compatibility section, remove with FreeRDP 4.x case (FreeRDP_Settings_Keys_UInt32)FreeRDP_MonitorLocalShiftX: return (UINT32)settings->MonitorLocalShiftX; + // API Compatibility section, remove with FreeRDP 4.x case (FreeRDP_Settings_Keys_UInt32)FreeRDP_MonitorLocalShiftY: return (UINT32)settings->MonitorLocalShiftY; @@ -2529,10 +2531,12 @@ BOOL freerdp_settings_set_uint32(WINPR_ATTR_UNUSED rdpSettings* settings, settings->VCFlags = cnv.c; break; + // API Compatibility section, remove with FreeRDP 4.x case FreeRDP_MonitorLocalShiftX: settings->MonitorLocalShiftX = (int32_t)cnv.c; break; + // API Compatibility section, remove with FreeRDP 4.x case FreeRDP_MonitorLocalShiftY: settings->MonitorLocalShiftY = (int32_t)cnv.c; break; diff --git a/tools/update-settings-tests b/tools/update-settings-tests index ff1aa2133..8d33ef613 100755 --- a/tools/update-settings-tests +++ b/tools/update-settings-tests @@ -104,6 +104,7 @@ def write_getter_body(f, values, ret, keys, isPointer, compat_values, typestr, e for i in range(len(compat_values)): val = compat_values[i] cast = '(' + entry_type + ')' + f.write('\t\t// API Compatibility section, remove with FreeRDP 4.x\n') write_getter_case(f, val, cast, typestr) f.write('\t\tdefault:\n') f.write('\t\t\tWLog_ERR(TAG, "Invalid key index %" PRIuz " [%s|%s]", id, freerdp_settings_get_name_for_key(id), freerdp_settings_get_type_name_for_key(id));\n') @@ -218,6 +219,7 @@ def write_setter(f, entry_dict, entry_type, entry_name, postfix, compat_dict): if compat_values: for val in compat_values: cast = '(int32_t)' + f.write('\t\t// API Compatibility section, remove with FreeRDP 4.x\n') write_setter_case(f, val, postfix, isPointer, cast) f.write('\t\tdefault:\n') f.write('\t\t\tWLog_ERR(TAG, "Invalid key index %" PRIuz " [%s|%s]", id, freerdp_settings_get_name_for_key(id), freerdp_settings_get_type_name_for_key(id));\n')