From 8cd987dacd67e163b795300e42e4d675ae970827 Mon Sep 17 00:00:00 2001 From: Armin Novak Date: Wed, 14 Jan 2026 10:13:26 +0100 Subject: [PATCH] [channels,serial] fix unintialized variable on jump --- channels/serial/client/serial_main.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/channels/serial/client/serial_main.c b/channels/serial/client/serial_main.c index 59ef0cb9b..cef571464 100644 --- a/channels/serial/client/serial_main.c +++ b/channels/serial/client/serial_main.c @@ -690,13 +690,16 @@ static void create_irp_thread(SERIAL_DEVICE* serial, IRP* irp) * for threads. */ } - const BOOL added = ListDictionary_Add(serial->IrpThreads, (void*)key, irpThread); - ListDictionary_Unlock(serial->IrpThreads); - if (!added) { - WLog_Print(serial->log, WLOG_ERROR, "ListDictionary_Add failed!"); - goto error_handle; + const BOOL added = ListDictionary_Add(serial->IrpThreads, (void*)key, irpThread); + ListDictionary_Unlock(serial->IrpThreads); + + if (!added) + { + WLog_Print(serial->log, WLOG_ERROR, "ListDictionary_Add failed!"); + goto error_handle; + } } ResumeThread(irpThread);