morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-14 00:14:11 +09:00
Code Issues Packages Projects Releases Wiki Activity

[checks,return] fix various unchecked return values

Browse Source
This commit is contained in:
Armin Novak
2026-03-02 18:46:22 +01:00
parent 103e0907cc
commit b724ba546d
16 changed files with 50 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
client/X11/cli/xfreerdp.c
View File

@@ -108,7 +108,8 @@ int main(int argc, char* argv[])
thread = freerdp_client_get_thread(context);
(void)WaitForSingleObject(thread, INFINITE);
GetExitCodeThread(thread, &dwExitCode);
if (!GetExitCodeThread(thread, &dwExitCode))
goto out;
rc = xf_exit_code_from_disconnect_reason(dwExitCode);
freerdp_client_stop(context);

6
client/X11/xf_window.c
View File

@@ -754,7 +754,11 @@ xfWindow* xf_CreateDesktopWindow(xfContext* xfc, char* name, int width, int heig
LogDynAndXClearWindow(xfc->log, xfc->display, window->handle);
xf_SetWindowTitleText(xfc, window->handle, name);
LogDynAndXMapWindow(xfc->log, xfc->display, window->handle);
xf_input_init(xfc, window->handle);
if (!xf_input_init(xfc, window->handle))
{
xf_DestroyDesktopWindow(xfc, window);
return nullptr;
}
/*
* NOTE: This must be done here to handle reparenting the window,

13
client/common/client_cliprdr_file.c
View File

@@ -549,15 +549,20 @@ static BOOL clear_clip_data_entries(WINPR_ATTR_UNUSED const void* key, void* val
return TRUE;
}
static void clear_cdi_entries(CliprdrFileContext* file_context)
WINPR_ATTR_NODISCARD
static UINT clear_cdi_entries(CliprdrFileContext* file_context)
{
UINT res = CHANNEL_RC_OK;
WINPR_ASSERT(file_context);
HashTable_Lock(file_context->inode_table);
HashTable_Foreach(file_context->clip_data_table, clear_clip_data_entries, nullptr);
if (!HashTable_Foreach(file_context->clip_data_table, clear_clip_data_entries, nullptr))
res = ERROR_INTERNAL_ERROR;
HashTable_Clear(file_context->clip_data_table);
HashTable_Unlock(file_context->inode_table);
return res;
}
static UINT prepare_clip_data_entry_with_id(CliprdrFileContext* file_context)
@@ -616,7 +621,7 @@ UINT cliprdr_file_context_notify_new_server_format_list(CliprdrFileContext* file
#if defined(WITH_FUSE)
clear_no_cdi_entry(file_context);
/* TODO: assign timeouts to old locks instead */
clear_cdi_entries(file_context);
rc = clear_cdi_entries(file_context);
if (does_server_support_clipdata_locking(file_context))
rc = prepare_clip_data_entry_with_id(file_context);
@@ -634,7 +639,7 @@ UINT cliprdr_file_context_notify_new_client_format_list(CliprdrFileContext* file
#if defined(WITH_FUSE)
clear_no_cdi_entry(file_context);
/* TODO: assign timeouts to old locks instead */
clear_cdi_entries(file_context);
return clear_cdi_entries(file_context);
#endif
return CHANNEL_RC_OK;

1
client/common/cmdline.c
View File

@@ -5606,7 +5606,6 @@ static int freerdp_client_settings_parse_command_line_arguments_int(
if (!isArgsFrom)
warn_credential_args(largs);
CommandLineFindArgumentA(largs, "v");
arg = largs;
errno = 0;