morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-14 00:14:11 +09:00
Code Issues Packages Projects Releases Wiki Activity

[checks,return] fix various unchecked return values

Browse Source
This commit is contained in:
Armin Novak
2026-03-02 18:46:22 +01:00
parent 103e0907cc
commit b724ba546d
16 changed files with 50 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
server/proxy/channels/pf_channel_smartcard.c
View File

@@ -151,12 +151,15 @@ static BOOL start_irp_thread(pf_channel_client_context* scard,
work = CreateThreadpoolWork(irp_thread, arg, nullptr);
if (!work)
goto fail;
ArrayList_Append(scard->workObjects, work);
if (!ArrayList_Append(scard->workObjects, work))
goto fail;
SubmitThreadpoolWork(work);
return TRUE;
fail:
if (work)
CloseThreadpoolWork(work);
if (arg)
queue_free(arg->e);
free(arg);

4
server/proxy/pf_modules.c
View File

@@ -483,7 +483,7 @@ static BOOL pf_modules_print_ArrayList_ForEachFkt(void* data, size_t index, va_l
return TRUE;
}
void pf_modules_list_loaded_plugins(proxyModule* module)
BOOL pf_modules_list_loaded_plugins(proxyModule* module)
{
size_t count = 0;
@@ -495,7 +495,7 @@ void pf_modules_list_loaded_plugins(proxyModule* module)
if (count > 0)
WLog_INFO(TAG, "Loaded plugins:");
ArrayList_ForEach(module->plugins, pf_modules_print_ArrayList_ForEachFkt);
return ArrayList_ForEach(module->plugins, pf_modules_print_ArrayList_ForEachFkt);
}
WINPR_ATTR_NODISCARD

4
server/proxy/pf_server.c
View File

@@ -970,7 +970,9 @@ proxyServer* pf_server_new(const proxyConfig* config)
goto out;
}
pf_modules_list_loaded_plugins(server->module);
if (!pf_modules_list_loaded_plugins(server->module))
goto out;
if (!are_all_required_modules_loaded(server->module, server->config))
goto out;

2
server/proxy/proxy_modules.h
View File

@@ -90,7 +90,7 @@ extern "C"
WINPR_ATTR_NODISCARD BOOL pf_modules_is_plugin_loaded(proxyModule* module,
const char* plugin_name);
void pf_modules_list_loaded_plugins(proxyModule* module);
WINPR_ATTR_NODISCARD BOOL pf_modules_list_loaded_plugins(proxyModule* module);
WINPR_ATTR_NODISCARD BOOL pf_modules_run_filter(proxyModule* module, PF_FILTER_TYPE type,
proxyData* pdata, void* param);