From ce2e3ab0c7b8d94fbfedfcfbe248b98e1d2917d2 Mon Sep 17 00:00:00 2001 From: akallabeth Date: Thu, 23 Jun 2022 08:36:25 +0200 Subject: [PATCH] Add better explanation of FreeRDP_EnforceTLSv1_2 --- client/common/cmdline.c | 3 ++- client/common/cmdline.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/client/common/cmdline.c b/client/common/cmdline.c index ee1755d35..5d2520836 100644 --- a/client/common/cmdline.c +++ b/client/common/cmdline.c @@ -2897,7 +2897,8 @@ int freerdp_client_settings_parse_command_line_arguments(rdpSettings* settings, } CommandLineSwitchCase(arg, "enforce-tlsv1_2") { - settings->EnforceTLSv1_2 = enable; + if (!freerdp_settings_set_bool(settings, FreeRDP_EnforceTLSv1_2, enable)) + return COMMAND_LINE_ERROR_UNEXPECTED_VALUE; } CommandLineSwitchCase(arg, "cert") { diff --git a/client/common/cmdline.h b/client/common/cmdline.h index 6bd678c2d..075725c82 100644 --- a/client/common/cmdline.h +++ b/client/common/cmdline.h @@ -370,7 +370,8 @@ static const COMMAND_LINE_ARGUMENT_A global_cmd_args[] = { { "tls-seclevel", COMMAND_LINE_VALUE_REQUIRED, "", "1", NULL, -1, NULL, "TLS security level - defaults to 1" }, { "enforce-tlsv1_2", COMMAND_LINE_VALUE_BOOL, NULL, BoolValueFalse, NULL, -1, NULL, - "Use TLS1.2 for connection." }, + "Force use of TLS1.2 for connection. Some servers have a buggy TLS version negotiation and " + "might fail without this" }, { "toggle-fullscreen", COMMAND_LINE_VALUE_BOOL, NULL, BoolValueTrue, NULL, -1, NULL, "Alt+Ctrl+Enter to toggle fullscreen" }, { "tune", COMMAND_LINE_VALUE_REQUIRED, ",", "", NULL, -1, NULL,