morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-14 00:14:11 +09:00
Code Issues Packages Projects Releases Wiki Activity

[warnings,api] fix -Wunused-result

Browse Source 
With marking publid API [[nodiscard]] some problematic error checks in
the core library were uncovered. This commit addresses these
shortcomings.
This commit is contained in:
Armin Novak
2026-02-16 10:57:57 +01:00
parent 20a24fe36e
commit df64d00a97
44 changed files with 479 additions and 291 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
server/Sample/sfreerdp.c
View File

@@ -130,7 +130,8 @@ static BOOL test_peer_context_new(freerdp_peer* client, rdpContext* ctx)
{
const UINT32 rlgr = freerdp_settings_get_uint32(ctx->settings, FreeRDP_RemoteFxRlgrMode);
rfx_context_set_mode(context->rfx_context, WINPR_ASSERTING_INT_CAST(RLGR_MODE, rlgr));
if (!rfx_context_set_mode(context->rfx_context, WINPR_ASSERTING_INT_CAST(RLGR_MODE, rlgr)))
goto fail;
}
if (!(context->nsc_context = nsc_context_new()))
@@ -285,11 +286,13 @@ static BOOL test_peer_draw_background(freerdp_peer* client, const RFX_RECT* rect
else
{
WLog_DBG(TAG, "Using NSCodec");
nsc_context_set_parameters(context->nsc_context, NSC_COLOR_FORMAT, colorFormat);
if (!nsc_context_set_parameters(context->nsc_context, NSC_COLOR_FORMAT, colorFormat))
goto out;
WINPR_ASSERT(bpp <= UINT16_MAX);
nsc_compose_message(context->nsc_context, s, rgb_data, rect->width, rect->height,
(UINT32)(bpp * rect->width));
if (!nsc_compose_message(context->nsc_context, s, rgb_data, rect->width, rect->height,
(UINT32)(bpp * rect->width)))
goto out;
const UINT32 NSCodecId = freerdp_settings_get_uint32(settings, FreeRDP_NSCodecId);
WINPR_ASSERT(NSCodecId <= UINT16_MAX);
cmd.bmp.codecID = (UINT16)NSCodecId;
@@ -430,14 +433,17 @@ static void test_send_cursor_update(freerdp_peer* client, UINT32 x, UINT32 y)
if (RemoteFxCodec)
{
rfx_context_set_pixel_format(context->rfx_context, colorFormat);
rfx_compose_message(context->rfx_context, s, &rect, 1, context->image->data, rect.width,
rect.height, context->image->scanline);
if (!rfx_compose_message(context->rfx_context, s, &rect, 1, context->image->data,
rect.width, rect.height, context->image->scanline))
WLog_WARN(TAG, "rfx_compose_message failed");
}
else
{
nsc_context_set_parameters(context->nsc_context, NSC_COLOR_FORMAT, colorFormat);
nsc_compose_message(context->nsc_context, s, context->image->data, rect.width,
rect.height, context->image->scanline);
if (!nsc_context_set_parameters(context->nsc_context, NSC_COLOR_FORMAT, colorFormat))
WLog_WARN(TAG, "nsc_context_set_parameters failed");
else if (!nsc_compose_message(context->nsc_context, s, context->image->data, rect.width,
rect.height, context->image->scanline))
WLog_WARN(TAG, "rfx_compose_message failed");
}
}
@@ -1204,7 +1210,8 @@ static DWORD WINAPI test_peer_mainloop(LPVOID arg)
replay = *cb;
context->io = *cb;
replay.WritePdu = hook_peer_write_pdu;
freerdp_set_io_callbacks(client->context, &replay);
if (!freerdp_set_io_callbacks(client->context, &replay))
goto fail;
}
WLog_INFO(TAG, "We've got a client %s", client->local ? "(local)" : client->hostname);