From e88cb403bb302e2e664bac4cd485453f4d9bcfc2 Mon Sep 17 00:00:00 2001 From: akallabeth Date: Fri, 12 Apr 2024 10:21:49 +0200 Subject: [PATCH] [coverity] 1543930 Dereference after null check --- channels/drdynvc/client/drdynvc_main.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/channels/drdynvc/client/drdynvc_main.c b/channels/drdynvc/client/drdynvc_main.c index 4e76fbbe0..968d7e2b4 100644 --- a/channels/drdynvc/client/drdynvc_main.c +++ b/channels/drdynvc/client/drdynvc_main.c @@ -396,14 +396,13 @@ static void dvcman_channel_free(DVCMAN_CHANNEL* channel) static void dvcman_channel_unref(DVCMAN_CHANNEL* channel) { - DVCMAN* dvcman = NULL; - WINPR_ASSERT(channel); if (InterlockedDecrement(&channel->refCounter)) return; - dvcman = channel->dvcman; - HashTable_Remove(dvcman->channelsById, &channel->channel_id); + DVCMAN* dvcman = channel->dvcman; + if (dvcman) + HashTable_Remove(dvcman->channelsById, &channel->channel_id); } static UINT dvcchannel_send_close(DVCMAN_CHANNEL* channel)