1676 Commits

Author SHA1 Message Date
akallabeth
f86f70a022 Merge pull request #10637 from akallabeth/dealloc-fix
[warnings] fix mismatched-dealloc
2024-09-20 10:50:20 +02:00
Armin Novak
96052ca2fb [build,c++] add CXXCompilerFlags to set warnings
Just like with the C components and CompilerFlags.cmake add a
configuration for C++ that disables specific warnings only found in C++
code.
2024-09-20 09:16:30 +02:00
Armin Novak
c7c84682e1 [warnings] fix mismatched-dealloc
Some allocator functions have an error path where the corresponding free
function is called. Since the memory in the allocator function was
allocated using malloc/calloc the free function does not match. Silence
warnings with pragma macros
2024-09-18 15:35:28 +02:00
Armin Novak
65f6541f67 [server,proxy] fix plausibility checks in pf_config_get_uint32 2024-09-18 11:47:01 +02:00
Armin Novak
d55dfa316f [server,proxy] fix unchecked return 2024-09-18 11:47:01 +02:00
Armin Novak
deec4df8c0 [proxy,module] move list in dyn-channel-dump instead of copy 2024-09-18 11:46:56 +02:00
akallabeth
586f40631f [warnings] fix shorten-64-to-32 2024-09-17 16:13:48 +02:00
akallabeth
328b7433a4 [server,proxy] fix unchecked return values 2024-09-17 12:57:34 +02:00
akallabeth
a19305569d [assert] fix ULONG_MAX use
most of the time this was used to check ULONG limits. Replace with
correct UINT32_MAX
2024-09-16 08:22:40 +02:00
akallabeth
bb242b9a89 [return checks] fix use of WaitForSingleObject 2024-09-16 08:22:37 +02:00
akallabeth
965d231e49 [return checks] fix use of CloseHandle 2024-09-16 08:22:31 +02:00
akallabeth
f655843260 [return checks] fix use of rdpSettings getter/setter 2024-09-16 06:48:23 +02:00
akallabeth
c0d06c782b [return checks] fix missing checks
* Stream_EnsureRemainingCapacity
* rdp_client_transition_to_state
2024-09-16 06:48:19 +02:00
akallabeth
94020c183c [return checks] fix use of ResetEvent 2024-09-16 06:48:09 +02:00
akallabeth
7d67b8e204 [return checks] fix use of SetEvent 2024-09-16 06:47:58 +02:00
akallabeth
0d5bc92a2b [warnings] fix apple iOS/macos 2024-09-15 19:47:13 +02:00
akallabeth
1bd6d70057 [warnings] fix some warnings on mac os 2024-09-15 10:06:22 +02:00
akallabeth
f7726ed7b6 [server,shadow] improve command line error logging
print an error message indicating where the parsing failed.
2024-09-15 09:21:38 +02:00
akallabeth
ba41d5e532 [warnings] fix unchecked return 2024-09-15 09:08:02 +02:00
akallabeth
f1be630637 [server,proxy] fix unchecked return 2024-09-15 09:07:49 +02:00
akallabeth
8b6091a007 [winpr,wtsapi] improve API usage
* Mark WTSVirtualChannelOpen and WTSVirtualChannelOpenEx with
  WINPR_ATTR_MALLOC to enforce compiler checks for resource cleanup
* Fix unused result warnings, use the result or cast to (void) where not
  requierd
2024-09-14 21:29:31 +02:00
akallabeth
adc4f2abf8 [warnings] fix unused variables 2024-09-12 13:29:58 +02:00
akallabeth
cc6850bf21 [warnings] fix format nonliteral
add pragma to suppress format nonliteral warnings where appropriate
2024-09-12 09:08:53 +02:00
akallabeth
11671bcd5b [warnings] fix unreachable code return 2024-09-11 20:50:24 +02:00
akallabeth
a1be46e5dd [warning] fix function declarations
use same names in declaration and implementation
2024-09-11 20:50:21 +02:00
akallabeth
edf6ab89f7 [warnings] fix dead store 2024-09-10 14:43:11 +02:00
akallabeth
3ab6d2f918 [proxy,modules] fix unchecked return 2024-09-10 14:42:39 +02:00
akallabeth
082c46ba64 [proxy,modules] require C++ 17
Unify required C++ standard and require C++ 17 for all modules. It does
not make a lot of sense to have different standard requirements in the
same project.
2024-09-06 09:20:28 +02:00
akallabeth
749023bacb Merge pull request #10555 from akallabeth/cast-fix-tls
[crypto,tls] simplify function pointer cast
2024-09-05 17:18:27 +02:00
akallabeth
e3f94e6622 nodiscard 2024-09-04 22:17:35 +02:00
akallabeth
9ae37b094f fix implicit widening of multiplication result 2024-09-04 22:01:09 +02:00
akallabeth
6a1c3b4545 [function pointer] use macro for GetProcAddress
Cast all results of GetProcAddress with WINPR_FUNC_PTR_CAST
2024-09-04 21:31:48 +02:00
akallabeth
245afb706c [function pointers] unify casts with macro 2024-09-04 20:06:45 +02:00
akallabeth
5e123735fa [warnings] fixed sign-compare 2024-09-04 10:14:05 +02:00
akallabeth
9a027833b9 [warnings] fix misplaced widening cast 2024-09-03 17:40:55 +02:00
akallabeth
5a4a1a40ad fix declaration and implementation parameter names 2024-09-03 12:24:53 +02:00
akallabeth
190929c018 [warnings] fix function pointer casts 2024-08-30 15:40:01 +02:00
akallabeth
500495dc00 [warnings] fix SDL3 related issues 2024-08-29 16:03:51 +02:00
akallabeth
24cd7828c9 [warnings] fix clang-tidy issues in server 2024-08-29 15:20:42 +02:00
akallabeth
9c9d74e920 [warnings] fix redundant casts 2024-08-29 12:03:09 +02:00
akallabeth
15456e1ee1 [warnings] fix implicit widening conversion 2024-08-29 10:47:20 +02:00
akallabeth
1d33095500 [warnings] fix cert-err33-c
Fix unused return values, cast to void if on purpose
2024-08-29 10:19:27 +02:00
akallabeth
56d660f258 [cmake] mark dependency includes SYSTEM
Mark all dependency include paths SYSTEM so warnings from system headers
are excluded from ci warning statistics
2024-08-26 11:10:49 +02:00
Armin Novak
1f83198bb1 [server,shadow] send BitmapUpdate with single rectangle
See https://github.com/FreeRDP/FreeRDP/issues/10413

Microsoft ditched support for RFX and multiple rectangles in BitmapUpdate for
windows 11 24H2.

So send all updates only with a single rectangle.
2024-08-08 08:37:51 +02:00
akallabeth
3820858c63 [server,proxy] discard closed dyn channel data
If a dynamic channel does no longer exist or has been closed discard the
channel data received from client
2024-07-25 12:02:51 +02:00
akallabeth
eaf0bd8a69 [server,proxy] automatic intercept for drdynvc
* By default no special treatment for drdynvc
* If any of the configuration options requires drdynvc intercept do that
  independently of the intercept/passthrough lists
2024-07-25 11:19:20 +02:00
akallabeth
784f9eab24 [server,proxy] only intercept drdynvc if requested 2024-07-25 11:19:17 +02:00
Armin Novak
9b6e39a880 [server,sample] fix NSCodec and SurfaceBitsCommand 2024-07-24 21:54:49 +02:00
Armin Novak
62eba8dacb [server,shadow] fix NSCoded and SurfaceBitsCommand 2024-07-24 21:54:46 +02:00
Armin Novak
d757dfee24 [server,shadow] Fix RFX SurfaceBitsCommands
* Use RLGR mode from settings (might be overwritten by client)
* Only send RFX SurfaceBits if SURFCMDS_STREAM_SURFACE_BITS was set in
  capabilities
2024-07-24 21:54:36 +02:00