23067 Commits

Author SHA1 Message Date
Armin Novak
db3dcf57b1 [client,x11] fix XGetWindowProperty return handling 2026-02-19 21:59:15 +01:00
Armin Novak
0890f24ebc [channel,usb] fix message parsing and creation
* 2.2.10.3 TS_URB_SELECT_INTERFACE_RESULT was generated incorrect
* 2.2.9.4 TS_URB_PIPE_REQUEST OutputBuffer check was wrong
2026-02-19 20:22:23 +01:00
akallabeth
caa0736f94 Merge pull request #12329 from akallabeth/rdtk-attr-nodiscard
[rdtk,nodiscard] mark rdtk API nodiscard
2026-02-19 16:32:01 +01:00
Armin Novak
69200a7217 [rdtk] default to OFF in all builds
Since this is now optional (and was never really used for much) disable
it unless explicitly enabled.
2026-02-19 16:18:37 +01:00
Armin Novak
f4c991f902 [server,shadow] make rdtk optional 2026-02-19 16:18:32 +01:00
Armin Novak
73419a3a29 [rdtk,nodiscard] mark rdtk API nodiscard 2026-02-19 13:19:26 +01:00
akallabeth
ef6611c809 Merge pull request #12331 from akallabeth/shadow-fixes
Shadow fixes
2026-02-19 12:23:16 +01:00
Armin Novak
dbef19705b [server,shadow] clean up code, check returns
* Fix return value checks
* Mark internal functions [[nodiscard]]
* Refactor x11 backend to simplify locking checks
2026-02-19 12:23:02 +01:00
Armin Novak
33bcf76950 [winpr,collections] fix Queue and MessageQueue
EnsureCapacity was nulling the wrong elements, this commit rectifies
that.
2026-02-19 12:07:42 +01:00
akallabeth
dc6d4b17cb Merge pull request #12330 from akallabeth/shadow-fix
[server,shadow] fix return and parameter checks
2026-02-19 08:58:39 +01:00
Armin Novak
56d6c97a41 [proxy,modules] mark functions [[nodiscard]] 2026-02-19 08:57:50 +01:00
Armin Novak
86327cba6f [server,shadow] fix return and parameter checks 2026-02-19 08:49:33 +01:00
akallabeth
51e66d7bf0 Merge pull request #12322 from akallabeth/msg-queue-fix
[winpr,utils] ensure message queue capacity
2026-02-18 15:58:55 +01:00
Armin Novak
b08892fb9c [winpr,utils] improve TestQueue
properly test queue fill, drain and resize
2026-02-18 15:43:40 +01:00
Armin Novak
d48452faf3 [winpr,utils] Add Queue_Capacity 2026-02-18 15:43:40 +01:00
Armin Novak
b78cb455cb [winpr,queue] improve queue management
* Fix Queue_EnsureCapacity reallocation handling, ensure queue->tail is
  properly updated.
* Fix allocation behaviour, use growthFactor * 32 as block size.
* Add doxygen for Queue_New
2026-02-18 15:43:39 +01:00
Armin Novak
c0d477d278 [winpr,utils] improve TestMessageQueue
properly test queue fill, drain and resize
2026-02-18 15:32:04 +01:00
Armin Novak
57dfd75231 [winpr,utils] add MessageQueue_Capacity 2026-02-18 14:26:03 +01:00
Armin Novak
c9b72743e3 [winpr,utils] ensure message queue capacity
the capacity should always be larger than what is actually used.
2026-02-18 14:26:03 +01:00
Armin Novak
3b286a923d [winpr,stream] improve return checks in Stream_EnsureCapacity
* Properly check all return values and propagate them back to caller
* Simplify new stream size calculation
2026-02-18 14:26:03 +01:00
akallabeth
6e59663401 Merge pull request #12323 from akallabeth/resource-fix
Resource fix
2026-02-18 13:49:28 +01:00
Armin Novak
e05252cdea [codec,dsp] fix duplicate NULL checks 2026-02-18 13:24:50 +01:00
Armin Novak
48769060aa [server,shadow] simplify locking
use a wrapper function holding the locks, so no error conditions need to
be checked and the lock is released unconditionally.
2026-02-18 13:23:48 +01:00
Armin Novak
5475aeecf1 [client,common] fix mask for freerdp_client_handle_touch 2026-02-18 13:23:48 +01:00
Armin Novak
72c4c14918 [gdi,shape] fix gdi_FillRect checks 2026-02-18 13:23:47 +01:00
Armin Novak
ab1675f2cb [gdi,graphics] fix gdi_Glyph_BeginDraw return checks 2026-02-18 13:15:56 +01:00
akallabeth
7e486348e9 Merge pull request #12320 from akallabeth/rdpdr-simplify
Rdpdr simplify
2026-02-17 16:51:05 +01:00
Armin Novak
cf86ec9ed0 [gdi] fix handling of empty regions
Do not abort if an empty update region is found, ignore it.
2026-02-17 16:38:36 +01:00
Armin Novak
d015ba58de [winpr,collections] fix sign warnings 2026-02-17 16:38:35 +01:00
Armin Novak
d20f9af0e8 [client,sdl] fix single window dynamic screen updates 2026-02-17 16:38:35 +01:00
Armin Novak
5f10ae9599 [channels,rdpdr] fix IRP handling
* clean up IRP creation
* Properly handle each IRP, call irp->Complete or irp->Discard only once
  for each IRP
* For each channel split IRP handling, one function prepares the data
  and a single evaluate function later calls irp->Complete or irp->Discard
2026-02-17 16:38:31 +01:00
Armin Novak
66d84e7f45 [client,sdl] fix a memory leak on startup 2026-02-17 16:14:15 +01:00
akallabeth
1b744c15fe Merge pull request #12319 from akallabeth/grow-reasonable
[allocations] fix growth of preallocated buffers
2026-02-17 15:23:17 +01:00
Armin Novak
118afc0b95 [allocations] fix growth of preallocated buffers
* Replace * 2 with * sizeof(WCHAR) for string usages
* Grow streams and other buffers reasonably, e.g. add 128 elements per
  try and check for possible overflows
* Add constant postfix to force them to 64bit
2026-02-17 13:54:34 +01:00
akallabeth
50eafef1d7 Merge pull request #12313 from akallabeth/freerdp-api-nodiscard
Freerdp api nodiscard
2026-02-17 12:54:27 +01:00
Armin Novak
c4a0565342 [client,x11] fix xf_DeleteSurface error branch 2026-02-17 11:10:16 +01:00
Armin Novak
df64d00a97 [warnings,api] fix -Wunused-result
With marking publid API [[nodiscard]] some problematic error checks in
the core library were uncovered. This commit addresses these
shortcomings.
2026-02-17 11:07:08 +01:00
Armin Novak
20a24fe36e [freerdp,api] mark API functions [[nodiscard]]
Mark (most) of the API functions returning a value [[nodiscard]]. This
will assist application developers spotting bad return checks.
2026-02-17 10:23:34 +01:00
akallabeth
fac35c3abb Merge pull request #12317 from akallabeth/codec-logs
NSC Codec fixes
2026-02-17 09:28:16 +01:00
Armin Novak
f3d23da0ae [codec,nsc] update function docs
* add doxygen for functions
* add support for scanline value 0
2026-02-17 09:15:33 +01:00
Armin Novak
169971607c [codec,nsc] fix use of nsc_process_message
the second width/height argument should reflect the destination buffer
pixel size
2026-02-17 08:38:04 +01:00
Armin Novak
24a23e3028 [codec,nsc] deprecate nsc_decompose_message
this function is just a wrapper around nsc_process_message with some
wStream handling around it. Since proper length checks are missing
deprecate it completely.
2026-02-17 08:32:39 +01:00
Armin Novak
caf6e7f2ec [codec,nsc] log decoder function parameter issues 2026-02-17 08:24:20 +01:00
akallabeth
9a382e67a2 Merge pull request #12315 from akallabeth/clear-check-fixup
[codec,clear] fix destination checks
2026-02-16 20:10:36 +01:00
Armin Novak
7d8fdce2d0 [codec,clear] fix destination checks
check against the correct nDstWidth/nDstHeight
2026-02-16 19:56:55 +01:00
akallabeth
341b52ad96 Merge pull request #12312 from akallabeth/planar-dst-fix
[codec,planar] fix missing destination bounds checks
2026-02-16 10:54:54 +01:00
Armin Novak
a0be5cb87d [codec,planar] fix missing destination bounds checks 2026-02-16 10:00:23 +01:00
akallabeth
a25b90adc2 Merge pull request #12311 from akallabeth/winpr-attr-nodiscard-fkt-ptr
Winpr attr nodiscard fkt ptr
2026-02-16 09:32:52 +01:00
Armin Novak
a1c72a2f85 [server,warnings] properly handle function return 2026-02-16 09:18:39 +01:00
Armin Novak
f4b0549c5b [client,warnings] properly handle function return 2026-02-16 09:18:38 +01:00