Commit Graph

694 Commits

Author SHA1 Message Date
Michael Tokarev
19f129654e spelling: dont 2025-03-06 13:24:29 +03:00
Armin Novak
9be8518873 [client,common] fix gateway parameter parsing
Abort if an invalid /gateway:type:xxx parameter was passed.
2025-03-05 14:06:19 +01:00
Thore Sommer
30054052cc [client,cmdline] fix port parsing for gateway 2025-02-25 13:41:48 +01:00
akallabeth
51685ea1bd [client,common] improve parsing of TLS options 2025-02-24 13:31:09 +01:00
akallabeth
4e111874de [client,sdl] mark SDL2 as deprecated.
SDL2 client is a dead end due to lacking API (clipboard support, ...) so
mark the SDL2 client deprecated and point out there is a SDL3 version
available
2025-02-21 09:17:16 +01:00
akallabeth
36c5826f45 [client,warnings] fix -Wunused-parameter for common 2025-02-13 15:54:04 +01:00
akallabeth
9f8ed06f9a [client,cmdling] use a typedef for callback function
typedef freerdp_command_line_handle_option_t to have a common type for
callback functions
2025-02-11 12:21:41 +01:00
akallabeth
a569fc9ea1 [client,common] split freerdp_client_settings_parse_command_line_arguments_int 2025-02-11 11:04:57 +01:00
akallabeth
4538cefd74 [warnings] remove dead code 2025-02-04 14:55:46 +01:00
akallabeth
bbd16d922b [client,cmdline] fix vmconnect checks 2025-01-08 21:05:24 +01:00
akallabeth
6701359cc1 [warnings] fix integer casting
* use WINPR_ASSERTING_INT_CAST where possible
* clean up client code
2024-12-19 12:45:23 +01:00
akallabeth
f25be351b1 [core,gateway] Make tenantid use optional 2024-12-10 15:13:16 +01:00
Armin Novak
f17c1830b7 [aad,avx] improve AzureAD support
* New setting GatewayAzureActiveDirectory to fetch wellknown from
* Clean up command line arguments, rename to make function better
  understandable
2024-12-10 15:12:41 +01:00
akallabeth
9fb721b8be [client,common] add parameters for aad auth 2024-12-10 15:12:34 +01:00
akallabeth
83f2f21ad3 [warnigns] fix lots of bugprone warnings
* update-settings-tests: properly cast types in getter/setter
* wtypes: fix PHANDLE definition
* wStream: fix INT64 write function warnings
* Simplify HANDLE copy in channels, just assign after proper cast
2024-12-06 09:15:48 +01:00
akallabeth
40cbf65dff [cmdline] fix drive parsing 2024-12-06 08:38:18 +01:00
akallabeth
cd1330be80 [client,common] const correct variable declaration 2024-11-22 11:01:01 +01:00
akallabeth
b5f95e0f87 [codespell] fix spelling mistakes 2024-11-21 11:28:06 +01:00
stephanebill
4f2afa8c47 spell check with codespell 2024-11-20 16:53:40 -05:00
akallabeth
78acedb40e [warnigns] fix Wshorten-64-to-32 2024-11-11 10:22:37 +01:00
Martin Fleisz
1520d94d33 Merge pull request #10797 from akallabeth/warn-fixes
Warn fixes
2024-11-07 13:50:51 +01:00
akallabeth
fb3a127d00 [common,cmdline] add new functions
* Add freerdp_client_print_version_ex and
  freerdp_client_print_buildconfig_ex to print version and build
  configuration along with the binary name calling it
* Use these new functions instead of the ones that only print out
  version and/or buildconfig
2024-11-04 09:06:12 +01:00
akallabeth
dc76879e0b [warnings] fix some compiler warnings
* fix compiler warnings found in a lot of places
* add missing enum type for clipboard channel
* mark deallocator for winpr image function
2024-10-30 16:12:20 +01:00
akallabeth
aa954d9be9 [warnings] fix various compiler warnings 2024-10-29 15:49:43 +01:00
akallabeth
f0d0105d50 [client,common] tighten /vmconnect checks
Fixes #5300:
* abort if +/-nego is used, /vmconnect overrides these.
* only set custom port if no /port or /v:host:port is in use allowing
  overriding default port
2024-10-28 09:44:21 +01:00
akallabeth
7ab30a1b18 [client,common] const correct pointer array arguments 2024-10-24 11:32:08 +02:00
akallabeth
9caf38bbb6 [warnings] unify CommandLineParseCommaSeparatedValues
CommandLineParseCommaSeparatedValues does some internal hack to allow
the allocated char** to be cleaned up by free.
This enforces compiler warnings as the pointer types do not match.
Use a new free function CommandLineParserFree instead
2024-10-22 21:11:58 +02:00
akallabeth
8b3f807a0a [warnings] fix format warnings 2024-10-17 20:47:29 +02:00
akallabeth
fef9b1a012 [client,common] annotate clang-analyzer-optin.core.EnumCastOutOfRange 2024-10-01 13:05:53 +02:00
akallabeth
5e1aa072f1 [client,common] fix sign warnings 2024-10-01 13:05:48 +02:00
akallabeth
f6eb6ad4d7 [utils,string] add freerdp_extract_key_value
* Add new function freerdp_extract_key_value to extract key/value pairs
  from a string
* replace all sscanf usages with this new function
2024-10-01 13:05:34 +02:00
akallabeth
1f3e6decf2 [client,common] fix possible integer overflow 2024-09-24 11:31:40 +02:00
akallabeth
cd18dea174 [return checks] fix use of unicode functions 2024-09-16 06:48:26 +02:00
akallabeth
f655843260 [return checks] fix use of rdpSettings getter/setter 2024-09-16 06:48:23 +02:00
akallabeth
07ea37d1d7 [return checks] fix use of CommandLineParseArgumentsA 2024-09-16 06:48:16 +02:00
akallabeth
ba41d5e532 [warnings] fix unchecked return 2024-09-15 09:08:02 +02:00
akallabeth
3460f64f57 [client,common] fix possible NULL dereference 2024-09-14 21:29:21 +02:00
akallabeth
16cec716e0 [strtok] replace function with strtok_s
Since strtok is not thread safe replace it with strtok_s (WinPR wrapper
around strtok_r for systems not supporting the ISO function names)
2024-09-13 21:19:17 +02:00
akallabeth
7ef9345743 Merge pull request #10549 from hardening/rcg2
core, channels: client-side remote credential guard
2024-09-13 08:24:14 +02:00
akallabeth
b29c141c39 [client,cmdline] fix COMMAND_LINE_ARGUMENT_A arguments
* The project expects COMMAND_LINE_ARGUMENT_A arguments, so fix
  COMMAND_LINE_ARGUMENT macro usage. (affects windows API)
2024-09-12 13:30:10 +02:00
akallabeth
8a990644c0 [warnings] fix missing NULL assert/check 2024-09-12 09:08:51 +02:00
David Fort
a4bd5ba886 core, channels: client-side remote credential guard
This patch implements the client-side part of the remote credential guard feature
as described in MS-RDPEAR. The 2 main changes are: shipping the TSRemoteGuardaCreds in
NLA, and implement the rdpear channel that allows LSASS to remote all the calls to
our client. For now it's UNIX only as the windows implementation would be implemented
in a completely different way.
To test, you may establish you ccache and then connect with (RCG enabled on the server):
	xfreerdp /remoteGuard /u:<user> /d:<domain> /v<server>

That should log you in, and in the session you should not be asked for credentials when
doing mstsc /remoteGuard /v:<other server>.
2024-09-11 17:15:11 +02:00
Armin Novak
17c209c0f9 [client,common] change /dynamic-resizing to BOOL option
Allows to use +-/ prefixes to enable/disable the option. Brought up on
matrix channel for uses with RDP files that enable the option. Now it
can be disabled by adding -dynamic-resolution on command line.
2024-09-11 11:06:21 +02:00
akallabeth
306af4070c [client,common] properly abort on invalid scale-desktop 2024-09-09 12:37:22 +02:00
akallabeth
245afb706c [function pointers] unify casts with macro 2024-09-04 20:06:45 +02:00
akallabeth
190929c018 [warnings] fix function pointer casts 2024-08-30 15:40:01 +02:00
akallabeth
500495dc00 [warnings] fix SDL3 related issues 2024-08-29 16:03:51 +02:00
akallabeth
ceae258e37 [warnings] fix clang-tidy issues in clients 2024-08-29 15:34:27 +02:00
akallabeth
9c9d74e920 [warnings] fix redundant casts 2024-08-29 12:03:09 +02:00
akallabeth
1d33095500 [warnings] fix cert-err33-c
Fix unused return values, cast to void if on purpose
2024-08-29 10:19:27 +02:00