Commit Graph

493 Commits

Author SHA1 Message Date
akallabeth
83ffa524e9 [core,settings] fix ReceivedCapabilities reset 2025-08-26 12:09:09 +02:00
akallabeth
65f18983ed [warnings] Fix format string errors
* Fix casts of format string arguments (%p requires void*)
* Fix format string to match type of arguments
2025-08-13 15:09:48 +02:00
akallabeth
ec8f2b5dde [common,settings] force reallocation on caps copy 2025-07-01 09:49:44 +02:00
akallabeth
a86e3dc53c [client,sdl] print current video driver 2025-06-24 15:43:57 +02:00
akallabeth
efbc9f7cbc [common,settings] fix int casts 2025-06-24 09:38:23 +02:00
akallabeth
6168a7bfd1 [client,common] make all azure settings configurable 2025-06-10 16:30:06 +02:00
akallabeth
635d6319c6 [common,settings] fix freerdp_device_clone
automount property of RDPDR_DTYP_FILESYSTEM was not copied, fix that.
2025-05-22 09:35:03 +02:00
gpotter2
9fce51d7ee Add FreeRDP_RestrictedAdminModeSupported for server-side 2025-05-05 20:15:31 +02:00
akallabeth
06564e4bc2 [core,settings] fix freerdp_device_collection_add
* Assert usage of DeviceArray, ensure returned values are != NULL if
  within DeviceCount
* Only reset newly allocated DeviceArray members on resize
2025-04-25 10:21:37 +02:00
Armin Novak
bc22b9d8da [common,settings] eliminate dead code 2025-04-23 10:13:30 +02:00
Armin Novak
6a20b7bfd8 [common,settings] fix add_string_or_null
* If the value is NULL do not check WINPR_JSON_AddNullToObject return as
  that is most likely also NULL
* Fix testcase, always use goto for error handling
2025-04-23 09:31:59 +02:00
Armin Novak
a4c4bad132 [common,settings] new settings (de)serialization API
* Add rdpKey to PEM conversion
* Modify WINPR_JSON_Version to return -1 if not supported
* Add rdpSettings serialize and deserialize functions
2025-04-22 12:00:48 +02:00
Armin Novak
e92f0170e4 [core,settings] handle empty OrderSupport and received capabilities 2025-04-15 16:09:46 +02:00
akallabeth
7e11df73ba [client,common] add setting FreeRDP_MonitorOverrideFlags
use this mask to mark monitor settings set from command line.
2025-04-10 08:31:56 +02:00
akallabeth
7b9b47555f [core,capabilties] use dynamic logger 2025-03-17 10:52:52 +01:00
akallabeth
3186977e15 [cmake] Invert WITH_FREERDP_3x_DEPRECATED
API breaking change, with this logic the symbol needs to be manually
defined by an API user. So, to fix this:
* Rename to DROP_FREERDP_3x_DEPRECATED
* Invert logic, so a undefined value enables the symbols
2025-03-06 15:30:26 +01:00
akallabeth
d03b4b91d5 [cmake,freerdp] add WITH_FREERDP_3x_DEPRECATED
This new CMake option (ON by default) allows building the library with
all symbols deprecated during 3.x release cycle disabled.
This allows compatibility testing external applications for future
FreeRDP 4.x support
2025-03-04 13:26:45 +01:00
akallabeth
761c62f754 [common,settings] add comments for compat entries 2025-02-14 09:09:46 +01:00
akallabeth
b223b0318b Merge pull request #11167 from akallabeth/unused-warn
Fix all unused warnings
2025-02-14 08:55:33 +01:00
akallabeth
97a79933d6 [common,settings] fix backward compatibility for LocalMonitorOffset
remmina is using the setters for the old (invalid) unsigned offsets
2025-02-13 17:49:22 +01:00
akallabeth
74cd8d8fe0 [freerdp,warnings] fix -Wunused-parameter 2025-02-13 15:53:54 +01:00
akallabeth
579d9b352d [tools,settings] generate getter/setter with maybe_unused
The rdpSettings getter/setter might be empty, so the parameters of the
functions might be unreferenced.
2025-02-13 15:00:15 +01:00
Armin Novak
ac1599333e [common,settings] drop MonitorLocalShiftX|Y compat 2025-02-12 14:04:22 +01:00
akallabeth
745ae2d615 [common,settings] MonitorLocalShift[XY] compat
Allow unsigned access to MonitorLocalShift[XY] values for compatibility
with older releases.
2025-01-19 15:30:58 +01:00
akallabeth
567887fbb0 [core,settings] Fix MONITOR_DEF settings
* Make FreeRDP_MonitorLocalShiftX and FreeRDP_MonitorLocalShiftY signed
* Add function freerdp_settings_set_monitor_def_array_sorted to proplery
  align the MONITOR_DEF array according to RDP requirements
2025-01-19 15:30:56 +01:00
akallabeth
cc934795e4 [warnings] fix integer casting
* use asserting casts to detect overflows or sign conversions
* code cleanup for issues uncovered by casts
2025-01-01 12:58:34 +01:00
akallabeth
a3db26c57a [warnings] fix cast warnings 2024-12-10 17:26:37 +01:00
akallabeth
f25be351b1 [core,gateway] Make tenantid use optional 2024-12-10 15:13:16 +01:00
Armin Novak
f17c1830b7 [aad,avx] improve AzureAD support
* New setting GatewayAzureActiveDirectory to fetch wellknown from
* Clean up command line arguments, rename to make function better
  understandable
2024-12-10 15:12:41 +01:00
akallabeth
1905117465 [core,aad] unify client id
* use a setting to make it configurable
2024-12-10 15:12:32 +01:00
akallabeth
f63a5a5a1f [winpr,endian] Use new winpr_Data_Write_* names 2024-12-08 22:55:58 +01:00
akallabeth
89810b3d96 [common,assistance] fix endianess issues 2024-12-08 22:55:53 +01:00
akallabeth
d5a01a9bf8 [common,assistance] fix endianess issue 2024-12-08 22:55:48 +01:00
akallabeth
83f2f21ad3 [warnigns] fix lots of bugprone warnings
* update-settings-tests: properly cast types in getter/setter
* wtypes: fix PHANDLE definition
* wStream: fix INT64 write function warnings
* Simplify HANDLE copy in channels, just assign after proper cast
2024-12-06 09:15:48 +01:00
David Fort
f0f830f3e9 Cleanup freerdp_settings_set_pointer_len_
Instead of doing convertions to SSIZE_T for the key length id, use FreeRDP_UINT32_UNUSED
when a pointer has no associated len key.
2024-12-04 13:45:39 +01:00
akallabeth
faae38120c [cmake,format] reformat all cmake files 2024-11-27 20:41:48 +01:00
akallabeth
78acedb40e [warnigns] fix Wshorten-64-to-32 2024-11-11 10:22:37 +01:00
akallabeth
dcf5a8e28c [warnings] fix -Wswitch-default 2024-10-31 11:42:24 +01:00
akallabeth
8e33854c62 [tests] improve TestCommonAssistance
Compare encrypted passwords against reference values to ensure the
encryption routines work as expected
2024-10-30 13:22:59 +01:00
akallabeth
2a41730f70 [common,assistance] replace winpr_Cipher_New
* use winpr_Cipher_NewEx where possible
* use winpr_RC4_New where RC4 is used
2024-10-30 13:22:55 +01:00
akallabeth
7ab30a1b18 [client,common] const correct pointer array arguments 2024-10-24 11:32:08 +02:00
Armin Novak
527db6783b [cmake] split tests
* Keep BUILD_TESTING, but only run tests compatible with API (for
  packaging)
* Add BUILD_TESTING_INTERNAL for all tests including internal function
  tests that modify API to be run on our CI
2024-10-24 09:45:44 +02:00
akallabeth
8b3f807a0a [warnings] fix format warnings 2024-10-17 20:47:29 +02:00
akallabeth
dceb15d14e [warnings] fix integer narrowing 2024-10-14 10:32:01 +02:00
akallabeth
ac1a922774 [common,settings] annotate freerdp_settings_set_value_for_name
we cast a SSIZE_T to the required enum value. Since we do not know the
enum contains any value at all it might lead to compiler/analyzer
warning us about that. Silence the warning as we can not avoid it.
2024-10-03 18:59:20 +02:00
akallabeth
315f793078 [common,settings] fix integer narrowing 2024-10-03 18:59:11 +02:00
akallabeth
55a5fe26fb [common,test] remove redundant cast 2024-09-30 09:32:12 +02:00
akallabeth
f529345d84 [warnings] fix Wcast-qual 2024-09-30 09:31:36 +02:00
Armin Novak
c7c84682e1 [warnings] fix mismatched-dealloc
Some allocator functions have an error path where the corresponding free
function is called. Since the memory in the allocator function was
allocated using malloc/calloc the free function does not match. Silence
warnings with pragma macros
2024-09-18 15:35:28 +02:00
akallabeth
f655843260 [return checks] fix use of rdpSettings getter/setter 2024-09-16 06:48:23 +02:00