Armin Novak
2d7bf81397
[proxy,channels] better NULL checks
2025-09-04 10:54:30 +02:00
akallabeth
343d270c5a
[proxy,channels] fix unused parameter warning
2025-09-01 09:18:48 +02:00
akallabeth
2dd38aaeef
[proxy,channels] drop drdynvc packets not tracked
...
When receiving dynamic channel packets that do not belong to an open
channel drop the packet.
2025-08-25 16:26:51 +02:00
akallabeth
dc463e1fcd
[proxy,channels] refactor dynamic channel
...
* Split DynvcTrackerPeekFn into smaller fragments each handling one kind
of packet
* Unify logging with a custom logger function to have unified log
entries with appropriate data logged.
2025-08-25 15:54:19 +02:00
akallabeth
896c8dbd75
[proxy,channels] improve drdynvc logging
...
* Split functions to make them more readable
* Improve logging details
2025-08-22 09:06:37 +02:00
akallabeth
65f18983ed
[warnings] Fix format string errors
...
* Fix casts of format string arguments (%p requires void*)
* Fix format string to match type of arguments
2025-08-13 15:09:48 +02:00
akallabeth
1fe0ca41e1
[warnings] fix missing integer casts
2025-03-11 13:20:19 +01:00
akallabeth
8bd7814e9a
[server,proxy] Log MinorFunction in smartcard channel
2025-03-05 23:48:56 +01:00
akallabeth
150b61d4c2
[proxy,warnings] fix -Wunused-parameter
2025-02-13 15:53:58 +01:00
akallabeth
4df9e30604
[proxy,channels] fix return values and sign conversions
2025-02-13 15:35:15 +01:00
akallabeth
26eac974fe
[warnings] fix integer casting
...
* use WINPR_ASSERTING_INT_CAST where possible
* fix a few inconsistencies
2024-12-19 12:33:42 +01:00
akallabeth
faae38120c
[cmake,format] reformat all cmake files
2024-11-27 20:41:48 +01:00
stephanebill
4f2afa8c47
spell check with codespell
2024-11-20 16:53:40 -05:00
akallabeth
78acedb40e
[warnigns] fix Wshorten-64-to-32
2024-11-11 10:22:37 +01:00
akallabeth
997ff57301
[proxy,rdpdr] fix integer narrow
2024-10-03 18:58:53 +02:00
akallabeth
490ca0453b
[winpr,stream] use Stream_BufferAs instead of casting
2024-10-01 10:34:42 +02:00
akallabeth
a19305569d
[assert] fix ULONG_MAX use
...
most of the time this was used to check ULONG limits. Replace with
correct UINT32_MAX
2024-09-16 08:22:40 +02:00
akallabeth
f1be630637
[server,proxy] fix unchecked return
2024-09-15 09:07:49 +02:00
akallabeth
3820858c63
[server,proxy] discard closed dyn channel data
...
If a dynamic channel does no longer exist or has been closed discard the
channel data received from client
2024-07-25 12:02:51 +02:00
akallabeth
d7ebec5a65
[tidy] move loop variable declaration to loop
2024-02-22 12:31:50 +01:00
akallabeth
0e44b2c674
[clang-tidy] clang-analyzer-unix.Malloc
2024-02-15 11:49:16 +01:00
akallabeth
81d2c1f057
[clang-tidy] clang-analyzer-core.NullDereference
2024-02-15 11:49:16 +01:00
akallabeth
0ba995655d
[clang-tidy] cppcoreguidelines-init-variables
2024-02-15 11:49:16 +01:00
akallabeth
207def5c56
[clang-tidy] readability-isolate-declaration
2024-02-15 11:49:16 +01:00
akallabeth
bb42d425ed
[gcc,clang] add support for attribute(malloc)
...
Mark all malloc like functions and add their appropriate free function
to let the compiler complain on mismatches
2024-02-02 15:10:40 +01:00
Armin Novak
c0df9a50e5
[proxy,drdynvc] fix #9303 broken format string
2023-08-21 10:42:33 +02:00
ehdgks0627
d04ba8d6ef
Correct typos and formatting errors in format strings
...
In several files, fixed typos in format strings that were causing unexpected output and formatting issues.
2023-07-28 15:34:46 +02:00
Armin Novak
e61880d077
[standard] replace __FUNCTION__ with __func__
2023-07-27 20:02:43 +02:00
akallabeth
be7ff37069
[proxy,rdpdr] fix boroken logger calls
2023-06-29 21:06:47 +02:00
akallabeth
2ac8946950
[proxy,channels] drdynvc logging context
...
* Use a dynamic logger for dynamic proxy channel
* Set logger context for dynamic channel
2023-06-29 14:30:09 +02:00
akallabeth
ead2be382c
[proxy,channels] use logger context for rdpdr
2023-06-29 14:30:09 +02:00
Armin Novak
133585cd5e
[proxy,drdynvc] remove dynamic channels on open
...
dynamic channels can be opened at any time during a session. If we
receive a CREATE_REQUEST_PDU and the channel id is already in use, print
out a warning with the existing channel details and discard it before
creating the newly requested channel.
2023-06-29 11:05:37 +02:00
Armin Novak
970f0c54e8
[stream] use const correct Stream_Pointer access
2023-06-08 08:09:33 +02:00
Armin Novak
a4c6b36a19
[build] fix memory sanitizer stack frame warnings
2023-06-07 09:14:45 +02:00
akallabeth
2b3c8c47a4
[build] fix install with BUILD_SHARED_LIBS=OFF
...
generate proper CMake targets so static linking works again.
2023-05-12 08:03:56 +02:00
Armin Novak
ba7840f8ad
[server,proxy] fix rdpdr rewrite
...
do not touch the stream if no rewrite is done.
2023-04-14 08:02:49 +02:00
akallabeth
273bb6a7a8
[build] use static libraries as intermediate
2023-03-01 08:18:34 +01:00
akallabeth
ee07a13130
[cleanup] fix compiler warnings
2023-01-26 09:30:17 +01:00
akallabeth
f26079edf2
[proxy] implement dynamic channel filter
...
* Allow modules to configure intercept channels
* Allow modules to rewrite packets
2023-01-26 09:30:17 +01:00
Armin Novak
641022b795
[logging] remove __FUNCTION__ from actual message
...
prefer the log formatter to provide that information.
2023-01-25 16:26:39 +01:00
akallabeth
075506f6c8
[winpr,stream] use new Stream_CheckAndLogRequiredLength*
2023-01-25 14:27:32 +01:00
akallabeth
74530a7931
[format strings] ensure __LINE__ is of type size_t
...
__LINE__ is not particularily well defined (most fall back to int).
We want to ensure that all the uses in a format string match the format
specifier, so do an explicit cast
2023-01-25 14:27:32 +01:00
akallabeth
275741cc75
[core,utils] add drdynvc stringification functions
2023-01-12 22:54:25 +01:00
akallabeth
0234204130
[proxy,channel] make tracker opaque
2023-01-12 22:54:25 +01:00
Armin Novak
c7868e7a3f
[proxy,rdpdr] added translation layer for rdpdr versions
...
rdpdr filesystem has 2 different versions and mstsc uses the older one
under certain conditions.
2023-01-10 11:49:38 +01:00
Armin Novak
f1e7cc0d48
[rdpdr] unify header read/write
2023-01-10 11:49:38 +01:00
Armin Novak
5a0b8fb688
[proxy,rdpdr] keep capability versions consistent
2023-01-10 11:49:38 +01:00
Armin Novak
c4bbe09649
[server,proxy] rewritten Stream_CheckAndLogRequiredLengthRx
...
make it windows compatible
2022-12-22 15:09:03 +01:00
Armin Novak
b614a2da37
[server,proxy] improve rdpdr channel logging
2022-12-22 15:09:03 +01:00
Armin Novak
37454c7420
[utils] improve rdpdr packet dump
2022-12-22 15:09:03 +01:00
