Commit Graph

229 Commits

Author SHA1 Message Date
Armin Novak
782c3d3069 [client,common] check _fseeki64 return
propagate error conditions back the call chain
2026-03-03 17:15:12 +01:00
Armin Novak
465a6353d5 [c23,client] replace NULL with nullptr 2026-02-26 15:42:59 +01:00
Armin Novak
e58819830a [c23] simplify boolean checks 2026-02-26 11:51:05 +01:00
Armin Novak
48267edf2f [winpr] add WINPR_C_ARRAY_INIT
since C23 allows c++ style initializing replace direct use with this
macro
2026-02-25 19:23:08 +01:00
akallabeth
ea419300b7 [client,common] fix memory leak in rdpParser
When duplicate lines are found in a RDP file the old entry was not freed
up.
2026-01-23 22:34:11 +01:00
akallabeth
d7c1ce80d9 [client,common] fix parsing of enablerdsaadauth
Only change FreeRDP_AadSecurity and do not touch other options
2025-10-03 13:25:53 +02:00
akallabeth
74648eb3a9 [c,standard] use C99 inline 2025-09-26 11:29:26 +02:00
Armin Novak
5bb6e82321 [client,file] enable RDSTLS for entra resources
if enablerdsaadauth is part of a rdp file disable RDP, TLS and NLA and
enable RDSTLS
2025-09-23 16:05:31 +02:00
Armin Novak
4182472c31 [client,common] fix parsing of RdgIsKdcProxy 2025-08-18 11:17:03 +02:00
akallabeth
90f1f2bd37 [client,common] only apply defaults to unset 2025-08-18 09:47:14 +02:00
akallabeth
ad22d5fdff [client,common] add freerdp_client_populate_settings_from_rdp_file_unchecked
Sometimes it is required to have raw values from a RDP file converted to
rdpSettings without consistency modifications. Expose this with a new
function.
2025-08-18 09:47:11 +02:00
akallabeth
14b2dc08eb [client,common] fix rdp parser
freerdp_client_file_string_reset used a return type but did not return
any value.
2025-03-18 17:32:22 +01:00
Martin Fleisz
22ace7e5c6 client: Fix population of string settings in rdp file
When calling `freerdp_client_populate_rdp_file_from_settings` you should
expect that all settings are populated to the rdp file instance. However
certain settings (i.e. cameras to redirect) where only updated if they
had a value but did not reset the setting.

This causes trouble if the file instance was used to load settings,
settings were altered and then populated back to the file instance.
2025-03-18 14:27:26 +01:00
Martin Fleisz
3ec89323c8 client: Fix reading/writing of dynamic resolution RDP file setting 2025-03-10 12:48:14 +01:00
Martin Fleisz
87af371f72 [client] Fix writing incorrect type for integer values in RDP file 2025-03-07 09:46:54 +01:00
Martin Fleisz
f2db1ffe94 client: Move buffer pointer after writing settings 2025-03-05 10:32:06 +01:00
akallabeth
02f59fa3ae [client,file] fix missing NULL check 2025-02-14 13:26:02 +01:00
Armin Novak
e9fd6a33b6 [client,common] fix rdp file parser 2025-02-12 09:50:56 +01:00
akallabeth
45bb63652f [client,common] split freerdp_client_write_rdp_file_buffer 2025-02-11 10:14:56 +01:00
akallabeth
44f5b6c409 [warnings] fix various clang warnings 2025-02-04 11:22:00 +01:00
akallabeth
6701359cc1 [warnings] fix integer casting
* use WINPR_ASSERTING_INT_CAST where possible
* clean up client code
2024-12-19 12:45:23 +01:00
akallabeth
cd1330be80 [client,common] const correct variable declaration 2024-11-22 11:01:01 +01:00
akallabeth
78acedb40e [warnigns] fix Wshorten-64-to-32 2024-11-11 10:22:37 +01:00
akallabeth
aa954d9be9 [warnings] fix various compiler warnings 2024-10-29 15:49:43 +01:00
akallabeth
9caf38bbb6 [warnings] unify CommandLineParseCommaSeparatedValues
CommandLineParseCommaSeparatedValues does some internal hack to allow
the allocated char** to be cleaned up by free.
This enforces compiler warnings as the pointer types do not match.
Use a new free function CommandLineParserFree instead
2024-10-22 21:11:58 +02:00
akallabeth
485ebe03bf [*printf] cast return to void 2024-10-01 13:04:57 +02:00
akallabeth
26003e59cc [va_list] initialize with ={0}; 2024-09-24 11:06:18 +02:00
akallabeth
239440e28d [warnings] remove or comment unused macros 2024-09-20 18:49:38 +02:00
akallabeth
0d5bc92a2b [warnings] fix apple iOS/macos 2024-09-15 19:47:13 +02:00
akallabeth
a1cef8dd85 [warnings] silence and fix unused results 2024-09-14 21:29:28 +02:00
akallabeth
384cd284d8 [warnings] use WINPR_CAST_CONST_AWAY
on locations that require (ugly) const to non const casts usw
WINPR_CAST_CONST_AWAY to do proper compiler specific casts to avoid
warnings
2024-09-11 23:41:50 +02:00
akallabeth
f7fd817d1c [warnings] fix redundant casting 2024-09-03 12:24:51 +02:00
akallabeth
9c9d74e920 [warnings] fix redundant casts 2024-08-29 12:03:09 +02:00
akallabeth
1d33095500 [warnings] fix cert-err33-c
Fix unused return values, cast to void if on purpose
2024-08-29 10:19:27 +02:00
Armin Novak
1f95865907 [client,common] ignore empty strings for channels
Ignore empty strings when parsing redirection channel arguments
2024-08-14 14:31:58 +02:00
akallabeth
a1d8754f1f [core,autodetect] abort on unexpected message. 2024-05-14 11:07:50 +02:00
Martin Fleisz
f62a61886f common: Parse actual value of redirectlocation rdp file setting 2024-04-04 21:20:39 +02:00
akallabeth
c22d9844a4 [client,common] fix incompatible-pointer-types
use a union to cast to expected types.
2024-03-18 13:27:32 +01:00
akallabeth
f764b0a854 [channels,location] implement client channel
* provide client side callbacks to implement platform specific location
  backend glue code
2024-03-11 13:22:12 +01:00
akallabeth
d7ebec5a65 [tidy] move loop variable declaration to loop 2024-02-22 12:31:50 +01:00
akallabeth
f69e1fe697 [clang-tidy] readability-duplicate-include 2024-02-15 11:49:16 +01:00
akallabeth
0ba995655d [clang-tidy] cppcoreguidelines-init-variables 2024-02-15 11:49:16 +01:00
akallabeth
207def5c56 [clang-tidy] readability-isolate-declaration 2024-02-15 11:49:16 +01:00
akallabeth
ba8cf8cf21 [build] fix Wmismatched-deallocator warnings
With custom malloc function attributes the fail path in the _New
functions produces warnings due to allocator mismatches. Silence them.
2024-02-05 08:16:55 +01:00
Armin Novak
6e6559c41a [settings] fix type mismatch warnings 2023-11-24 14:54:56 +01:00
akallabeth
4e438d1c3e [client] make settings opaque 2023-11-24 14:54:56 +01:00
Martin Fleisz
13d35c8a98 client/common: Return NULL/-1 if settings value was not set 2023-11-23 18:05:19 +01:00
Armin Novak
25035b094d [client,common] support redirectlocation in rdp files 2023-11-22 13:01:10 +01:00
Martin Fleisz
ad44573164 cient/common: Apply GatewayCredentialsSource setting read from rdp files 2023-11-09 13:54:20 +01:00
Armin Novak
60390ea40c [pragma] unify compiler diagnostics 2023-10-16 15:10:13 +02:00