Commit Graph

476 Commits

Author SHA1 Message Date
akallabeth
761c62f754 [common,settings] add comments for compat entries 2025-02-14 09:09:46 +01:00
akallabeth
b223b0318b Merge pull request #11167 from akallabeth/unused-warn
Fix all unused warnings
2025-02-14 08:55:33 +01:00
akallabeth
97a79933d6 [common,settings] fix backward compatibility for LocalMonitorOffset
remmina is using the setters for the old (invalid) unsigned offsets
2025-02-13 17:49:22 +01:00
akallabeth
74cd8d8fe0 [freerdp,warnings] fix -Wunused-parameter 2025-02-13 15:53:54 +01:00
akallabeth
579d9b352d [tools,settings] generate getter/setter with maybe_unused
The rdpSettings getter/setter might be empty, so the parameters of the
functions might be unreferenced.
2025-02-13 15:00:15 +01:00
Armin Novak
ac1599333e [common,settings] drop MonitorLocalShiftX|Y compat 2025-02-12 14:04:22 +01:00
akallabeth
745ae2d615 [common,settings] MonitorLocalShift[XY] compat
Allow unsigned access to MonitorLocalShift[XY] values for compatibility
with older releases.
2025-01-19 15:30:58 +01:00
akallabeth
567887fbb0 [core,settings] Fix MONITOR_DEF settings
* Make FreeRDP_MonitorLocalShiftX and FreeRDP_MonitorLocalShiftY signed
* Add function freerdp_settings_set_monitor_def_array_sorted to proplery
  align the MONITOR_DEF array according to RDP requirements
2025-01-19 15:30:56 +01:00
akallabeth
cc934795e4 [warnings] fix integer casting
* use asserting casts to detect overflows or sign conversions
* code cleanup for issues uncovered by casts
2025-01-01 12:58:34 +01:00
akallabeth
a3db26c57a [warnings] fix cast warnings 2024-12-10 17:26:37 +01:00
akallabeth
f25be351b1 [core,gateway] Make tenantid use optional 2024-12-10 15:13:16 +01:00
Armin Novak
f17c1830b7 [aad,avx] improve AzureAD support
* New setting GatewayAzureActiveDirectory to fetch wellknown from
* Clean up command line arguments, rename to make function better
  understandable
2024-12-10 15:12:41 +01:00
akallabeth
1905117465 [core,aad] unify client id
* use a setting to make it configurable
2024-12-10 15:12:32 +01:00
akallabeth
f63a5a5a1f [winpr,endian] Use new winpr_Data_Write_* names 2024-12-08 22:55:58 +01:00
akallabeth
89810b3d96 [common,assistance] fix endianess issues 2024-12-08 22:55:53 +01:00
akallabeth
d5a01a9bf8 [common,assistance] fix endianess issue 2024-12-08 22:55:48 +01:00
akallabeth
83f2f21ad3 [warnigns] fix lots of bugprone warnings
* update-settings-tests: properly cast types in getter/setter
* wtypes: fix PHANDLE definition
* wStream: fix INT64 write function warnings
* Simplify HANDLE copy in channels, just assign after proper cast
2024-12-06 09:15:48 +01:00
David Fort
f0f830f3e9 Cleanup freerdp_settings_set_pointer_len_
Instead of doing convertions to SSIZE_T for the key length id, use FreeRDP_UINT32_UNUSED
when a pointer has no associated len key.
2024-12-04 13:45:39 +01:00
akallabeth
faae38120c [cmake,format] reformat all cmake files 2024-11-27 20:41:48 +01:00
akallabeth
78acedb40e [warnigns] fix Wshorten-64-to-32 2024-11-11 10:22:37 +01:00
akallabeth
dcf5a8e28c [warnings] fix -Wswitch-default 2024-10-31 11:42:24 +01:00
akallabeth
8e33854c62 [tests] improve TestCommonAssistance
Compare encrypted passwords against reference values to ensure the
encryption routines work as expected
2024-10-30 13:22:59 +01:00
akallabeth
2a41730f70 [common,assistance] replace winpr_Cipher_New
* use winpr_Cipher_NewEx where possible
* use winpr_RC4_New where RC4 is used
2024-10-30 13:22:55 +01:00
akallabeth
7ab30a1b18 [client,common] const correct pointer array arguments 2024-10-24 11:32:08 +02:00
Armin Novak
527db6783b [cmake] split tests
* Keep BUILD_TESTING, but only run tests compatible with API (for
  packaging)
* Add BUILD_TESTING_INTERNAL for all tests including internal function
  tests that modify API to be run on our CI
2024-10-24 09:45:44 +02:00
akallabeth
8b3f807a0a [warnings] fix format warnings 2024-10-17 20:47:29 +02:00
akallabeth
dceb15d14e [warnings] fix integer narrowing 2024-10-14 10:32:01 +02:00
akallabeth
ac1a922774 [common,settings] annotate freerdp_settings_set_value_for_name
we cast a SSIZE_T to the required enum value. Since we do not know the
enum contains any value at all it might lead to compiler/analyzer
warning us about that. Silence the warning as we can not avoid it.
2024-10-03 18:59:20 +02:00
akallabeth
315f793078 [common,settings] fix integer narrowing 2024-10-03 18:59:11 +02:00
akallabeth
55a5fe26fb [common,test] remove redundant cast 2024-09-30 09:32:12 +02:00
akallabeth
f529345d84 [warnings] fix Wcast-qual 2024-09-30 09:31:36 +02:00
Armin Novak
c7c84682e1 [warnings] fix mismatched-dealloc
Some allocator functions have an error path where the corresponding free
function is called. Since the memory in the allocator function was
allocated using malloc/calloc the free function does not match. Silence
warnings with pragma macros
2024-09-18 15:35:28 +02:00
akallabeth
f655843260 [return checks] fix use of rdpSettings getter/setter 2024-09-16 06:48:23 +02:00
akallabeth
ba41d5e532 [warnings] fix unchecked return 2024-09-15 09:08:02 +02:00
akallabeth
a1cef8dd85 [warnings] silence and fix unused results 2024-09-14 21:29:28 +02:00
akallabeth
16cec716e0 [strtok] replace function with strtok_s
Since strtok is not thread safe replace it with strtok_s (WinPR wrapper
around strtok_r for systems not supporting the ISO function names)
2024-09-13 21:19:17 +02:00
akallabeth
afff514ca7 [compiler] add WINPR_ATTR_MALLOC
Add WINPR_ATTR_MALLOC checks to allocating functions to help compilers
find memory leaks or allocation mismatches
2024-09-12 20:09:22 +02:00
akallabeth
2638d9d894 [warnings] fix casts 2024-09-12 13:30:00 +02:00
akallabeth
c9b0c9ecd5 [warnings] remove unused variables 2024-09-12 10:08:10 +02:00
akallabeth
ae95b66922 [warnings] fix portability [cm]alloc size 0 2024-09-11 20:50:33 +02:00
akallabeth
6a1c3b4545 [function pointer] use macro for GetProcAddress
Cast all results of GetProcAddress with WINPR_FUNC_PTR_CAST
2024-09-04 21:31:48 +02:00
akallabeth
245afb706c [function pointers] unify casts with macro 2024-09-04 20:06:45 +02:00
akallabeth
baa70d1ab6 [warnings] fix compare integers of different signs 2024-09-03 15:10:46 +02:00
akallabeth
852e0c1450 [common,assistance] fix shadowed variable 2024-09-03 12:17:33 +02:00
akallabeth
3674c5c2f7 [common,assistance] eliminate pedantic cast warnings 2024-08-30 15:40:10 +02:00
akallabeth
190929c018 [warnings] fix function pointer casts 2024-08-30 15:40:01 +02:00
akallabeth
36c3184a0f [warnings] fix clang-tidy issues in libfreerdp 2024-08-29 15:34:22 +02:00
akallabeth
9c9d74e920 [warnings] fix redundant casts 2024-08-29 12:03:09 +02:00
akallabeth
1d33095500 [warnings] fix cert-err33-c
Fix unused return values, cast to void if on purpose
2024-08-29 10:19:27 +02:00
Armin Novak
d71af44bb1 [warnings] disable warnings for generated code
* Disable clang-tidy in test build directories
* Disable compiler warnings for test binary directories.

These contain generated code we can not change, so the warnings are just noise
2024-08-28 09:18:30 +02:00