Commit Graph

4563 Commits

Author SHA1 Message Date
akallabeth
bbd16d922b [client,cmdline] fix vmconnect checks 2025-01-08 21:05:24 +01:00
akallabeth
e4cdeefb95 [client,sdl] fix integer sign conversion 2025-01-07 21:28:21 +01:00
akallabeth
40cdb18431 [client,x11] fix missing assertions 2024-12-31 09:59:52 +01:00
akallabeth
2d95ed6929 Merge pull request #11002 from akallabeth/client-implicit-fix
[warnings] fix integer casting
2024-12-30 23:10:41 +01:00
akallabeth
313c8b7ed3 [client,sdl2] only build if sdl2 >= 2.0.20 found 2024-12-19 13:00:46 +01:00
akallabeth
6701359cc1 [warnings] fix integer casting
* use WINPR_ASSERTING_INT_CAST where possible
* clean up client code
2024-12-19 12:45:23 +01:00
akallabeth
a8b05717bf [cmake] set SYSTEM for external includes
* add winpr_system_includ_directory_add macro for WinPR related external
  include directories
* set target property SYSTEM for SDL related targets
2024-12-18 20:41:59 +01:00
akallabeth
375e28f5cb [client,sdl] use keyboard_layout_remap*
use keyboard layout remap functions from core library
2024-12-17 13:23:05 +01:00
akallabeth
c29e93f4b2 [locale,keyboard] deprecate keyboard mapping
* deprecate keyboard mapping functions:
  * not context sensitive bug app global
  * only work reliable with XKB files
* expose functions to parse and remap RDP scancodes
2024-12-17 12:52:42 +01:00
akallabeth
df12907099 [client,common] fix leak in client_cli_get_rdsaad_access_token 2024-12-16 14:01:49 +01:00
Armin Novak
16a7378c3c [client,common] improve /printer help 2024-12-11 14:33:54 +01:00
akallabeth
f2f81eaac2 Merge pull request #10944 from akallabeth/cmake-clean-fix
[cmake,configure_file] fix change checks
2024-12-10 16:21:37 +01:00
akallabeth
4c7aa61cda [client,sdl] use auto for c++ variables 2024-12-10 15:15:37 +01:00
akallabeth
f25be351b1 [core,gateway] Make tenantid use optional 2024-12-10 15:13:16 +01:00
akallabeth
aac83e4449 [client,sdl] check rdpSettings and wellknown for NULL 2024-12-10 15:12:43 +01:00
Armin Novak
f17c1830b7 [aad,avx] improve AzureAD support
* New setting GatewayAzureActiveDirectory to fetch wellknown from
* Clean up command line arguments, rename to make function better
  understandable
2024-12-10 15:12:41 +01:00
akallabeth
f92984b234 [client,aad] use configurable redirection url
Create the redirection URL for AAD auth from the endpoint configuration.
2024-12-10 15:12:36 +01:00
akallabeth
9fb721b8be [client,common] add parameters for aad auth 2024-12-10 15:12:34 +01:00
akallabeth
b2756842b2 [core,aad] fetch wellknown before GetAccessToken
All of the URL we need for AAD authentication are dependent on a tenantid.
Fetch the wellknown file for the desired tenantid from
https://login.microsoftonline.com/{tenantid}/v2.0/.well-known/openid-configuration
and parse as JSON to have them available later on.
2024-12-10 15:12:30 +01:00
akallabeth
787c49bdbe [client,common] fix call of helper binary
use target output directory instead of manually combined path
2024-12-10 15:10:03 +01:00
akallabeth
91d1c217f9 [client,x11] reset buffer length when sending
When sending clipboard data reset the intermediate buffer position. This
way the buffer is always 0 at beginning of reads, even if the same
clipboard contents is requested in a different format.
2024-12-10 11:55:45 +01:00
akallabeth
dc03c9bc4c [client,x11] fix reset of incremental read
in some cases no event with 0 length is posted for clipboard events.
Ensure the incremental clipboard copy mode is reset when new formats are
announced
2024-12-10 09:58:28 +01:00
akallabeth
3dbbe687ea [client,x11] fix possible NULL dereference 2024-12-09 10:03:17 +01:00
akallabeth
285a6961fa [client,common] deactivate -fsanitize with helper
when compiling manpage generation helper deactivate -fsanitize options
to avoid link/runtime issues.
2024-12-09 07:31:31 +01:00
akallabeth
d780a0705c [client,SDL] fix resource template file 2024-12-08 21:39:28 +01:00
akallabeth
ac27fdaada [client,common] fix manpage generation
strip all compile/link flags for the manpage helper tool. This avoids
linking/runtime issues with e.g. ASAN and other such tools used by
nightly builds and others.
2024-12-08 14:15:08 +01:00
akallabeth
344841714c Merge pull request #10844 from akallabeth/cmake-mulitconfig
Cmake multiconfig
2024-12-07 17:43:05 +01:00
akallabeth
15b2ee55b7 [client,x11] fix type of allocated memory 2024-12-06 11:27:17 +01:00
akallabeth
83f2f21ad3 [warnigns] fix lots of bugprone warnings
* update-settings-tests: properly cast types in getter/setter
* wtypes: fix PHANDLE definition
* wStream: fix INT64 write function warnings
* Simplify HANDLE copy in channels, just assign after proper cast
2024-12-06 09:15:48 +01:00
akallabeth
40cbf65dff [cmdline] fix drive parsing 2024-12-06 08:38:18 +01:00
akallabeth
89bda0f452 [client,sdl] add warning for SDL2 lacking clipboard 2024-12-06 08:38:10 +01:00
akallabeth
48ada610e1 Merge pull request #10923 from akallabeth/clip-crash-fix
[client,x11] fix clipboard incremental data update
2024-12-05 16:13:46 +01:00
akallabeth
6378b3ae72 [client,x11] clean up clipboard reading
prevent possible out of bound reads
2024-12-05 13:28:21 +01:00
akallabeth
141dc8b830 [client,x11] fix some rail z-ordering issues
- Always call xf_XSetTransientForHint unless style has WS_CHILD set.
  xf_XSetTransientForHint in turn checks if a parent is set, which is
  basically the only hint we have for managing/forcing the z-order.
  Everything else is irrelevant in that regard (except WS_EX_TOPMOST)
  See https://learn.microsoft.com/en-us/windows/win32/winmsg/window-features#owned-windows
- Make _NET_WM_STATE_ABOVE only dependent on WS_EX_TOPMOST
2024-12-05 11:22:23 +01:00
akallabeth
ba8fd2ada5 [cmake] force configuration options
limit multiconfiguration options to supported types
2024-12-05 09:36:23 +01:00
Kang Lin
8206610852 [Windows, clipboard] fix server don't support format to applictioin exit.
See: https://github.com/KangLin/RabbitRemoteControl/issues/31
2024-12-05 12:48:28 +08:00
Armin Novak
e12f3fd15a [common,man] eliminate exit() calls 2024-12-04 16:22:28 +01:00
akallabeth
05801a1623 Merge pull request #10773 from akallabeth/wtypes.h
[winpr,wtypes] simplify by basing on stdint.h
2024-12-03 17:50:09 +01:00
akallabeth
9cc79f3797 [winpr,clipboard] fix SetClipboardData
* calloc an additional byte to add (possibly) missing zero termination
* For string types determine length by strnlen
2024-11-30 16:40:24 +01:00
akallabeth
41295e2a0d [winpr,interlocked] code cleanup
* properly compile with and without NONAMELESSUNION
* WINPR_ASSERT all arguments
2024-11-28 15:19:08 +01:00
akallabeth
0d2e20a3c3 [client,windows] fix compilation issues 2024-11-28 15:19:08 +01:00
akallabeth
f7e5e6507b Merge pull request #10895 from akallabeth/cmake-format
Cmake format
2024-11-28 14:52:19 +01:00
Armin Novak
601249115f [codespell] fix spelling mistakes 2024-11-28 11:52:22 +01:00
akallabeth
faae38120c [cmake,format] reformat all cmake files 2024-11-27 20:41:48 +01:00
akallabeth
19b56938bc Merge pull request #10889 from ondrejholy/wip/oholy/x11-segfaults
[client,x11] use xf_lock_x11 in xf_cliprdr_server_format_list
2024-11-25 13:34:04 +01:00
Ondrej Holy
946091bcdb [client,x11] use xf_lock_x11 in xf_cliprdr_server_format_list
Currently, the xfreerdp client segfaults when the
`xf_cliprdr_process_selection_request` and
`xf_cliprdr_server_format_list` functions run concurrently. They are
both reading and writing the `serverFormats`, `numServerFormats`,
`response` and possibly some other properties. Let's use the
`xf_local_x11` in the `xf_cliprdr_server_format_list` function
to prevent this.

See: https://issues.redhat.com/browse/RHEL-68126
2024-11-25 12:49:06 +01:00
akallabeth
cd1330be80 [client,common] const correct variable declaration 2024-11-22 11:01:01 +01:00
akallabeth
79bbb95884 [client,sdl] use std::min 2024-11-22 11:00:27 +01:00
akallabeth
ecbccecef6 [client,sdl] fix global-constructors 2024-11-22 11:00:25 +01:00
amazingfate
53ad1ea860 [client,X11] ignore mouse events not originating in session window
This is a relaunch of d4be1717c2, which
was deleted by e136444f51.
2024-11-21 12:01:33 +01:00