Commit Graph

435 Commits

Author SHA1 Message Date
Armin Novak
73dfd5e143 [server,proxy] avoid _ in struct names 2025-03-19 19:00:12 +01:00
akallabeth
1fe0ca41e1 [warnings] fix missing integer casts 2025-03-11 13:20:19 +01:00
akallabeth
44d5461cd5 [warnings] fix -Wunused-but-set-variable 2025-03-06 07:15:20 +01:00
akallabeth
8bd7814e9a [server,proxy] Log MinorFunction in smartcard channel 2025-03-05 23:48:56 +01:00
akallabeth
d4f7fb081b [warnings] fix -Wunused-function
* delete unused functions that are no longer required
* define guard functions only used while debugging
2025-02-27 19:29:46 +01:00
akallabeth
150b61d4c2 [proxy,warnings] fix -Wunused-parameter 2025-02-13 15:53:58 +01:00
akallabeth
4df9e30604 [proxy,channels] fix return values and sign conversions 2025-02-13 15:35:15 +01:00
akallabeth
a24ffe957c [cmake] make C and C++ standards configurable
use cache variables to allow overriding them from command line
2025-02-13 13:30:06 +01:00
akallabeth
ea2022b76b [clang,tidy] fix warnings 2025-01-15 09:32:52 +01:00
akallabeth
26eac974fe [warnings] fix integer casting
* use WINPR_ASSERTING_INT_CAST where possible
 * fix a few inconsistencies
2024-12-19 12:33:42 +01:00
akallabeth
344841714c Merge pull request #10844 from akallabeth/cmake-mulitconfig
Cmake multiconfig
2024-12-07 17:43:05 +01:00
akallabeth
83f2f21ad3 [warnigns] fix lots of bugprone warnings
* update-settings-tests: properly cast types in getter/setter
* wtypes: fix PHANDLE definition
* wStream: fix INT64 write function warnings
* Simplify HANDLE copy in channels, just assign after proper cast
2024-12-06 09:15:48 +01:00
akallabeth
180a9d7d72 [cmake,flags] print all configuration flags
Since we do not know wich configuration will be build with
multiconfiguration generators print out all C_FLAGS_XXX and
CXX_FLAGS_XXX variables
2024-12-05 09:36:26 +01:00
akallabeth
faae38120c [cmake,format] reformat all cmake files 2024-11-27 20:41:48 +01:00
stephanebill
4f2afa8c47 spell check with codespell 2024-11-20 16:53:40 -05:00
akallabeth
78acedb40e [warnigns] fix Wshorten-64-to-32 2024-11-11 10:22:37 +01:00
akallabeth
dcf5a8e28c [warnings] fix -Wswitch-default 2024-10-31 11:42:24 +01:00
akallabeth
940d067f52 [server,proxy] stricter argument parsing
* Check number of arguments is valid (don't allow additional ones)
* Replace exit() with normal return for helper functions
2024-10-26 19:53:36 +02:00
akallabeth
9caf38bbb6 [warnings] unify CommandLineParseCommaSeparatedValues
CommandLineParseCommaSeparatedValues does some internal hack to allow
the allocated char** to be cleaned up by free.
This enforces compiler warnings as the pointer types do not match.
Use a new free function CommandLineParserFree instead
2024-10-22 21:11:58 +02:00
akallabeth
15d408d6fc [warnings] fix integer narrowing 2024-10-14 10:31:45 +02:00
akallabeth
6c8c67b385 Merge pull request #10677 from akallabeth/int-narrow
Int narrow
2024-10-03 21:17:56 +02:00
akallabeth
997ff57301 [proxy,rdpdr] fix integer narrow 2024-10-03 18:58:53 +02:00
akallabeth
f55a1e2bc3 [proxy,modules] fix integer narrow 2024-10-03 18:58:51 +02:00
akallabeth
10bb42e4d8 [server,proxy] fix integer narrowing 2024-10-03 18:58:48 +02:00
Martin Fleisz
966ddd13df Merge pull request #10694 from akallabeth/qa-fixes
Qa fixes
2024-10-03 13:09:06 +02:00
akallabeth
cfc37caeb8 [cmake] cleaning_configure_file
add a wrapper to automatically add generated files to clean target
2024-10-02 23:28:08 +02:00
akallabeth
e95707f3c7 [server,proxy] annotate bugprone-signal-handler 2024-10-01 13:05:32 +02:00
akallabeth
485ebe03bf [*printf] cast return to void 2024-10-01 13:04:57 +02:00
akallabeth
490ca0453b [winpr,stream] use Stream_BufferAs instead of casting 2024-10-01 10:34:42 +02:00
akallabeth
b1cc0a3191 [proxy,modules] eliminate unused variables 2024-09-24 19:45:16 +02:00
akallabeth
f86f70a022 Merge pull request #10637 from akallabeth/dealloc-fix
[warnings] fix mismatched-dealloc
2024-09-20 10:50:20 +02:00
Armin Novak
96052ca2fb [build,c++] add CXXCompilerFlags to set warnings
Just like with the C components and CompilerFlags.cmake add a
configuration for C++ that disables specific warnings only found in C++
code.
2024-09-20 09:16:30 +02:00
Armin Novak
c7c84682e1 [warnings] fix mismatched-dealloc
Some allocator functions have an error path where the corresponding free
function is called. Since the memory in the allocator function was
allocated using malloc/calloc the free function does not match. Silence
warnings with pragma macros
2024-09-18 15:35:28 +02:00
Armin Novak
65f6541f67 [server,proxy] fix plausibility checks in pf_config_get_uint32 2024-09-18 11:47:01 +02:00
Armin Novak
d55dfa316f [server,proxy] fix unchecked return 2024-09-18 11:47:01 +02:00
Armin Novak
deec4df8c0 [proxy,module] move list in dyn-channel-dump instead of copy 2024-09-18 11:46:56 +02:00
akallabeth
586f40631f [warnings] fix shorten-64-to-32 2024-09-17 16:13:48 +02:00
akallabeth
328b7433a4 [server,proxy] fix unchecked return values 2024-09-17 12:57:34 +02:00
akallabeth
a19305569d [assert] fix ULONG_MAX use
most of the time this was used to check ULONG limits. Replace with
correct UINT32_MAX
2024-09-16 08:22:40 +02:00
akallabeth
bb242b9a89 [return checks] fix use of WaitForSingleObject 2024-09-16 08:22:37 +02:00
akallabeth
965d231e49 [return checks] fix use of CloseHandle 2024-09-16 08:22:31 +02:00
akallabeth
f655843260 [return checks] fix use of rdpSettings getter/setter 2024-09-16 06:48:23 +02:00
akallabeth
7d67b8e204 [return checks] fix use of SetEvent 2024-09-16 06:47:58 +02:00
akallabeth
ba41d5e532 [warnings] fix unchecked return 2024-09-15 09:08:02 +02:00
akallabeth
f1be630637 [server,proxy] fix unchecked return 2024-09-15 09:07:49 +02:00
akallabeth
edf6ab89f7 [warnings] fix dead store 2024-09-10 14:43:11 +02:00
akallabeth
3ab6d2f918 [proxy,modules] fix unchecked return 2024-09-10 14:42:39 +02:00
akallabeth
082c46ba64 [proxy,modules] require C++ 17
Unify required C++ standard and require C++ 17 for all modules. It does
not make a lot of sense to have different standard requirements in the
same project.
2024-09-06 09:20:28 +02:00
akallabeth
749023bacb Merge pull request #10555 from akallabeth/cast-fix-tls
[crypto,tls] simplify function pointer cast
2024-09-05 17:18:27 +02:00
akallabeth
e3f94e6622 nodiscard 2024-09-04 22:17:35 +02:00