From bb5b70305b92694232efde37f1c16c3f3f53377a Mon Sep 17 00:00:00 2001 From: "F. Duncanh" Date: Mon, 16 Jan 2023 00:54:16 -0500 Subject: [PATCH] remove unnecessary audio buffer flush on volume change (may cause audio artefacts) This was first introduced in RPiPlay 2019-07-12 in commit https://github.com/FD-/RPiPlay/commit/ad0872961fc34c3b86eae1ba08e6b820f5ff10bc --- lib/raop_rtp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/raop_rtp.c b/lib/raop_rtp.c index de4e54c..7c21526 100644 --- a/lib/raop_rtp.c +++ b/lib/raop_rtp.c @@ -342,7 +342,7 @@ raop_rtp_process_events(raop_rtp_t *raop_rtp, void *cb_data) /* Call set_volume callback if changed */ if (volume_changed) { - raop_buffer_flush(raop_rtp->buffer, flush); + //raop_buffer_flush(raop_rtp->buffer, flush); /* seems to be unnecessary, may cause audio artefacts */ if (raop_rtp->callbacks.audio_set_volume) { raop_rtp->callbacks.audio_set_volume(raop_rtp->callbacks.cls, volume); }