From d851bd76872978f5f12ff92db3fef3e3e19f72e1 Mon Sep 17 00:00:00 2001 From: Charles Gagnon Date: Thu, 23 Jan 2025 13:32:44 -0500 Subject: [PATCH 1/2] Remove superfluous property --- ui/BoxWindowPreviewOptions.ui | 4 ++-- ui/SettingsFineTune.ui | 10 +++++----- ui/SettingsPosition.ui | 10 +++++----- ui/SettingsStyle.ui | 12 ++++++------ 4 files changed, 18 insertions(+), 18 deletions(-) diff --git a/ui/BoxWindowPreviewOptions.ui b/ui/BoxWindowPreviewOptions.ui index 87cecff..2f3a1ef 100644 --- a/ui/BoxWindowPreviewOptions.ui +++ b/ui/BoxWindowPreviewOptions.ui @@ -322,7 +322,7 @@ False center True - + @@ -331,7 +331,7 @@ False center preview_title_position_bottom_button - + diff --git a/ui/SettingsFineTune.ui b/ui/SettingsFineTune.ui index c9def52..e15fbdd 100644 --- a/ui/SettingsFineTune.ui +++ b/ui/SettingsFineTune.ui @@ -58,7 +58,7 @@ 0 right True - + @@ -76,7 +76,7 @@ 0 right True - + @@ -102,7 +102,7 @@ 0 right True - + @@ -120,7 +120,7 @@ 0 right True - + @@ -138,7 +138,7 @@ 0 right True - + diff --git a/ui/SettingsPosition.ui b/ui/SettingsPosition.ui index 8130f7f..c084ad4 100644 --- a/ui/SettingsPosition.ui +++ b/ui/SettingsPosition.ui @@ -131,7 +131,7 @@ False center True - + @@ -140,7 +140,7 @@ False center position_bottom_button - + @@ -149,7 +149,7 @@ False center position_bottom_button - + @@ -158,7 +158,7 @@ False center position_bottom_button - + @@ -176,7 +176,7 @@ 0 right True - + diff --git a/ui/SettingsStyle.ui b/ui/SettingsStyle.ui index abe5c34..3267bcf 100644 --- a/ui/SettingsStyle.ui +++ b/ui/SettingsStyle.ui @@ -55,7 +55,7 @@ 0 right True - + @@ -73,7 +73,7 @@ 0 right True - + @@ -133,7 +133,7 @@ Bottom center - + @@ -141,7 +141,7 @@ Top center dots_bottom_button - + @@ -149,7 +149,7 @@ Left center dots_bottom_button - + @@ -157,7 +157,7 @@ Right center dots_bottom_button - + From 4d61b95c83e09bbb5c68c07786f5675f62321fa9 Mon Sep 17 00:00:00 2001 From: Charles Gagnon Date: Sun, 26 Jan 2025 14:03:53 -0500 Subject: [PATCH 2/2] Stop re-enabling ubuntu dock --- extension.js | 13 ++----------- panelManager.js | 4 ---- 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/extension.js b/extension.js index 06187b4..412eb95 100644 --- a/extension.js +++ b/extension.js @@ -33,7 +33,6 @@ const UBUNTU_DOCK_UUID = 'ubuntu-dock@ubuntu.com'; let panelManager; let extensionChangedHandler; let startupCompleteHandler; -let disabledUbuntuDock; let extensionSystem = Main.extensionManager; export let DTP_EXTENSION = null; @@ -81,12 +80,6 @@ export default class DashToPanelExtension extends Extension { if (!reset) { extensionSystem.disconnect(extensionChangedHandler); - - if (disabledUbuntuDock) { - disabledUbuntuDock = false; - extensionSystem.enableExtension(UBUNTU_DOCK_UUID); - } - delete global.dashToPanel; AppIcons.resetRecentlyClickedApp(); @@ -104,13 +97,11 @@ export default class DashToPanelExtension extends Extension { function _enable(extension) { let enabled = global.settings.get_strv('enabled-extensions'); - if (enabled?.indexOf(UBUNTU_DOCK_UUID) >= 0) { - disabledUbuntuDock = true; + if (enabled?.indexOf(UBUNTU_DOCK_UUID) >= 0) extensionSystem.disableExtension(UBUNTU_DOCK_UUID); - } if (panelManager) - return panelManager.toggleDash(); // already initialized but ubuntu dock restored the original dash on disable + return SETTINGS = extension.getSettings('org.gnome.shell.extensions.dash-to-panel'); DESKTOPSETTINGS = new Gio.Settings({schema_id: 'org.gnome.desktop.interface'}); diff --git a/panelManager.js b/panelManager.js index 43e93b4..9073739 100755 --- a/panelManager.js +++ b/panelManager.js @@ -296,10 +296,6 @@ export const PanelManager = class { this._desktopIconsUsableArea = null; } - toggleDash() { - this.overview.toggleDash(); - } - _setDesktopIconsMargins() { this._desktopIconsUsableArea?.resetMargins(); this.allPanels.forEach(p => {