From df53e823364ec8c8ba6f2d83337ed7b35dcb1384 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20R=C3=BCedlinger?= Date: Wed, 18 Oct 2017 19:11:00 +0200 Subject: [PATCH 1/4] panel.js: Fix "Too many arguments to method St.Bin.get_child" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit fixes the following JS warning: ``` JS WARNING: [.../dash-to-panel@jderose9.github.com/panel.js 91]: Too many arguments to method St.Bin.get_child: expected 0, got 1 ``` Signed-off-by: Alexander Rüedlinger --- panel.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/panel.js b/panel.js index a4109c1..6da43ff 100644 --- a/panel.js +++ b/panel.js @@ -88,7 +88,7 @@ const dtpPanel = new Lang.Class({ // This pushes everything down, which isn't desired when the this.panel is moved to the bottom // I'm adding a 2nd ghost this.panel and will resize the top or bottom ghost depending on the this.panel position this._myPanelGhost = new St.Bin({ - child: new Clutter.Clone({ source: Main.overview._panelGhost.get_child(0) }), + child: new Clutter.Clone({ source: Main.overview._panelGhost.get_child() }), reactive: false, opacity: 0 }); From e37b3c67254d0ea2dcbbc12172332715ffa45275 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20R=C3=BCedlinger?= Date: Wed, 18 Oct 2017 19:14:35 +0200 Subject: [PATCH 2/4] convenience.js: Fix "reference to undefined property Symbol.toPrimitive" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit fixes the following JS warning: ``` JS WARNING: [/dash-to-panel@jderose9.github.com/convenience.js 122]: reference to undefined property Symbol.toPrimitive ``` Signed-off-by: Alexander Rüedlinger --- convenience.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/convenience.js b/convenience.js index bfedf78..b69c2da 100644 --- a/convenience.js +++ b/convenience.js @@ -119,7 +119,8 @@ const BasicHandler = new Lang.Class({ // skip first element of the arguments for( let i = 1; i < arguments.length; i++ ) { - this._storage[label].push( this._create(arguments[i]) ); + let item = this._storage[label]; + item.push(this._create(arguments[i])); } }, From f3a1c43865f6e86ebf14a1bc77f71af7e36600c6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20R=C3=BCedlinger?= Date: Wed, 18 Oct 2017 19:51:05 +0200 Subject: [PATCH 3/4] appIcons.js: Fix 'reference to undefined property _tweeningToWidth' MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Initialize the variable _tweeningToWidth on the objects _unfocusedDots and _focusedDots to fix the JS warning 'reference to undefined property "_tweeningToWidth"'. Signed-off-by: Alexander Rüedlinger --- appIcons.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/appIcons.js b/appIcons.js index f17f40c..6354a24 100644 --- a/appIcons.js +++ b/appIcons.js @@ -296,7 +296,9 @@ const taskbarAppIcon = new Lang.Class({ } this._focusedDots = new St.DrawingArea({width:1, y_expand: true}); + this._focusedDots._tweeningToWidth = null; this._unfocusedDots = new St.DrawingArea({width:1, y_expand: true}); + this._unfocusedDots._tweeningToWidth = null; this._focusedDots.connect('repaint', Lang.bind(this, function() { if(this._dashItemContainer.animatingOut) { From 5a76f1212f5e16c614d4f32ede642fd02d400b6e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20R=C3=BCedlinger?= Date: Wed, 18 Oct 2017 19:58:53 +0200 Subject: [PATCH 4/4] windowPreview.js: Remove broken code?! MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit removes IMHO broken code. It also fixes the following JS warning: ``` JS WARNING: [/dash-to-panel@jderose9.github.com/windowPreview.js 851]: reference to undefined property "_stateChangedId" ``` Signed-off-by: Alexander Rüedlinger --- windowPreview.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/windowPreview.js b/windowPreview.js index 9f35085..3dabdcd 100644 --- a/windowPreview.js +++ b/windowPreview.js @@ -848,11 +848,6 @@ const thumbnailPreviewList = new Lang.Class({ this._redisplayId = Main.initializeDeferredWork(this.actor, Lang.bind(this, this._redisplay)); this._scrollbarId = Main.initializeDeferredWork(this.actor, Lang.bind(this, this._showHideScrollbar)); - if (this._stateChangedId > 0) { - this.app.disconnect(this._stateChangedId); - this._stateChangedId = 0; - } - this.actor.connect('destroy', Lang.bind(this, this._onDestroy)); this._stateChangedId = this.app.connect('windows-changed', Lang.bind(this,