When a hwmon module was unloaded or crashed any sensors it had that were
also pinned to the panel (i.e. a 'hot sensor') retained the value
they had last, hiding the failure.
To fix that, this first clears all hot labels, replacing them with a
placeholder, before checking the new sensor data. The placeholder
chosen is ⚠ (\u26a0 warning sign), after some experimentation with other
alternatives.
For consistency, the placeholder used on initialization is also
changed.
I think it makes sense to call it the Freon wiki rather than the GitHub
wiki, because code hosting could change, and this wiki is specifically
all about Freon. And I think adding the "Go to" phrase both clarifies
what the button does, and also sorta invites the user to actually click
on the button.
And as for "Sensors Settings", this might be a little nit-picky, but you
don't *usually* pluralize a noun when it's acting as a modifier on
another noun.
To enable more debug logging without custom builds while still
maintaining a minimal syslog impact by default
- Add a settings variable 'debug', hidden from the user
- Use dconf to write/read it (suggest adding to the README and/or
wiki). Only for debugging purposes really
- When 'debug' is set it will enable the possibility of extra logging
- The new 'debug' function also adds in some meta data such as unique
syslog id instead of gnome-shell, file/func/line id to easier locate
in code
- Changed the Render all MenuItems and a couple of outcommented
updated logs to use the new debug function instead
Todo's before no longer WIP:
- Place it somewhere else than in this, cause I presume it wont be
reachable everywhere then
- Consider replacing regular log with something like this as well (to
gain the neat meta data (extension prefix, file, func, line))
- Think some more on the usage of log domains and if possible to turn
of more logging that way instead of dconf variable
According to warning given today with gnome 3.30:
"Some code called array.toString() on a Uint8Array instance. Previously this would have interpreted the bytes of the array as a string, but that is nonstandard. In the future this will return the bytes as comma-separated digits. For the time being, the old behavior has been preserved, but please fix your code anyway to explicitly call ByteArray.toString(array)."