From 1676a4071e9d28d963b558bb5bc3be2198c0f14d Mon Sep 17 00:00:00 2001
From: jj <log@riseup.net>
Date: Sun, 7 Dec 2025 09:40:46 +0100
Subject: [PATCH] patches/spellcheck: update error to mention helium services
 (#572)

---
 .../helium/core/add-updater-preference.patch  |  2 +-
 .../core/reenable-spellcheck-downloads.patch  | 21 ++++++++++++++++++-
 .../helium/core/ublock-helium-services.patch  |  2 +-
 .../settings/fix-text-on-cookies-page.patch   |  4 ++--
 .../helium/settings/privacy-page-tweaks.patch |  2 +-
 5 files changed, 25 insertions(+), 6 deletions(-)

diff --git a/patches/helium/core/add-updater-preference.patch b/patches/helium/core/add-updater-preference.patch
index dbe80704..9fe8cf4f 100644
--- a/patches/helium/core/add-updater-preference.patch
+++ b/patches/helium/core/add-updater-preference.patch
@@ -136,7 +136,7 @@ TODO: guard services_page.html with is_mac
    registry->RegisterBooleanPref(
 --- a/chrome/app/settings_strings.grdp
 +++ b/chrome/app/settings_strings.grdp
-@@ -1993,6 +1993,12 @@
+@@ -1996,6 +1996,12 @@
    <message name="IDS_SETTINGS_HELIUM_SERVICES_SPELLCHECK_TOGGLE_DESCRIPTION" desc="Description of the for enabling/disabling of downloading spellcheck files">
      Helium will fetch dictionary files used for spell checking when requested. When disabled, spell checking will not work.
    </message>
diff --git a/patches/helium/core/reenable-spellcheck-downloads.patch b/patches/helium/core/reenable-spellcheck-downloads.patch
index cd7a0c05..3bb5c91d 100644
--- a/patches/helium/core/reenable-spellcheck-downloads.patch
+++ b/patches/helium/core/reenable-spellcheck-downloads.patch
@@ -144,7 +144,17 @@
      </template>
 --- a/chrome/app/settings_strings.grdp
 +++ b/chrome/app/settings_strings.grdp
-@@ -1987,6 +1987,12 @@
+@@ -1291,6 +1291,9 @@
+       <message name="IDS_SETTINGS_LANGUAGES_DICTIONARY_DOWNLOAD_FAILED_HELP" desc="Error message when spell dictionary download fails more than once possibly due to a network policy or configuration.">
+         Please check with your network administrator to make sure that the firewall is not blocking downloads from Google servers.
+       </message>
++      <message name="IDS_SETTINGS_LANGUAGES_DICTIONARY_DOWNLOAD_FAILED_HELP_HELIUM" desc="Error message when spell dictionary download fails more than once possibly due to a network policy or configuration.">
++        Please check that Helium services are enabled (including spell check downloads) and make sure that the firewall is not blocking downloads from Helium servers.
++      </message>
+     </if>
+   </if>
+   <if expr="is_chromeos">
+@@ -1987,6 +1990,12 @@
    <message name="IDS_SETTINGS_HELIUM_SERVICES_BANGS_TOGGLE_DESCRIPTION" desc="Description of the toggle for enabling/disabling of downloading bangs">
      Helium will fetch a list of bangs that help you browse the Internet faster, such as !w or !gh. When disabled, bangs will not work.
    </message>
@@ -159,6 +169,15 @@
    </message>
 --- a/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
 +++ b/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
+@@ -1241,7 +1241,7 @@ void AddLanguagesStrings(content::WebUID
+       {"languagesDictionaryDownloadError",
+        IDS_SETTINGS_LANGUAGES_DICTIONARY_DOWNLOAD_FAILED},
+       {"languagesDictionaryDownloadErrorHelp",
+-       IDS_SETTINGS_LANGUAGES_DICTIONARY_DOWNLOAD_FAILED_HELP},
++       IDS_SETTINGS_LANGUAGES_DICTIONARY_DOWNLOAD_FAILED_HELP_HELIUM},
+ #endif
+ #endif  // !BUILDFLAG(IS_CHROMEOS)
+ #if BUILDFLAG(IS_CHROMEOS)
 @@ -2128,6 +2128,9 @@ void AddPrivacyStrings(content::WebUIDat
        {"heliumBangsToggle", IDS_SETTINGS_HELIUM_SERVICES_BANGS_TOGGLE},
        {"heliumBangsToggleDescription",
diff --git a/patches/helium/core/ublock-helium-services.patch b/patches/helium/core/ublock-helium-services.patch
index a84a6d1a..80a21a0e 100644
--- a/patches/helium/core/ublock-helium-services.patch
+++ b/patches/helium/core/ublock-helium-services.patch
@@ -217,7 +217,7 @@
                  if ( bin.assetSourceRegistry instanceof Object ) {
 --- a/chrome/app/settings_strings.grdp
 +++ b/chrome/app/settings_strings.grdp
-@@ -1999,6 +1999,12 @@
+@@ -2002,6 +2002,12 @@
    <message name="IDS_SETTINGS_HELIUM_SERVICES_UPDATE_DESCRIPTION" desc="Description of the toggle for automatic update downloads">
      Helium will automatically download and install browser updates as they become available. We recommend keeping this setting enabled to ensure you get the latest security patches and features.
    </message>
diff --git a/patches/helium/settings/fix-text-on-cookies-page.patch b/patches/helium/settings/fix-text-on-cookies-page.patch
index 49ad2741..171b9ed0 100644
--- a/patches/helium/settings/fix-text-on-cookies-page.patch
+++ b/patches/helium/settings/fix-text-on-cookies-page.patch
@@ -1,6 +1,6 @@
 --- a/chrome/app/settings_strings.grdp
 +++ b/chrome/app/settings_strings.grdp
-@@ -1947,6 +1947,9 @@
+@@ -1950,6 +1950,9 @@
    <message name="IDS_SETTINGS_ENABLE_DO_NOT_TRACK_DIALOG_TEXT" desc="The text of a confirmation dialog that confirms that the user want to send the 'Do Not Track' header">
      Enabling "Do Not Track" means that a request will be included with your browsing traffic. Any effect depends on whether a website responds to the request, and how the request is interpreted. For example, some websites may respond to this request by showing you ads that aren't based on other websites you've visited. Many websites will still collect and use your browsing data - for example to improve security, to provide content, services, ads and recommendations on their websites, and to generate reporting statistics.
    </message>
@@ -10,7 +10,7 @@
    <message name="IDS_SETTINGS_ENABLE_DO_NOT_TRACK_DIALOG_LEARN_MORE_ACCESSIBILITY_LABEL" desc="The accessibility label for a link to learn more about Do Not Track">
      Learn more about Do Not Track
    </message>
-@@ -3204,6 +3207,9 @@
+@@ -3207,6 +3210,9 @@
    <message name="IDS_SETTINGS_TRACKING_PROTECTION_SITES_ALLOWED_COOKIES_DESCRIPTION" desc="Description of the section on the Tracking Protection settings page that lets users manage which sites are allowed to use third-party cookies. Explains how to use a wildcard to create an exception for an entire domain.">
      Affects the sites listed here. Inserting “[*.]” before a domain name creates an exception for the entire domain. For example, adding “[*.]google.com” means that third-party cookies can also be active for mail.google.com, because it’s part of google.com.
    </message>
diff --git a/patches/helium/settings/privacy-page-tweaks.patch b/patches/helium/settings/privacy-page-tweaks.patch
index fb4ed751..c6e2e957 100644
--- a/patches/helium/settings/privacy-page-tweaks.patch
+++ b/patches/helium/settings/privacy-page-tweaks.patch
@@ -1,6 +1,6 @@
 --- a/chrome/app/settings_strings.grdp
 +++ b/chrome/app/settings_strings.grdp
-@@ -1960,6 +1960,12 @@
+@@ -1963,6 +1963,12 @@
    users to manage security settings">
      Security
    </message>