From 8930f2ae91682546172a107ca36424a2a2224ace Mon Sep 17 00:00:00 2001
From: wukko <me@wukko.me>
Date: Fri, 12 Dec 2025 17:50:55 +0600
Subject: [PATCH] helium/core/services: add description & first changelog

---
 patches/helium/core/add-native-bangs.patch    |  6 ++---
 .../helium/core/add-updater-preference.patch  |  6 ++---
 patches/helium/core/onboarding-page.patch     |  4 ++--
 .../core/proxy-extension-downloads.patch      |  8 +++----
 .../core/reenable-spellcheck-downloads.patch  |  6 ++---
 .../search/force-eu-search-features.patch     |  2 +-
 patches/helium/core/services-prefs.patch      | 22 ++++++++++++++-----
 .../helium/core/ublock-helium-services.patch  |  6 ++---
 .../settings/fix-text-on-cookies-page.patch   |  4 ++--
 9 files changed, 38 insertions(+), 26 deletions(-)

diff --git a/patches/helium/core/add-native-bangs.patch b/patches/helium/core/add-native-bangs.patch
index 59d64eb7..bd740960 100644
--- a/patches/helium/core/add-native-bangs.patch
+++ b/patches/helium/core/add-native-bangs.patch
@@ -724,7 +724,7 @@
  COMPONENT_EXPORT(HELIUM) GURL GetDummyURL();
 --- a/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
 +++ b/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
-@@ -2132,6 +2132,9 @@ void AddPrivacyStrings(content::WebUIDat
+@@ -2134,6 +2134,9 @@ void AddPrivacyStrings(content::WebUIDat
          IDS_SETTINGS_HELIUM_SERVICES_EXT_PROXY_TOGGLE},
        {"heliumExtProxyToggleDescription",
          IDS_SETTINGS_HELIUM_SERVICES_EXT_PROXY_TOGGLE_DESCRIPTION},
@@ -736,7 +736,7 @@
          IDS_SETTINGS_HELIUM_SERVICES_OVERRIDE_DESCRIPTION},
 --- a/chrome/app/settings_strings.grdp
 +++ b/chrome/app/settings_strings.grdp
-@@ -1987,6 +1987,12 @@
+@@ -1990,6 +1990,12 @@
    <message name="IDS_SETTINGS_HELIUM_SERVICES_EXT_PROXY_TOGGLE_DESCRIPTION" desc="Description of the toggle for enabling/disabling of downloading and proxying extensions">
      When enabled, Helium will proxy extension downloads and updates to protect your privacy. When disabled, downloading and updating extensions will not work.
    </message>
@@ -751,7 +751,7 @@
    </message>
 --- a/chrome/browser/resources/settings/privacy_page/services_page.html
 +++ b/chrome/browser/resources/settings/privacy_page/services_page.html
-@@ -89,6 +89,11 @@
+@@ -92,6 +92,11 @@
                  label="$i18n{heliumExtProxyToggle}"
                  sub-label="$i18n{heliumExtProxyToggleDescription}">
              </settings-toggle-button>
diff --git a/patches/helium/core/add-updater-preference.patch b/patches/helium/core/add-updater-preference.patch
index de1d7cc5..97d9e8c2 100644
--- a/patches/helium/core/add-updater-preference.patch
+++ b/patches/helium/core/add-updater-preference.patch
@@ -76,7 +76,7 @@
    registrar.Add(prefs::kHeliumServicesEnabled, observer);
 --- a/chrome/browser/resources/settings/privacy_page/services_page.html
 +++ b/chrome/browser/resources/settings/privacy_page/services_page.html
-@@ -101,6 +101,11 @@
+@@ -104,6 +104,11 @@
                      sub-label="$i18n{heliumSpellcheckToggleDescription}">
                  </settings-toggle-button>
              </if>
@@ -90,7 +90,7 @@
      </template>
 --- a/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
 +++ b/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
-@@ -2138,6 +2138,10 @@ void AddPrivacyStrings(content::WebUIDat
+@@ -2140,6 +2140,10 @@ void AddPrivacyStrings(content::WebUIDat
        {"heliumSpellcheckToggle", IDS_SETTINGS_HELIUM_SERVICES_SPELLCHECK_TOGGLE},
        {"heliumSpellcheckToggleDescription",
          IDS_SETTINGS_HELIUM_SERVICES_SPELLCHECK_TOGGLE_DESCRIPTION},
@@ -124,7 +124,7 @@
    registry->RegisterBooleanPref(
 --- a/chrome/app/settings_strings.grdp
 +++ b/chrome/app/settings_strings.grdp
-@@ -2002,6 +2002,19 @@
+@@ -2005,6 +2005,19 @@
    <message name="IDS_SETTINGS_HELIUM_SERVICES_SPELLCHECK_TOGGLE_DESCRIPTION" desc="Description of the for enabling/disabling of downloading spellcheck files">
      Helium will fetch dictionary files used for spell checking when requested. When disabled, spell checking will not work.
    </message>
diff --git a/patches/helium/core/onboarding-page.patch b/patches/helium/core/onboarding-page.patch
index 3df01965..71633eb6 100644
--- a/patches/helium/core/onboarding-page.patch
+++ b/patches/helium/core/onboarding-page.patch
@@ -532,7 +532,7 @@
  
 --- a/chrome/app/settings_strings.grdp
 +++ b/chrome/app/settings_strings.grdp
-@@ -1953,6 +1953,12 @@
+@@ -1956,6 +1956,12 @@
    <message name="IDS_SETTINGS_HELIUM_SCHEMA_IGNORE" desc="Checkbox label to ignore any future services change alerts">
      Don't notify me again
    </message>
@@ -601,7 +601,7 @@
          <template is="dom-if" if="[[changes_.length]]">
            <div id="changelog-notice">
              <div id="changelog-title">$i18n{heliumSchemaUpdatedTitle}</div>
-@@ -54,6 +86,7 @@
+@@ -57,6 +89,7 @@
          <cr-collapse id="servicesCollapse" opened="[[prefs.helium.services.enabled.value]]">
          </cr-collapse>
      </div>
diff --git a/patches/helium/core/proxy-extension-downloads.patch b/patches/helium/core/proxy-extension-downloads.patch
index f2792e1d..71af9f12 100644
--- a/patches/helium/core/proxy-extension-downloads.patch
+++ b/patches/helium/core/proxy-extension-downloads.patch
@@ -187,7 +187,7 @@
      registry->RegisterBooleanPref(prefs::kHeliumServicesConsented, false);
 --- a/chrome/browser/resources/settings/privacy_page/services_page.html
 +++ b/chrome/browser/resources/settings/privacy_page/services_page.html
-@@ -84,6 +84,11 @@
+@@ -87,6 +87,11 @@
      </settings-toggle-button>
      <div class="cr-col">
          <cr-collapse id="servicesCollapse" opened="[[prefs.helium.services.enabled.value]]">
@@ -201,8 +201,8 @@
      </template>
 --- a/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
 +++ b/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
-@@ -2128,6 +2128,10 @@ void AddPrivacyStrings(content::WebUIDat
-       {"heliumSchemaUpdatedTitle", IDS_SETTINGS_HELIUM_SCHEMA_NOTICE_TITLE},
+@@ -2130,6 +2130,10 @@ void AddPrivacyStrings(content::WebUIDat
+         IDS_SETTINGS_HELIUM_SCHEMA_NOTICE_DESCRIPTION},
        {"heliumGotIt", IDS_SETTINGS_GOT_IT},
        {"heliumSchemaIgnore", IDS_SETTINGS_HELIUM_SCHEMA_IGNORE},
 +      {"heliumExtProxyToggle",
@@ -214,7 +214,7 @@
          IDS_SETTINGS_HELIUM_SERVICES_OVERRIDE_DESCRIPTION},
 --- a/chrome/app/settings_strings.grdp
 +++ b/chrome/app/settings_strings.grdp
-@@ -1981,6 +1981,12 @@
+@@ -1984,6 +1984,12 @@
    <message name="IDS_SETTINGS_HELIUM_SERVICES_TOGGLE_DESCRIPTION" desc="Description of the toggle for enabling/disabling of all Helium services">
      When enabled, Helium will be able to connect to anonymous web services to provide additional functionality. When disabled, additional features will not work.
    </message>
diff --git a/patches/helium/core/reenable-spellcheck-downloads.patch b/patches/helium/core/reenable-spellcheck-downloads.patch
index 891a09b4..a1d43abd 100644
--- a/patches/helium/core/reenable-spellcheck-downloads.patch
+++ b/patches/helium/core/reenable-spellcheck-downloads.patch
@@ -128,7 +128,7 @@
      registry->RegisterBooleanPref(prefs::kHeliumServicesConsented, false);
 --- a/chrome/browser/resources/settings/privacy_page/services_page.html
 +++ b/chrome/browser/resources/settings/privacy_page/services_page.html
-@@ -94,6 +94,13 @@
+@@ -97,6 +97,13 @@
                  label="$i18n{heliumBangsToggle}"
                  sub-label="$i18n{heliumBangsToggleDescription}">
              </settings-toggle-button>
@@ -154,7 +154,7 @@
      </if>
    </if>
    <if expr="is_chromeos">
-@@ -1993,6 +1996,12 @@
+@@ -1996,6 +1999,12 @@
    <message name="IDS_SETTINGS_HELIUM_SERVICES_BANGS_TOGGLE_DESCRIPTION" desc="Description of the toggle for enabling/disabling of downloading bangs">
      Helium will fetch a list of bangs that help you browse the Internet faster, such as !w or !gh. When disabled, bangs will not work.
    </message>
@@ -178,7 +178,7 @@
  #endif
  #endif  // !BUILDFLAG(IS_CHROMEOS)
  #if BUILDFLAG(IS_CHROMEOS)
-@@ -2135,6 +2135,9 @@ void AddPrivacyStrings(content::WebUIDat
+@@ -2137,6 +2137,9 @@ void AddPrivacyStrings(content::WebUIDat
        {"heliumBangsToggle", IDS_SETTINGS_HELIUM_SERVICES_BANGS_TOGGLE},
        {"heliumBangsToggleDescription",
          IDS_SETTINGS_HELIUM_SERVICES_BANGS_TOGGLE_DESCRIPTION},
diff --git a/patches/helium/core/search/force-eu-search-features.patch b/patches/helium/core/search/force-eu-search-features.patch
index fd7b6a76..5e080520 100644
--- a/patches/helium/core/search/force-eu-search-features.patch
+++ b/patches/helium/core/search/force-eu-search-features.patch
@@ -16,7 +16,7 @@
  #include "components/safe_browsing/core/common/features.h"
  #include "components/safe_browsing/core/common/hashprefix_realtime/hash_realtime_utils.h"
  #include "components/saved_tab_groups/public/features.h"
-@@ -2665,14 +2663,9 @@ void AddSearchStrings(content::WebUIData
+@@ -2667,14 +2665,9 @@ void AddSearchStrings(content::WebUIData
    html_source->AddString("searchExplanationLearnMoreURL",
                           chrome::kOmniboxLearnMoreURL);
  
diff --git a/patches/helium/core/services-prefs.patch b/patches/helium/core/services-prefs.patch
index c47820ce..a97b8320 100644
--- a/patches/helium/core/services-prefs.patch
+++ b/patches/helium/core/services-prefs.patch
@@ -1,6 +1,6 @@
 --- a/chrome/app/settings_strings.grdp
 +++ b/chrome/app/settings_strings.grdp
-@@ -1941,6 +1941,37 @@
+@@ -1941,6 +1941,40 @@
    <message name="IDS_SETTINGS_SECURITY_DESCRIPTION" desc="Description of the controls available on the security settings page">
      Safe Browsing (protection from dangerous sites) and other security settings
    </message>
@@ -13,6 +13,9 @@
 +  <message name="IDS_SETTINGS_HELIUM_SCHEMA_NOTICE_TITLE" desc="Title of the alert shown when Helium services have a change in behavior">
 +    Updates to Helium services:
 +  </message>
++  <message name="IDS_SETTINGS_HELIUM_SCHEMA_NOTICE_DESCRIPTION" desc="Description of the alert shown when Helium services have a change in behavior">
++    These changes are not active until you dismiss this notice.
++  </message>
 +  <message name="IDS_SETTINGS_HELIUM_SCHEMA_IGNORE" desc="Checkbox label to ignore any future services change alerts">
 +    Don't notify me again
 +  </message>
@@ -40,7 +43,7 @@
      Google Advanced Protection Program
 --- a/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
 +++ b/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
-@@ -2117,6 +2117,21 @@ void AddPrivacyStrings(content::WebUIDat
+@@ -2117,6 +2117,23 @@ void AddPrivacyStrings(content::WebUIDat
        {"siteSettingsSublabel", IDS_SETTINGS_PERMISSIONS_DESCRIPTION},
        {"securityPageTitle", IDS_SETTINGS_SECURITY},
        {"securityPageDescription", IDS_SETTINGS_SECURITY_DESCRIPTION},
@@ -50,6 +53,8 @@
 +      {"heliumServicesToggleDescription",
 +        IDS_SETTINGS_HELIUM_SERVICES_TOGGLE_DESCRIPTION},
 +      {"heliumSchemaUpdatedTitle", IDS_SETTINGS_HELIUM_SCHEMA_NOTICE_TITLE},
++      {"heliumSchemaUpdatedDescription",
++        IDS_SETTINGS_HELIUM_SCHEMA_NOTICE_DESCRIPTION},
 +      {"heliumGotIt", IDS_SETTINGS_GOT_IT},
 +      {"heliumSchemaIgnore", IDS_SETTINGS_HELIUM_SCHEMA_IGNORE},
 +      {"heliumOriginOverride", IDS_SETTINGS_HELIUM_SERVICES_OVERRIDE},
@@ -170,7 +175,7 @@
    }
 --- /dev/null
 +++ b/chrome/browser/resources/settings/privacy_page/services_page.html
-@@ -0,0 +1,86 @@
+@@ -0,0 +1,89 @@
 +<style include="cr-shared-style settings-shared">
 +    .label-wrapper {
 +        padding: var(--cr-section-vertical-padding) 0;
@@ -210,6 +215,9 @@
 +                    <li>[[change]]</li>
 +                </template>
 +            </ul>
++            <div id="changelog-description">
++                $i18n{heliumSchemaUpdatedDescription}
++            </div>
 +            <div id="changelog-notice-actions">
 +                <cr-button on-click="onAcknowledgedChangelog_">$i18n{heliumGotIt}</cr-button>
 +                <cr-checkbox id="checkbox" checked="{{ignoreChecked_}}">
@@ -661,7 +669,7 @@
 +#endif  // CHROME_BROWSER_UI_WEBUI_SETTINGS_SERVICES_SCHEMA_HANDLER_H_
 --- /dev/null
 +++ b/components/helium_services/schema.cc
-@@ -0,0 +1,36 @@
+@@ -0,0 +1,40 @@
 +// Copyright 2025 The Helium Authors
 +// You can use, redistribute, and/or modify this source code under
 +// the terms of the GPL-3.0 license that can be found in the LICENSE file.
@@ -691,7 +699,11 @@
 +ServicesChangelog& GetChangelog() {
 +  static constexpr auto kHeliumSchemaChangelog =
 +      base::MakeFixedFlatMap<int, std::string_view>({
-+          {1, "TBA ____________________"}
++          {
++            1,
++            "Automatic component updates are now available. They're managed by the same toggle that enables automatic browser updates.\n"
++            "From now on, you'll be notified about major changes to Helium services. Even though these notifications are extremely rare, you can choose to ignore them and accept all future changes automatically."
++          }
 +      });
 +
 +  return kHeliumSchemaChangelog;
diff --git a/patches/helium/core/ublock-helium-services.patch b/patches/helium/core/ublock-helium-services.patch
index 9c6559b6..793db8d7 100644
--- a/patches/helium/core/ublock-helium-services.patch
+++ b/patches/helium/core/ublock-helium-services.patch
@@ -217,7 +217,7 @@
                  if ( bin.assetSourceRegistry instanceof Object ) {
 --- a/chrome/app/settings_strings.grdp
 +++ b/chrome/app/settings_strings.grdp
-@@ -2015,6 +2015,12 @@
+@@ -2018,6 +2018,12 @@
        Helium will automatically download and install browser and component updates as they become available. We recommend keeping this setting enabled to ensure you get the latest features and security updates. Automatic core browser updates are not available on this platform yet, but component updates are. Please use external software to keep Helium up to date.
      </message>
    </if>
@@ -232,7 +232,7 @@
    </message>
 --- a/chrome/browser/resources/settings/privacy_page/services_page.html
 +++ b/chrome/browser/resources/settings/privacy_page/services_page.html
-@@ -106,6 +106,11 @@
+@@ -109,6 +109,11 @@
                  label="$i18n{heliumUpdatesToggle}"
                  sub-label="$i18n{heliumUpdatesToggleDescription}">
              </settings-toggle-button>
@@ -246,7 +246,7 @@
      </template>
 --- a/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
 +++ b/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
-@@ -2142,6 +2142,10 @@ void AddPrivacyStrings(content::WebUIDat
+@@ -2144,6 +2144,10 @@ void AddPrivacyStrings(content::WebUIDat
          IDS_SETTINGS_HELIUM_SERVICES_UPDATE},
        {"heliumUpdatesToggleDescription",
          IDS_SETTINGS_HELIUM_SERVICES_UPDATE_DESCRIPTION},
diff --git a/patches/helium/settings/fix-text-on-cookies-page.patch b/patches/helium/settings/fix-text-on-cookies-page.patch
index 37fd484d..fd1133fd 100644
--- a/patches/helium/settings/fix-text-on-cookies-page.patch
+++ b/patches/helium/settings/fix-text-on-cookies-page.patch
@@ -10,7 +10,7 @@
    <message name="IDS_SETTINGS_ENABLE_DO_NOT_TRACK_DIALOG_LEARN_MORE_ACCESSIBILITY_LABEL" desc="The accessibility label for a link to learn more about Do Not Track">
      Learn more about Do Not Track
    </message>
-@@ -3220,6 +3223,9 @@
+@@ -3223,6 +3226,9 @@
    <message name="IDS_SETTINGS_TRACKING_PROTECTION_SITES_ALLOWED_COOKIES_DESCRIPTION" desc="Description of the section on the Tracking Protection settings page that lets users manage which sites are allowed to use third-party cookies. Explains how to use a wildcard to create an exception for an entire domain.">
      Affects the sites listed here. Inserting “[*.]” before a domain name creates an exception for the entire domain. For example, adding “[*.]google.com” means that third-party cookies can also be active for mail.google.com, because it’s part of google.com.
    </message>
@@ -31,7 +31,7 @@
        {"doNotTrackDialogLearnMoreA11yLabel",
         IDS_SETTINGS_ENABLE_DO_NOT_TRACK_DIALOG_LEARN_MORE_ACCESSIBILITY_LABEL},
        // TODO(crbug.com/40122957): This string is no longer used. Remove.
-@@ -2832,7 +2832,7 @@ void AddSiteSettingsStrings(content::Web
+@@ -2834,7 +2834,7 @@ void AddSiteSettingsStrings(content::Web
        {"trackingProtectionSitesAllowedCookiesTitle",
         IDS_SETTINGS_TRACKING_PROTECTION_SITES_ALLOWED_COOKIES_TITLE},
        {"trackingProtectionSitesAllowedCookiesDescription",