From 89e55a70de1466bc3c33b32f6babefc3c05abbea Mon Sep 17 00:00:00 2001 From: Serhiy Mytrovtsiy Date: Sat, 1 Jul 2023 19:34:54 +0200 Subject: [PATCH] fix: prevented adding the 'Fan value' toggle each time when loading the popup settings (#1542) --- Modules/Sensors/popup.swift | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/Modules/Sensors/popup.swift b/Modules/Sensors/popup.swift index e2145587..b5125951 100644 --- a/Modules/Sensors/popup.swift +++ b/Modules/Sensors/popup.swift @@ -62,6 +62,13 @@ internal class Popup: PopupWrapper { self.spacing = 0 self.translatesAutoresizingMaskIntoConstraints = false + self.settingsView.addArrangedSubview(selectSettingsRow( + title: localizedString("Fan value"), + action: #selector(self.toggleFanValue), + items: FanValues, + selected: self.fanValueState.rawValue + )) + self.fanValueState = FanValue(rawValue: Store.shared.string(key: "Sensors_popup_fanValue", defaultValue: self.fanValueState.rawValue)) ?? .percentage } @@ -80,15 +87,15 @@ internal class Popup: PopupWrapper { self.subviews.forEach({ $0.removeFromSuperview() }) if !reload { self.settingsView.subviews.forEach({ $0.removeFromSuperview() }) + + self.settingsView.addArrangedSubview(selectSettingsRow( + title: localizedString("Fan value"), + action: #selector(self.toggleFanValue), + items: FanValues, + selected: self.fanValueState.rawValue + )) } - self.settingsView.addArrangedSubview(selectSettingsRow( - title: localizedString("Fan value"), - action: #selector(self.toggleFanValue), - items: FanValues, - selected: self.fanValueState.rawValue - )) - if !fans.isEmpty { self.addArrangedSubview(self.fansSeparatorView())