diff --git a/src/core/exec-invoke.c b/src/core/exec-invoke.c index 0a29da522e..ef501607b6 100644 --- a/src/core/exec-invoke.c +++ b/src/core/exec-invoke.c @@ -1201,6 +1201,7 @@ static int setup_pam( _cleanup_(barrier_destroy) Barrier barrier = BARRIER_NULL; _cleanup_strv_free_ char **e = NULL; + _cleanup_free_ char *tty = NULL; pam_handle_t *handle = NULL; sigset_t old_ss; int pam_code = PAM_SUCCESS, r; @@ -1236,15 +1237,14 @@ static int setup_pam( goto fail; } - const char *tty = context->tty_path; - if (!tty) { - _cleanup_free_ char *q = NULL; + if (getttyname_malloc(STDIN_FILENO, &tty) >= 0) { + _cleanup_free_ char *q = path_join("/dev", tty); + if (!q) { + r = -ENOMEM; + goto fail; + } - /* Hmm, so no TTY was explicitly passed, but an fd passed to us directly might be a TTY. Let's figure - * out if that's the case, and read the TTY off it. */ - - if (getttyname_malloc(STDIN_FILENO, &q) >= 0) - tty = strjoina("/dev/", q); + free_and_replace(tty, q); } if (tty) {