From 770170fa622372540979e7c66629727dbd4d8ecb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Fri, 10 Oct 2025 10:02:49 +0200 Subject: [PATCH] Revert "meson: fail build when encountering unused variables" This reverts commit e1e1ef09f9bc7d2ca1f6876f4f4d13268be5a50d. This change was misguided. The warning is enough during development and will get fixed, but turning this into a hard failure just makes WIP harder. Also, a hard error increases the likelyhood of a build failure in scenarios where somebody is disabling components (as seen e.g. in ba8801a07640205778c5a62539597c68d7bdb211). We already are not very good at keeping our codebase compile correctly as it ages, because of changes in compilers and dependencies, and we should not go out of our way to increase the probability of failure. Such scenarios are painful for downstream builds. --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build index 6f37831536..555e9460ed 100644 --- a/meson.build +++ b/meson.build @@ -405,7 +405,6 @@ possible_common_cc_flags = [ '-Werror=shift-overflow=2', '-Werror=strict-flex-arrays', '-Werror=undef', - '-Werror=unused-variable', '-Wfloat-equal', # gperf prevents us from enabling this because it does not emit fallthrough # attribute with clang.