From 7a7ec2bf71b146aaa217732d2ad029e730ffb3cd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Thu, 21 Sep 2017 18:36:45 +0200 Subject: [PATCH] install: move and rename to lowercase two functions No reason to make them look like macros. --- src/shared/install.c | 18 ++++++++++++++++-- src/shared/install.h | 14 -------------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/shared/install.c b/src/shared/install.c index 9e4e0eaf6f..d73727e403 100644 --- a/src/shared/install.c +++ b/src/shared/install.c @@ -83,6 +83,20 @@ typedef struct { size_t n_rules; } Presets; +static inline bool unit_file_install_info_has_rules(UnitFileInstallInfo *i) { + assert(i); + + return !strv_isempty(i->aliases) || + !strv_isempty(i->wanted_by) || + !strv_isempty(i->required_by); +} + +static inline bool unit_file_install_info_has_also(UnitFileInstallInfo *i) { + assert(i); + + return !strv_isempty(i->also); +} + static inline void presets_freep(Presets *p) { size_t i; @@ -2593,9 +2607,9 @@ static int unit_file_lookup_state( if (r < 0) return r; if (r == 0) { - if (UNIT_FILE_INSTALL_INFO_HAS_RULES(i)) + if (unit_file_install_info_has_rules(i)) state = UNIT_FILE_DISABLED; - else if (UNIT_FILE_INSTALL_INFO_HAS_ALSO(i)) + else if (unit_file_install_info_has_also(i)) state = UNIT_FILE_INDIRECT; else state = UNIT_FILE_STATIC; diff --git a/src/shared/install.h b/src/shared/install.h index 7a5859e729..c1fcbe96ed 100644 --- a/src/shared/install.h +++ b/src/shared/install.h @@ -132,20 +132,6 @@ struct UnitFileInstallInfo { bool auxiliary; }; -static inline bool UNIT_FILE_INSTALL_INFO_HAS_RULES(UnitFileInstallInfo *i) { - assert(i); - - return !strv_isempty(i->aliases) || - !strv_isempty(i->wanted_by) || - !strv_isempty(i->required_by); -} - -static inline bool UNIT_FILE_INSTALL_INFO_HAS_ALSO(UnitFileInstallInfo *i) { - assert(i); - - return !strv_isempty(i->also); -} - bool unit_type_may_alias(UnitType type) _const_; bool unit_type_may_template(UnitType type) _const_;