From 8240a0942bad98fe5a3129bb86d4c0d0798be320 Mon Sep 17 00:00:00 2001 From: Luca Boccassi Date: Fri, 17 Oct 2025 10:19:49 +0100 Subject: [PATCH] blockdev-list: add overflow check assert Fixes coverity warning CID#1630794 --- src/shared/blockdev-list.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/shared/blockdev-list.c b/src/shared/blockdev-list.c index 16a0e2bb25..57f80bb111 100644 --- a/src/shared/blockdev-list.c +++ b/src/shared/blockdev-list.c @@ -111,7 +111,8 @@ int blockdev_list(BlockDevListFlags flags, BlockDevice **ret_devices, size_t *re if (r < 0) log_debug_errno(r, "Failed to acquire size of device '%s', ignoring: %m", node); else - size *= 512; /* the 'size' sysattr is always in multiples of 512, even on 4K sector block devices! */ + /* the 'size' sysattr is always in multiples of 512, even on 4K sector block devices! */ + assert_se(MUL_ASSIGN_SAFE(&size, 512)); /* Overflow check for coverity */ if (size == 0 && FLAGS_SET(flags, BLOCKDEV_LIST_IGNORE_EMPTY)) { log_debug("Device '%s' has a zero size, assuming drive without a medium, skipping.", node);