From 86cdffd1069f5ebb6ded3988e5a2eca59b0a6e81 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Mon, 4 Jun 2018 18:05:09 +0200 Subject: [PATCH] core: log when unit_add_dependency() fails for some reason Also, proceed, as there's little we can do in this case. --- src/core/device.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/core/device.c b/src/core/device.c index ba69fdc70d..b4f162d1b7 100644 --- a/src/core/device.c +++ b/src/core/device.c @@ -409,7 +409,7 @@ static bool device_is_bound_by_mounts(Device *d, struct udev_device *dev) { return d->bind_mounts; } -static int device_upgrade_mount_deps(Unit *u) { +static void device_upgrade_mount_deps(Unit *u) { Unit *other; Iterator i; void *v; @@ -423,9 +423,8 @@ static int device_upgrade_mount_deps(Unit *u) { r = unit_add_dependency(other, UNIT_BINDS_TO, u, true, UNIT_DEPENDENCY_UDEV); if (r < 0) - return r; + log_unit_warning_errno(u, r, "Failed to add BindsTo= dependency between device and mount unit, ignoring: %m"); } - return 0; } static int device_setup_unit(Manager *m, struct udev_device *dev, const char *path, bool main) {