clang-tidy: Fix all remaining misc-include-cleaner violations

- Remove unused includes
- Add common false positive headers to misc-include-cleaner.IgnoreHeaders
- Add IWYU pragma keep for uncommon false positive headers

src/basic/alloc-util.h

@@ -4,7 +4,7 @@
 #include <stdlib.h>
 
 #include "basic-forward.h"
-#include "memory-util.h"
+#include "memory-util.h"        /* IWYU pragma: keep */
 
 #if HAS_FEATURE_MEMORY_SANITIZER
 #  include <sanitizer/msan_interface.h>

src/basic/architecture.h

@@ -1,7 +1,7 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 #pragma once
 
-#include <endian.h>     /* IWYU pragma: keep */
+#include <endian.h>
 
 #include "basic-forward.h"
 

src/basic/confidential-virt.c

@@ -9,9 +9,9 @@
 
 #include "confidential-virt.h"
 #include "confidential-virt-fundamental.h"
-#include "errno-util.h"
+#include "errno-util.h"                                 /* IWYU pragma: keep */
 #include "fd-util.h"
-#include "fileio.h"
+#include "fileio.h"                                     /* IWYU pragma: keep */
 #include "log.h"
 #include "string-table.h"
 #include "string-util.h"

src/basic/dirent-util.h

@@ -1,10 +1,10 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 #pragma once
 
-#include <dirent.h>     /* IWYU pragma: export */
+#include <dirent.h>             /* IWYU pragma: export */
 
 #include "basic-forward.h"
-#include "path-util.h"
+#include "path-util.h"          /* IWYU pragma: keep */
 
 bool dirent_is_file(const struct dirent *de) _pure_;
 bool dirent_is_file_with_suffix(const struct dirent *de, const char *suffix) _pure_;

src/basic/format-util.h

@@ -1,9 +1,9 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 #pragma once
 
-#include "cgroup-util.h"
 #include "basic-forward.h"
-#include "stdio-util.h"
+#include "cgroup-util.h"
+#include "stdio-util.h"         /* IWYU pragma: keep */
 
 assert_cc(sizeof(pid_t) == sizeof(int32_t));
 #define PID_PRI PRIi32

src/basic/raw-clone.c

@@ -4,9 +4,9 @@
   Copyright © 2016 Michael Karcher
 ***/
 
-#include <errno.h>
+#include <errno.h>                      /* IWYU pragma: keep */
 #include <sched.h>
-#include <sys/syscall.h>
+#include <sys/syscall.h>                /* IWYU pragma: keep */
 #include <unistd.h>
 
 #include "process-util.h"

src/basic/string-table.h

@@ -1,7 +1,8 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
-
 #pragma once
 
+#include <stdio.h>
+
 #include "basic-forward.h"
 
 const char* string_table_lookup_to_string(const char * const *table, size_t len, ssize_t i) _const_;

src/basic/time-util.c

@@ -1,7 +1,6 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 
 #include <stdlib.h>
-#include <sys/mman.h>
 #include <sys/timerfd.h>
 #include <threads.h>
 #include <unistd.h>
@@ -10,15 +9,14 @@
 #include "env-util.h"
 #include "errno-util.h"
 #include "extract-word.h"
+#include "hexdecoct.h"          /* IWYU pragma: keep */
 #include "fd-util.h"
 #include "fileio.h"
 #include "fs-util.h"
-#include "hexdecoct.h"
 #include "io-util.h"
 #include "log.h"
 #include "parse-util.h"
 #include "path-util.h"
-#include "process-util.h"
 #include "stat-util.h"
 #include "stdio-util.h"
 #include "string-table.h"

src/basic/unit-def.c

@@ -1,7 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 
-#include <stdio.h>
-
 #include "alloc-util.h"
 #include "bus-label.h"
 #include "glyph-util.h"

src/basic/virt.c

@@ -8,7 +8,7 @@
 #include <unistd.h>
 
 #include "alloc-util.h"
-#include "dirent-util.h"
+#include "dirent-util.h"        /* IWYU pragma: keep */
 #include "env-util.h"
 #include "extract-word.h"
 #include "fd-util.h"