diff --git a/src/analyze/analyze-security.c b/src/analyze/analyze-security.c index 5408cfdeaa..fb743a895f 100644 --- a/src/analyze/analyze-security.c +++ b/src/analyze/analyze-security.c @@ -27,9 +27,7 @@ #include "parse-util.h" #include "path-util.h" #include "pretty-print.h" -#if HAVE_SECCOMP -# include "seccomp-util.h" -#endif +#include "seccomp-util.h" #include "service.h" #include "set.h" #include "stdio-util.h" diff --git a/src/core/dbus-execute.c b/src/core/dbus-execute.c index 52964390ae..395051e57f 100644 --- a/src/core/dbus-execute.c +++ b/src/core/dbus-execute.c @@ -2,11 +2,6 @@ #include #include - -#if HAVE_SECCOMP -#include -#endif - #include "af-list.h" #include "alloc-util.h" #include "bus-get-properties.h" @@ -37,9 +32,7 @@ #include "pcre2-util.h" #include "process-util.h" #include "rlimit-util.h" -#if HAVE_SECCOMP #include "seccomp-util.h" -#endif #include "securebits-util.h" #include "specifier.h" #include "stat-util.h" diff --git a/src/core/execute.c b/src/core/execute.c index f9761b7239..5ffb088aee 100644 --- a/src/core/execute.c +++ b/src/core/execute.c @@ -26,10 +26,6 @@ #include #endif -#if HAVE_SECCOMP -#include -#endif - #if HAVE_APPARMOR #include #endif @@ -93,9 +89,7 @@ #include "recurse-dir.h" #include "rlimit-util.h" #include "rm-rf.h" -#if HAVE_SECCOMP #include "seccomp-util.h" -#endif #include "securebits-util.h" #include "selinux-util.h" #include "signal-util.h" diff --git a/src/core/load-fragment.c b/src/core/load-fragment.c index ceca070e79..9d1fd0f7a7 100644 --- a/src/core/load-fragment.c +++ b/src/core/load-fragment.c @@ -7,9 +7,6 @@ #include #include #include -#if HAVE_SECCOMP -#include -#endif #include #include @@ -56,9 +53,7 @@ #include "pcre2-util.h" #include "percent-util.h" #include "process-util.h" -#if HAVE_SECCOMP #include "seccomp-util.h" -#endif #include "securebits-util.h" #include "selinux-util.h" #include "signal-util.h" diff --git a/src/core/main.c b/src/core/main.c index c09f922700..df9cfa21aa 100644 --- a/src/core/main.c +++ b/src/core/main.c @@ -8,9 +8,6 @@ #include #include #include -#if HAVE_SECCOMP -#include -#endif #if HAVE_VALGRIND_VALGRIND_H # include #endif @@ -82,9 +79,7 @@ #include "psi-util.h" #include "random-util.h" #include "rlimit-util.h" -#if HAVE_SECCOMP #include "seccomp-util.h" -#endif #include "selinux-setup.h" #include "selinux-util.h" #include "signal-util.h" diff --git a/src/nspawn/nspawn-oci.c b/src/nspawn/nspawn-oci.c index a4eda80ea0..5bdfebde78 100644 --- a/src/nspawn/nspawn-oci.c +++ b/src/nspawn/nspawn-oci.c @@ -1,9 +1,6 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include -#if HAVE_SECCOMP -#include -#endif #include "bus-util.h" #include "cap-list.h" @@ -19,9 +16,7 @@ #include "nspawn-oci.h" #include "path-util.h" #include "rlimit-util.h" -#if HAVE_SECCOMP #include "seccomp-util.h" -#endif #include "stdio-util.h" #include "string-util.h" #include "strv.h" diff --git a/src/nspawn/nspawn-seccomp.c b/src/nspawn/nspawn-seccomp.c index 5f45f367d0..34a8627848 100644 --- a/src/nspawn/nspawn-seccomp.c +++ b/src/nspawn/nspawn-seccomp.c @@ -6,16 +6,10 @@ #include #include -#if HAVE_SECCOMP -#include -#endif - #include "alloc-util.h" #include "log.h" #include "nspawn-seccomp.h" -#if HAVE_SECCOMP #include "seccomp-util.h" -#endif #include "string-util.h" #include "strv.h" diff --git a/src/nspawn/nspawn-settings.h b/src/nspawn/nspawn-settings.h index 0a3d975364..8edf8a3552 100644 --- a/src/nspawn/nspawn-settings.h +++ b/src/nspawn/nspawn-settings.h @@ -4,10 +4,6 @@ #include #include -#if HAVE_SECCOMP -#include -#endif - #include "sd-bus.h" #include "sd-id128.h" @@ -18,6 +14,7 @@ #include "missing_resource.h" #include "nspawn-expose-ports.h" #include "nspawn-mount.h" +#include "seccomp-util.h" #include "time-util.h" typedef enum StartMode { diff --git a/src/nspawn/nspawn.c b/src/nspawn/nspawn.c index e614b05c83..d3ae547746 100644 --- a/src/nspawn/nspawn.c +++ b/src/nspawn/nspawn.c @@ -96,9 +96,7 @@ #include "resolve-util.h" #include "rlimit-util.h" #include "rm-rf.h" -#if HAVE_SECCOMP #include "seccomp-util.h" -#endif #include "selinux-util.h" #include "signal-util.h" #include "socket-util.h" diff --git a/src/shared/bus-unit-util.c b/src/shared/bus-unit-util.c index e7b44cc39b..ad1957d9d7 100644 --- a/src/shared/bus-unit-util.c +++ b/src/shared/bus-unit-util.c @@ -37,9 +37,7 @@ #include "percent-util.h" #include "process-util.h" #include "rlimit-util.h" -#if HAVE_SECCOMP #include "seccomp-util.h" -#endif #include "securebits-util.h" #include "signal-util.h" #include "socket-util.h" @@ -117,9 +115,6 @@ DEFINE_BUS_APPEND_PARSE("i", ioprio_class_from_string); DEFINE_BUS_APPEND_PARSE("i", ip_tos_from_string); DEFINE_BUS_APPEND_PARSE("i", log_facility_unshifted_from_string); DEFINE_BUS_APPEND_PARSE("i", log_level_from_string); -#if !HAVE_SECCOMP -static inline int seccomp_parse_errno_or_action(const char *eq) { return -EINVAL; } -#endif DEFINE_BUS_APPEND_PARSE("i", seccomp_parse_errno_or_action); DEFINE_BUS_APPEND_PARSE("i", sched_policy_from_string); DEFINE_BUS_APPEND_PARSE("i", secure_bits_from_string); diff --git a/src/shared/seccomp-util.h b/src/shared/seccomp-util.h index 9c6016449e..7583357e8a 100644 --- a/src/shared/seccomp-util.h +++ b/src/shared/seccomp-util.h @@ -2,8 +2,8 @@ #pragma once #if HAVE_SECCOMP - #include +#endif #include #include @@ -13,6 +13,8 @@ #include "set.h" #include "string-util.h" +#if HAVE_SECCOMP + const char* seccomp_arch_to_string(uint32_t c); int seccomp_arch_from_string(const char *n, uint32_t *ret); @@ -143,6 +145,18 @@ int parse_syscall_archs(char **l, Set **ret_archs); uint32_t scmp_act_kill_process(void); +int parse_syscall_and_errno(const char *in, char **name, int *error); + +int seccomp_suppress_sync(void); + +#else + +static inline bool is_seccomp_available(void) { + return false; +} + +#endif + /* This is a special value to be used where syscall filters otherwise expect errno numbers, will be replaced with real seccomp action. */ enum { @@ -164,15 +178,3 @@ static inline const char *seccomp_errno_or_action_to_string(int num) { return "kill"; return errno_to_name(num); } - -int parse_syscall_and_errno(const char *in, char **name, int *error); - -int seccomp_suppress_sync(void); - -#else - -static inline bool is_seccomp_available(void) { - return false; -} - -#endif diff --git a/src/test/test-execute.c b/src/test/test-execute.c index 2316d2b615..0be66c2c7b 100644 --- a/src/test/test-execute.c +++ b/src/test/test-execute.c @@ -23,9 +23,7 @@ #include "path-util.h" #include "process-util.h" #include "rm-rf.h" -#if HAVE_SECCOMP #include "seccomp-util.h" -#endif #include "service.h" #include "signal-util.h" #include "static-destruct.h"