From 875d22d8f1a282e60353eea5c7bc016bde7d217a Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Mon, 29 Jul 2019 15:52:27 +0200 Subject: [PATCH 1/4] TODO: remove item implemented in f05e1ae6660 --- TODO | 3 --- 1 file changed, 3 deletions(-) diff --git a/TODO b/TODO index 159d540cea..8b5ca66571 100644 --- a/TODO +++ b/TODO @@ -116,9 +116,6 @@ Features: * when no locale is configured, default to UEFI's PlatformLang variable -* When logind.conf contains HandleLidSwitch=suspend-then-hibernate and we can't - hibernate because the swap partition isn't large enough, still suspend - * bootctl,sd-boot: actually honour the "architecture" key * add a new syscall group "@esoteric" for more esoteric stuff such as bpf() and From 1f57abb3091c9ceb771fb9bd32f8f66404d439e1 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Mon, 29 Jul 2019 15:59:20 +0200 Subject: [PATCH 2/4] udev: warn on rules files with weird access modes --- src/udev/udev-rules.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/udev/udev-rules.c b/src/udev/udev-rules.c index 64b0b9b102..3473a7eb7e 100644 --- a/src/udev/udev-rules.c +++ b/src/udev/udev-rules.c @@ -1186,6 +1186,8 @@ static int parse_file(UdevRules *rules, const char *filename) { return -errno; } + (void) fd_warn_permissions(filename, fileno(f)); + if (null_or_empty_fd(fileno(f))) { log_debug("Skipping empty file: %s", filename); return 0; From b7dcc0efdf04bb7603f797a401080798c2c9cedc Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Mon, 29 Jul 2019 16:00:26 +0200 Subject: [PATCH 3/4] TODO: drop udev access mode item we just implemented --- TODO | 2 -- 1 file changed, 2 deletions(-) diff --git a/TODO b/TODO index 8b5ca66571..a950c3ae04 100644 --- a/TODO +++ b/TODO @@ -83,8 +83,6 @@ Features: * make rfkill uaccess controllable by default, i.e. steal rule from gnome-bluetooth and friends -* warn if udev rules files are marked executable (docker?) - * tweak journald context caching. In addition to caching per-process attributes keyed by PID, cache per-cgroup attributes (i.e. the various xattrs we read) keyed by cgroup path, and guarded by ctime changes. This should provide us From 9aac172f706a3e0d1e255cf7e1e70de2e01be54f Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Mon, 29 Jul 2019 18:35:07 +0200 Subject: [PATCH 4/4] update TODO --- TODO | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/TODO b/TODO index a950c3ae04..9b4a42a4a7 100644 --- a/TODO +++ b/TODO @@ -149,7 +149,8 @@ Features: non-zero "tries done" count * maybe set a special xattr on cgroups that have delegate=yes set, to make it - easy to mark cut points + easy to mark cut points, then use this information in "systemd-cgls" to show + them (e.g. color delegated subtrees in a different color) * introduce an option (or replacement) for "systemctl show" that outputs all properties as JSON, similar to busctl's new JSON output. In contrast to that