Commit Graph

32618 Commits

Author SHA1 Message Date
Zbigniew Jędrzejewski-Szmek
67f63ee5ae shared/dissect-image: inline iterator variables 2021-02-25 14:07:21 +01:00
Zbigniew Jędrzejewski-Szmek
8794e6dbbd core/namespace: inline more iterator variable declarations 2021-02-25 14:07:21 +01:00
Zbigniew Jędrzejewski-Szmek
06cd836342 resolved: inline trivial function 2021-02-25 14:07:21 +01:00
Lennart Poettering
9c274488a9 signal-util: make -1 termination of ignore_signals() argument list unnecessary
Clean up ignore_signals() + default_signals() + sigaction_many() a bit:
make it unnecessary to explicitly terminate the signal list with -1.
Merge all three calls into a single function that is just called with
slightly different parameters. And eliminate an unnecessary extra
iteration in its inner for() loop.

No change in behaviour.
2021-02-25 11:32:28 +01:00
Zbigniew Jędrzejewski-Szmek
155d626bc6 Merge pull request #18018 from bluca/mount_images_overlay
Add ExtensionImages directive to form overlays
2021-02-25 11:31:14 +01:00
Dan Streetman
b66789a9b5 test: skip tests if cgroup isn't mounted
Debian builds in a chroot without cgroup mounted, so tests expecting
to access cgroup will fail with ENOMEDIUM, so skip the tests in that
situation.
2021-02-25 16:32:04 +09:00
Lennart Poettering
a437c5e4da cgroup: don't generate BPF firewall unsupported warning on wrong unit
Let's generate the warning on a unit that actually needs the BPF
firewall, and not confusingly already for a sibling of one.
2021-02-25 16:31:46 +09:00
Lennart Poettering
249a967f62 format-table: don't suppress trailing whitespace in first line
We underline the first line, hence we shouldn't suppress the whitespace,
otherwise the line will end early.

Follow-up for: 71894e1831
2021-02-25 16:31:25 +09:00
Joerg Behrmann
fa02711758 treewide: fix spelling 2021-02-25 05:54:11 +09:00
Annika Wickert
c0267a592a network: Implement B.A.T.M.A.N. Advanced interface type 2021-02-25 01:57:29 +09:00
Sergey Bugaev
2aaf376597 resolved: don't discard mDNS queries with bad flags
Even though RFC 6762 specifies these bits MUST be zero, it also says they MUST
be ignored on reception.
2021-02-24 17:17:03 +01:00
Sergey Bugaev
7675501540 resolved: don't discard mDNS packets with ip6.arpa RRs
ip6.arpa is also a valid domain name to put in mDNS packets.
2021-02-24 17:17:03 +01:00
Yu Watanabe
2be6c4758e timedate: do not ignore fix_system argument in SetLocalRTC method
Fixes #18391.
2021-02-24 23:50:21 +09:00
Yu Watanabe
b34b57a738 clock-util: rename function argument 2021-02-24 19:56:14 +09:00
Zbigniew Jędrzejewski-Szmek
d9a65c5976 Merge pull request #18730 from yuwata/dhcp6-client-do-not-set-t1-t2-18090
dhcp6: do not set T1 and T2 in IA_PD option or friends
2021-02-24 09:53:37 +01:00
Yu Watanabe
ebc98027fc Merge pull request #18589 from yuwata/network-nexthop-drop-unnecessary-nexthops
network: drop unnecessary nexthops
2021-02-24 09:07:57 +09:00
Lennart Poettering
eceb61112c bootspec: assume that the root dir is at the top of its file system
Fixes: #17746
2021-02-23 18:43:34 +01:00
Zbigniew Jędrzejewski-Szmek
0892c3b2eb Merge pull request #18763 from poettering/cov-fixes
A bunch of coverity fixes
2021-02-23 18:41:53 +01:00
Luca Boccassi
93f597013a Add ExtensionImages directive to form overlays
Add support for overlaying images for services on top of their
root fs, using a read-only overlay.
2021-02-23 15:34:46 +00:00
Luca Boccassi
82fb2da213 core/namespace: reafactor applying mounts in a separate function
The setup_namespace code to apply mounts is a big if block that
keeps growing, so refactor it in a separate function.
2021-02-23 15:34:46 +00:00
Luca Boccassi
280b3781bd sysext: split parsing SYSTEMD_SYSEXT_HIERARCHIES in a common helper 2021-02-23 15:34:46 +00:00
Lennart Poettering
685097b9ca efi stub: accept it if our loaded image has no FilePath field set
The firmware spec doesn't really say whether FilePath of the LoadedImage
protocol may be NULL or not. So far we assumed it to be non-NULL, but
apparently the FreeBSD UEFI chainloader sets it to NULL. Handle this
gracefully.

(Noticed and tracked down by Alexander Schreiber)

Fixes: #18733
2021-02-23 15:48:48 +01:00
Lennart Poettering
f2550b9856 core: fix memory leak in error path
Coverity 1431998
2021-02-23 15:45:26 +01:00
Lennart Poettering
013668db32 resolved: don't dereference ->scope unless set
Coverity 1446388
2021-02-23 15:45:23 +01:00
Lennart Poettering
3178014709 shared: fix memory leak in error path
Coverity 1446676
2021-02-23 15:45:19 +01:00
Lennart Poettering
d9a650bbe8 icmp6-util: add missing variable initialization
Coverity 1446712
2021-02-23 15:45:15 +01:00
Lennart Poettering
d9119c00fa dissect-image: initially fds[] array fully
THe previous code wasn't wrong, but it's certainly nicer to avoid a
partially uninitialized array here, hence Coverity has a point
complaining about this.

Coverity 1446731
2021-02-23 15:45:12 +01:00
Lennart Poettering
999c248629 resolved: fix minor memory leak
Coverity 1446992
2021-02-23 15:45:03 +01:00
Yu Watanabe
e94a009c10 core: fix stack-use-after-scope
Fixes a bug introduced by f70e6fb471.

Fixes #18753.
2021-02-23 15:39:31 +01:00
Yu Watanabe
25b82b6e0e network: nexthop: drop unnecessary nexthops
Similar to addresses or routes, this makes networkd drops unnecessary
nexthops on configuring links or when a link is dropped.
2021-02-23 22:47:11 +09:00
Yu Watanabe
0e9d129c16 network: nexthop: read protocol in received netlink message
Preparation of later commits.
2021-02-23 22:47:11 +09:00
Yu Watanabe
e64e052e17 sd-netlink: introduce sd_rtnl_message_nexthop_get_protocol() 2021-02-23 22:47:11 +09:00
Yu Watanabe
774c0e433c Revert "meson: remove one more instance of install_dir:bindir"
This reverts commit 5ffa2eaa54.

It seems that if install_dir is not specified, meson decides install path
based on file type, and non-executable binary files are installed under
/usr/share.

kernel-install is a script. So, we need to set install_dir argument
explicitly.

Fixes #18754.
2021-02-23 13:52:55 +01:00
Yu Watanabe
73b49d433c dhcp6: do not set T1 and T2 by dhcp6_option_append_pd() in client
Fixes #18090.
2021-02-23 19:36:37 +09:00
Yu Watanabe
e7613578b4 dhcp6: do not set T1 and T2 by dhcp6_option_append_ia() in client 2021-02-23 19:36:37 +09:00
Yu Watanabe
1e84213a43 dhcp6: make dhcp6_option_parse_{address,pdprefix}() return -EINVAL when received address or prefix is refused
And then the caller ignores the error.
Otherwise, `ret_liftime_valid` is not set even if they succeeds.
2021-02-23 19:36:23 +09:00
Yu Watanabe
cf6c33bd6b dhcp6: do not use input value before checking 2021-02-23 18:49:11 +09:00
Zbigniew Jędrzejewski-Szmek
2b767e9222 resolved: add another explanatory message to stub resolv.conf files
Apparently people do "cat /etc/resolv.conf" and not realize that they
are looking at a file in /run.
2021-02-23 17:20:23 +09:00
Lennart Poettering
048e043375 resolved: actually use the specified rrsig argument
The argument only exists to be used to override/fill in the RRSIG record
of the answer item. Hence actually use it instead of ignore it.

(Not sure how this got lost earlier.)

Fixes: #18714
2021-02-23 01:52:33 +01:00
Zbigniew Jędrzejewski-Szmek
67e700bad7 Merge pull request #18741 from poettering/stub-no-cname
resolved: don't follow CNAMEs in the stub anymore
2021-02-23 01:52:01 +01:00
Zbigniew Jędrzejewski-Szmek
8ebfd50aaf shared/condition: add ConditionControlGroupController=v1|v2
Before, we only allowed conditionalizing on controllers, not the hierarchy.
This commit extends this to allow a simple check for v1 (i.e. classic or hybrid),
and v2 (full unified).

An alternative approach would be to add a separate Condition for this, but I'm
not too keen on that, considering that v1 is already being deprecrecated
(c.f. 82f3063218).
2021-02-23 01:11:18 +01:00
Luca Boccassi
6c3f7ca036 MountImages: parse unit specifiers after permissive hyphen
The permissive bit it not something a specifier might synthetise
2021-02-23 01:11:05 +01:00
Zbigniew Jędrzejewski-Szmek
267294e08d Merge pull request #18745 from keszybz/stop-using-fstrings
Stop using fstrings
2021-02-23 01:10:38 +01:00
Zbigniew Jędrzejewski-Szmek
d6191ed529 test-dns-packet: fix leak of DnsResourceRecord object 2021-02-23 01:06:08 +01:00
Zbigniew Jędrzejewski-Szmek
a5e5e102ba Merge pull request #18704 from keszybz/fallback-hostame-override
Allow overriding of fallback hostname through envvar and os-release field
2021-02-23 00:41:27 +01:00
Lennart Poettering
5bd7ebb332 resolved: stick CNAME targets into main answer section in stub replies 2021-02-22 23:55:13 +01:00
Lennart Poettering
d1f8fbea9f resolved: add dns_resource_record_get_cname_target() helper
This determines the redirection target from a CNAME or DNAME RR given it
matches some given RR key.
2021-02-22 23:55:13 +01:00
Lennart Poettering
990e7e87ad resolved: remove duplicate comment
Practically the same comment is a few lines up covering both parts
anyway, let's remove one.
2021-02-22 23:55:13 +01:00
Lennart Poettering
c6ebf89b8f resolved: update comment in DNS stub code a bit
There's no "answer_auxiliary" object anymore, it's all one "answer"
object, and we have per-item flags that tell us which section things are
from, i.e. from the main answer section, or the additional or
authoritative ones.
2021-02-22 23:55:13 +01:00
Lennart Poettering
2f4d8e577c resolved: don't follow CNAMEs in the stub anymore
CNAME following was broken by 775ae35403
where we'd not properly collect RRs along the CNAME path. Good thing
though is that we don't have to anymore: since we nowadays propagate all
sections of the upstream replies into the cache and back to stub clients
all the information should already be available anyway, and there's no
need for us to collect it.

Fixes: #18690
2021-02-22 23:55:13 +01:00