Commit Graph

54862 Commits

Author SHA1 Message Date
Daan De Meyer
f848cb8d3e test: Remove unused includes 2025-05-22 09:41:18 +02:00
Daan De Meyer
6cc59a2de6 machine: Fix comment 2025-05-22 09:41:18 +02:00
Daan De Meyer
836e4e7ea8 core: Clean up includes
Split out of #37344.
2025-05-22 09:37:20 +02:00
Yu Watanabe
2fbbf6c4c7 unit-def: reindent comments
Prompted by dfdeb0b1cb.
2025-05-22 05:15:08 +09:00
Yu Watanabe
fe6a2c8a6c test-vpick: use more strict check
Follow-up for 4fc9940760.
2025-05-22 05:11:14 +09:00
Daan De Meyer
847e9fc366 logind: Add missing include
Follow up for 1aa202dd24
2025-05-21 21:23:06 +02:00
Yu Watanabe
276ddd8a91 logind: state serialization fixes (#37555)
Turns out our escaping was really broken when saving/restoring
session/seat/user state. Let's fix that.
2025-05-22 03:54:40 +09:00
Daan De Meyer
4bde87437a analyze: Clean up includes
Split out of #37344.
2025-05-22 03:06:46 +09:00
Lennart Poettering
c450027d14 env-file: rework write_env_file() to make use of O_TMPFILE 2025-05-22 02:50:48 +09:00
Lennart Poettering
dfc9fd0147 logind: rename EnableWallMessages= configuration knob to WallMessages= (#37553)
We generally frown on config options that are called
EnableXYZ=/DisableXYZ=, hence drop this here too. Note that the original
sin was that the pre-existing D-Bus property already used the prefix.
But given that D-Bus properties are substantially more low-level (i.e.
developer focused) than the config knobs, let's bite the bullet and
name the configuration option cleanly, even if the dbus property carries
the damn prefix.

The knob was added post v257, hence this is not a compat break.

Follow-up for: 130698dc20
2025-05-22 02:47:57 +09:00
Lennart Poettering
3c70cbae0f machined: call pidref_verify() in some cases this was missing
We need to protect us from recycled PIDs here like everywhere else: once
we read data from /proc/$PID/ we need to validate that $PID still points
to the original pidfd.
2025-05-22 02:38:38 +09:00
Daan De Meyer
acca52ab24 core: Make various ActivationDetails functions take a const argument 2025-05-22 02:17:39 +09:00
Daan De Meyer
baa3fadfb7 network: Clean up includes
Split out of #37344.
2025-05-22 02:15:43 +09:00
Daan De Meyer
f712008289 bootctl: Clean up includes
Split out of #37344.
2025-05-22 02:14:09 +09:00
Daan De Meyer
fee4eaa1b7 cryptenroll: Clean up includes
Split out of #37344.
2025-05-22 01:41:12 +09:00
Daan De Meyer
96fafb925c cryptsetup: Clean up includes
Split out of #37344.
2025-05-22 01:40:01 +09:00
Yu Watanabe
8d9e00ea55 core/namespace: unapplicable -> inapplicable
Follow-up for dfdeb0b1cb.
2025-05-22 01:21:09 +09:00
Daan De Meyer
eea9eb1f05 journal: Clean up includes
Split out of #37344.
2025-05-21 18:10:42 +02:00
Daan De Meyer
6c68f5d4ba journal-remote: Clean up includes
Split out of #37344.
2025-05-21 18:10:19 +02:00
Daan De Meyer
9412e9e97b import: Clean up headers
Split out of #37344.
2025-05-21 18:09:52 +02:00
Daan De Meyer
6ad1d1ede6 login: Clean up includes
Split out of #37344.
2025-05-21 18:09:28 +02:00
Daan De Meyer
64943cac5d machine: Clean up includes
Split out of #37344.
2025-05-21 18:08:50 +02:00
Lennart Poettering
f01d8658a3 logind: also save pidfdid as part of session state, even if we don't parse it 2025-05-21 17:33:40 +02:00
Lennart Poettering
1aa202dd24 logind: save/restore inhibitor process pidfdid 2025-05-21 17:33:40 +02:00
Lennart Poettering
b0555149de logind: always enclose list fields (that may contain spaces) in quotes 2025-05-21 17:33:40 +02:00
Lennart Poettering
232f4e12fe logind: fix escaping of various fields in state files
parse_env_file() applies a certain kind of unescaping, and we really
need to match that when writing out arbitrary strings.

(This gets a bit confusing in the inhibit case, since that already
applied one level of escaping on its own...)
2025-05-21 17:33:40 +02:00
Lennart Poettering
019c8ea26a logind: port logind state files to fopen_tmpfile_linkable()
This replaces use of fopen_temporary() with fopen_tmpfile_linkable() +
flink_tmpfile(). This both shortens the code and means we use O_TMPFILE
for installing these files, which is always good.

No change in behaviour otherwise.
2025-05-21 17:33:40 +02:00
Lennart Poettering
e27333b2cc env-file: add helper for printing a properly escaped env var file assignment 2025-05-21 17:33:40 +02:00
Daan De Meyer
d9eadbbca0 portable: Fix comment 2025-05-21 23:59:28 +09:00
Daan De Meyer
0bbd8e18ed systemctl: Clean up includes
Split out of #37344.
2025-05-21 23:59:03 +09:00
Daan De Meyer
dc59a1517d udev: Clean up includes
Split out of #37344.
2025-05-21 23:57:31 +09:00
Daan De Meyer
5cf0b3b5bc sysupdate: Clean up includes
Split out of #37344.
2025-05-21 23:53:40 +09:00
Daan De Meyer
54f3008a1e pretty-print: Add missing fileio.h include
LONG_LINE_MAX comes from fileio.h and is used in pretty-print.h so
pretty-print.h should include it.
2025-05-21 23:53:40 +09:00
Daan De Meyer
6ee31a53a9 nspawn: Clean up includes
Split out of #37344.
2025-05-21 23:52:20 +09:00
Daan De Meyer
284d76414e resolve: Clean up includes
Split out of #37344.
2025-05-21 23:50:31 +09:00
Daan De Meyer
572c1fe685 home: Clean up includes
Split out of #37344.
2025-05-21 23:46:47 +09:00
Daan De Meyer
1971631294 meson: Don't define targets for standalone binaries if option is not enabled
These are built from the same sources as the regular binaries, so we
end up with the same sources multiple times in the compilation database
but with different command line arguments, which trips up tooling that
uses the compilation database. Let's not define the standalone targets if
the option is not enabled to avoid this problem.
2025-05-21 14:05:58 +02:00
Daan De Meyer
cdd5fac068 tree-wide: Include <libaudit.h> via libaudit-util.h
Let's keep the ifdeffery for the include in one place.
2025-05-21 14:05:56 +02:00
Daan De Meyer
9f23910935 tests: Move implementation of DEFINE_HEX_PTR() into source file
Otherwise we have to add a hexdecoct.h include to tests.h which we
want to avoid.
2025-05-21 13:59:18 +02:00
Daan De Meyer
9f74f56f36 test-tables: Pass enum type to test_table() as well
clang-include-cleaner has a hard time figuring out unused includes
with all the macro string concatentation we're doing in test_table().
Let's help it out a little by also passing the enum type into test_table().

While technically not needed, this makes the tests a bit more self-descriptive
and not really much more verbose so it feels like a good chance regardless,
even if the primary purpose is to help clang-include-cleaner figure out
used and unused includes.
2025-05-21 13:24:42 +02:00
Daan De Meyer
44599b20bc stat-util: Use typeof_field() in one more place 2025-05-21 13:24:42 +02:00
Yu Watanabe
ef27ebab08 Clean up more includes (#37527)
Split out of #37344
2025-05-21 19:43:39 +09:00
Jelle van der Waa
2f0037d9fb bpf-socket-bind: rename 'u' to 'unit'
Follow argument comment naming.
2025-05-21 10:58:32 +02:00
Jelle van der Waa
26b5eea47f sd-login: rename sd_seat_get_active arguments
Follow the argument comment naming.
2025-05-21 10:50:48 +02:00
Jelle van der Waa
c670f828f1 sd-bus: rename cookie to ret_cookie
Follow the argument comment naming.
2025-05-21 10:50:25 +02:00
Jelle van der Waa
00299a80f7 sd-event: rename 's' -> 'ret' 2025-05-21 10:50:25 +02:00
Jelle van der Waa
bc2b127763 journal-sync: rename ss to stream
Follow the argument comment name.
2025-05-21 10:50:25 +02:00
Jelle van der Waa
dfd496b02e efivars: rename ret -> ret_data
Follow the used argument comment naming.
2025-05-21 10:50:25 +02:00
Jelle van der Waa
26208dd49f dbus-manager: correct argument comment 2025-05-21 10:50:25 +02:00
Jelle van der Waa
d0ae0e4f07 pretty-print: correct argument comment 2025-05-21 10:50:25 +02:00