mirror of
https://github.com/morgan9e/systemd
synced 2026-04-14 16:37:19 +09:00
0bb0316f5e
Previously, when compiled in developer mode, a call into libsystemd with invalid parameters would result in an abort. This means that it's effectively impossible to install such libsystemd in a normal system, since various third-party programs may now abort. A shared library should generally never abort or exit the calling program. In python-systemd, the test suite calls into libsystemd, to check if the proper return values are received and propagated through the Python wrappers. Obviously with libsystemd compiled from git, the test suite now fails in a nasty way. So rework the code to set assert_return_is_critical similarly to how we handle mempool enablement: the function that returns true is declared as a week symbol, and we "opt in" by linking a file that provides the function in libsystemd-shared. Effectively, libsystemd and libudev always have assert_return_is_critical==false, and our binaries and modules enable it conditionally.
57 lines
1.8 KiB
C
57 lines
1.8 KiB
C
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
|
|
#include "assert-util.h"
|
|
#include "errno-util.h"
|
|
#include "log.h"
|
|
|
|
/* Akin to glibc's __abort_msg; which is private and we hence cannot
|
|
* use here. */
|
|
static char *log_abort_msg = NULL;
|
|
|
|
static void log_assert(
|
|
int level,
|
|
const char *text,
|
|
const char *file,
|
|
int line,
|
|
const char *func,
|
|
const char *format) {
|
|
|
|
static char buffer[LINE_MAX];
|
|
|
|
if (_likely_(LOG_PRI(level) > log_get_max_level()))
|
|
return;
|
|
|
|
DISABLE_WARNING_FORMAT_NONLITERAL;
|
|
(void) snprintf(buffer, sizeof buffer, format, text, file, line, func);
|
|
REENABLE_WARNING;
|
|
|
|
log_abort_msg = buffer;
|
|
|
|
log_dispatch_internal(level, 0, file, line, func, NULL, NULL, NULL, NULL, buffer);
|
|
}
|
|
|
|
_noreturn_ void log_assert_failed(const char *text, const char *file, int line, const char *func) {
|
|
log_assert(LOG_CRIT, text, file, line, func,
|
|
"Assertion '%s' failed at %s:%u, function %s(). Aborting.");
|
|
abort();
|
|
}
|
|
|
|
_noreturn_ void log_assert_failed_unreachable(const char *file, int line, const char *func) {
|
|
log_assert(LOG_CRIT, "Code should not be reached", file, line, func,
|
|
"%s at %s:%u, function %s(). Aborting. 💥");
|
|
abort();
|
|
}
|
|
|
|
void log_assert_failed_return(const char *text, const char *file, int line, const char *func) {
|
|
/* log_get_assert_return_is_critical is a weak symbol. It may be NULL. */
|
|
if (log_get_assert_return_is_critical && log_get_assert_return_is_critical())
|
|
log_assert_failed(text, file, line, func);
|
|
|
|
PROTECT_ERRNO;
|
|
log_assert(LOG_DEBUG, text, file, line, func,
|
|
"Assertion '%s' failed at %s:%u, function %s(), ignoring.");
|
|
}
|