Lennart Poettering da6053d0a7 tree-wide: be more careful with the type of array sizes ...

Previously we were a bit sloppy with the index and size types of arrays,
we'd regularly use unsigned. While I don't think this ever resulted in
real issues I think we should be more careful there and follow a
stricter regime: unless there's a strong reason not to use size_t for
array sizes and indexes, size_t it should be. Any allocations we do
ultimately will use size_t anyway, and converting forth and back between
unsigned and size_t will always be a source of problems.

Note that on 32bit machines "unsigned" and "size_t" are equivalent, and
on 64bit machines our arrays shouldn't grow that large anyway, and if
they do we have a problem, however that kind of overly large allocation
we have protections for usually, but for overflows we do not have that
so much, hence let's add it.

So yeah, it's a story of the current code being already "good enough",
but I think some extra type hygiene is better.

This patch tries to be comprehensive, but it probably isn't and I missed
a few cases. But I guess we can cover that later as we notice it. Among
smaller fixes, this changes:

1. strv_length()' return type becomes size_t

2. the unit file changes array size becomes size_t

3. DNS answer and query array sizes become size_t

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=76745

2018-04-27 14:29:06 +02:00

..

af-list.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

af-list.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

af-to-name.awk

…

alloc-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

alloc-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

architecture.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

architecture.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

arphrd-list.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

arphrd-list.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

arphrd-to-name.awk

…

async.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

async.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

audit-util.c

basic/audit-util: always log the reason when disabling audit logs

2018-04-24 14:10:27 +02:00

audit-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

barrier.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

barrier.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

bitmap.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

bitmap.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

blkid-util.h

tree-wide: drop redundant _cleanup_ macros (#8810)

2018-04-25 12:31:45 +02:00

blockdev-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

blockdev-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

bpf-program.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

bpf-program.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

btrfs-ctree.h

btrfs: Include missing.h in btrfs-ctree.h

2017-12-18 11:19:32 +01:00

btrfs-util.c

nspawn: fix copy/reflink fallback when directory already exists (#8781)

2018-04-24 11:38:08 +02:00

btrfs-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

build.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

bus-label.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

bus-label.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

calendarspec.c

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

calendarspec.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

cap-list.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

cap-list.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

cap-to-name.awk

…

capability-util.c

tree-wide: avoid assignment of r just to use in a comparison

2018-04-24 14:10:27 +02:00

capability-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

cgroup-util.c

cgroup-util: fix enabling of controllers (#8816)

2018-04-26 12:37:35 +02:00

cgroup-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

chattr-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

chattr-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

clock-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

clock-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

conf-files.c

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

conf-files.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

copy.c

basic/copy: fix awkward sentence

2018-04-17 16:58:02 +02:00

copy.h

copy: rearrange flags field definition

2018-04-13 11:32:46 +02:00

cpu-set-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

cpu-set-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

crypt-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

crypt-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

def.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

device-nodes.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

device-nodes.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

dirent-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

dirent-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

env-util.c

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

env-util.h

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

errno-list.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

errno-list.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

errno-to-name.awk

…

escape.c

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

escape.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

ether-addr-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

ether-addr-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

exec-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

exec-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

exit-status.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

exit-status.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

extract-word.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

extract-word.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

fd-util.c

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

fd-util.h

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

fileio-label.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

fileio-label.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

fileio.c

fileio.c: fix incorrect mtime

2018-04-24 11:18:43 -05:00

fileio.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

format-table.c

tree-wide: drop spurious newlines (#8764)

2018-04-19 12:13:23 +02:00

format-table.h

basic: add minimalistic table formatter

2018-04-18 12:51:15 +02:00

format-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

fs-util.c

fs-util: introduce fchmod_opath()

2018-04-24 11:57:48 +02:00

fs-util.h

fs-util: introduce fchmod_opath()

2018-04-24 11:57:48 +02:00

gcrypt-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

gcrypt-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

generate-af-list.sh

generate-af-list.sh: slightly generalize pattern, fix w/musl (#8629)

2018-03-31 12:55:45 +02:00

generate-arphrd-list.sh

separate flags from shebang

2017-12-25 19:48:49 +01:00

generate-cap-list.sh

separate flags from shebang

2017-12-25 19:48:49 +01:00

generate-errno-list.sh

separate flags from shebang

2017-12-25 19:48:49 +01:00

generate-gperfs.py

…

generate-socket-protocol-list.sh

separate flags from shebang

2017-12-25 19:48:49 +01:00

glob-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

glob-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

gunicode.c

log: minimize includes in log.h

2018-01-11 14:44:31 +01:00

gunicode.h

…

hash-funcs.c

tree-wide: drop spurious newlines (#8764)

2018-04-19 12:13:23 +02:00

hash-funcs.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

hashmap.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

hashmap.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

hexdecoct.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

hexdecoct.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

hostname-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

hostname-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

in-addr-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

in-addr-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

io-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

io-util.h

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

ioprio.h

Restore naming of IOPRIO_PRIO defines from linux/ioprio.h

2018-03-21 00:46:22 +01:00

journal-importer.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

journal-importer.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

khash.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

khash.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

label.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

label.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

list.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

locale-util.c

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

locale-util.h

locale: add ellipsis as special glyph

2018-04-18 12:35:45 +02:00

lockfile-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

lockfile-util.h

tree-wide: drop redundant _cleanup_ macros (#8810)

2018-04-25 12:31:45 +02:00

log.c

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

log.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

login-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

login-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

macro.h

macro: don't rely on C's downgrade-to-bool feature for numeric comparisons

2018-04-12 11:02:47 +02:00

memfd-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

memfd-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

mempool.c

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

mempool.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

meson.build

basic: add minimalistic table formatter

2018-04-18 12:51:15 +02:00

missing_syscall.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

missing.h

missing: add IPV4_MIN_MTU

2018-04-26 13:51:44 +02:00

mkdir-label.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

mkdir.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

mkdir.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

module-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

mount-util.c

tree-wide: drop spurious newlines (#8764)

2018-04-19 12:13:23 +02:00

mount-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

MurmurHash2.c

…

MurmurHash2.h

…

nss-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

ordered-set.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

ordered-set.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

pager.c

pager: move pager.[ch] src/shared/ → src/basic/

2018-04-18 12:35:45 +02:00

pager.h

pager: move pager.[ch] src/shared/ → src/basic/

2018-04-18 12:35:45 +02:00

parse-util.c

parse-util: add explicit parsers for MTU values

2018-04-26 13:51:44 +02:00

parse-util.h

parse-util: add explicit parsers for MTU values

2018-04-26 13:51:44 +02:00

path-util.c

util-lib: introduce new empty_or_root() helper (#8746)

2018-04-18 14:20:49 +02:00

path-util.h

nspawn: when running nspawn, set a $PATH including both bin + sbin by default (#8756)

2018-04-20 11:36:25 +02:00

prioq.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

prioq.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

proc-cmdline.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

proc-cmdline.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

process-util.c

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

process-util.h

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

procfs-util.c

procfs-util: drop unnecessary zero initializations (#8321)

2018-03-01 11:27:06 +01:00

procfs-util.h

procfs-util: add APIs to get consumed CPU time and used memory from /proc

2018-02-09 17:32:26 +01:00

random-util.c

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

random-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

ratelimit.c

tree-wide: drop spurious newlines (#8764)

2018-04-19 12:13:23 +02:00

ratelimit.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

raw-clone.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

raw-reboot.h

basic: add a common syscall wrapper around reboot()

2018-02-22 10:42:06 +01:00

reboot-util.c

reboot-util: unify reboot with parameter in a single implementation

2018-02-22 10:46:26 +01:00

reboot-util.h

reboot-util: unify reboot with parameter in a single implementation

2018-02-22 10:46:26 +01:00

refcnt.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

replace-var.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

replace-var.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

rlimit-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

rlimit-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

rm-rf.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

rm-rf.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

securebits-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

securebits-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

securebits.h

…

selinux-util.c

tree-wide: drop spurious newlines (#8764)

2018-04-19 12:13:23 +02:00

selinux-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

set.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

set.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

sigbus.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

sigbus.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

signal-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

signal-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

siphash24.c

…

siphash24.h

…

smack-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

smack-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

socket-label.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

socket-protocol-list.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

socket-protocol-list.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

socket-protocol-to-name.awk

basic: introduce socket_protocol_{from,to}_name()

2017-12-23 19:32:04 +09:00

socket-util.c

tree-wide: drop spurious newlines (#8764)

2018-04-19 12:13:23 +02:00

socket-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

sparse-endian.h

…

special.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

stat-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

stat-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

stdio-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

strbuf.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

strbuf.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

string-table.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

string-table.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

string-util.c

string-util: use fflush_and_check() where appropriate

2018-04-24 15:58:31 +02:00

string-util.h

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

strv.c

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

strv.h

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

strxcpyx.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

strxcpyx.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

syslog-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

syslog-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

terminal-util.c

Fix typo

2018-04-20 11:09:44 +02:00

terminal-util.h

terminal: add internal API to format URLs for display in capable terminals

2018-04-19 18:04:26 +02:00

time-util.c

tree-wide: be more careful with the type of array sizes

2018-04-27 14:29:06 +02:00

time-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

umask-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

unaligned.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

unit-def.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

unit-def.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

unit-name.c

tests: add some tests for unit_name_is_valid() and related functions

2018-04-24 09:59:03 +02:00

unit-name.h

unit-name: add new unit_name_build_from_type() helper

2018-04-13 11:34:48 +02:00

user-util.c

user-util: trivial coding style fixes

2018-04-19 11:41:28 +02:00

user-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

utf8.c

utf8: add helper call for counting display width of strings

2018-04-18 12:35:45 +02:00

utf8.h

utf8: add helper call for counting display width of strings

2018-04-18 12:35:45 +02:00

util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

util.h

util: add qsort_r_safe(), similar to qsort_safe()

2018-04-18 12:35:45 +02:00

verbs.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

verbs.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

virt.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

virt.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

web-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

web-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

xattr-util.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

xattr-util.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

xml.c

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00

xml.h

tree-wide: drop license boilerplate

2018-04-06 18:58:55 +02:00