From 95dfdaa5cde3ca6f7e5b84b9e4916ff1112d4ffd Mon Sep 17 00:00:00 2001 From: heliguy4599 Date: Thu, 10 Oct 2024 23:53:41 -0400 Subject: [PATCH] Fix calling gio trash with no paths, when batch uninstalling packages --- src/install_page/pending_page.py | 7 ++++--- src/packages_page/packages_page.py | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/install_page/pending_page.py b/src/install_page/pending_page.py index 2b53039..981aba4 100644 --- a/src/install_page/pending_page.py +++ b/src/install_page/pending_page.py @@ -95,9 +95,10 @@ class PendingPage(Adw.NavigationPage): package_requests = [] for key, group in self.groups.items(): item = { - 'remote': group.remote.name, - 'installation': group.installation, - 'package_names': [], + "remote": group.remote.name, + "installation": group.installation, + "package_names": [], + "extra_flags": [], } for row in group.rows: item['package_names'].append(row.package.app_id) diff --git a/src/packages_page/packages_page.py b/src/packages_page/packages_page.py index 74559fc..839075d 100644 --- a/src/packages_page/packages_page.py +++ b/src/packages_page/packages_page.py @@ -252,7 +252,7 @@ class PackagesPage(Adw.BreakpointBin): try: subprocess.run(cmd, check=True, capture_output=True) - if should_trash: + if should_trash and len(to_trash) > 0: subprocess.run(['gio', 'trash'] + to_trash, check=True, capture_output=True) except subprocess.CalledProcessError as cpe: error[0] = cpe