morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-14 00:14:11 +09:00
Code Issues Packages Projects Releases Wiki Activity

[warnings] initialize all va_list

Browse Source
This commit is contained in:
Armin Novak
2026-02-25 05:50:15 +01:00
parent b7892a7cc1
commit 3fcc287b16
28 changed files with 59 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
channels/rdpecam/common/rdpecam-utils.h
View File

@@ -32,7 +32,7 @@ static inline void rdpecam_PrintWarning(wLog* log, const char* file, const char*
WINPR_FORMAT_ARG const char* fmt, ...)
{
const DWORD level = WLOG_WARN;
va_list ap;
va_list ap = { 0 };
va_start(ap, fmt);
if (WLog_IsLevelActive(log, level))

16
channels/rdpei/client/rdpei_main.c
View File

@@ -1202,7 +1202,7 @@ static UINT rdpei_touch_raw_event(RdpeiClientContext* context, INT32 externalId,
INT32* contactId, UINT32 flags, UINT32 fieldFlags, ...)
{
UINT rc = 0;
va_list ap;
va_list ap = { 0 };
va_start(ap, fieldFlags);
rc = rdpei_touch_process(context, externalId, flags, x, y, contactId, fieldFlags, ap);
va_end(ap);
@@ -1345,7 +1345,7 @@ static UINT rdpei_pen_begin(RdpeiClientContext* context, INT32 externalId, UINT3
INT32 x, INT32 y, ...)
{
UINT error = 0;
va_list ap;
va_list ap = { 0 };
va_start(ap, y);
error = rdpei_pen_process(context, externalId,
@@ -1366,7 +1366,7 @@ static UINT rdpei_pen_update(RdpeiClientContext* context, INT32 externalId, UINT
INT32 x, INT32 y, ...)
{
UINT error = 0;
va_list ap;
va_list ap = { 0 };
va_start(ap, y);
error = rdpei_pen_process(context, externalId,
@@ -1386,7 +1386,7 @@ static UINT rdpei_pen_end(RdpeiClientContext* context, INT32 externalId, UINT32
INT32 y, ...)
{
UINT error = 0;
va_list ap;
va_list ap = { 0 };
va_start(ap, y);
error = rdpei_pen_process(context, externalId,
RDPINPUT_CONTACT_FLAG_UP | RDPINPUT_CONTACT_FLAG_INRANGE, fieldFlags,
@@ -1404,7 +1404,7 @@ static UINT rdpei_pen_hover_begin(RdpeiClientContext* context, INT32 externalId,
INT32 x, INT32 y, ...)
{
UINT error = 0;
va_list ap;
va_list ap = { 0 };
va_start(ap, y);
error = rdpei_pen_process(context, externalId,
@@ -1424,7 +1424,7 @@ static UINT rdpei_pen_hover_update(RdpeiClientContext* context, INT32 externalId
INT32 x, INT32 y, ...)
{
UINT error = 0;
va_list ap;
va_list ap = { 0 };
va_start(ap, y);
error = rdpei_pen_process(context, externalId,
@@ -1444,7 +1444,7 @@ static UINT rdpei_pen_hover_cancel(RdpeiClientContext* context, INT32 externalId
INT32 x, INT32 y, ...)
{
UINT error = 0;
va_list ap;
va_list ap = { 0 };
va_start(ap, y);
error = rdpei_pen_process(context, externalId,
@@ -1459,7 +1459,7 @@ static UINT rdpei_pen_raw_event(RdpeiClientContext* context, INT32 externalId, U
UINT32 fieldFlags, INT32 x, INT32 y, ...)
{
UINT error = 0;
va_list ap;
va_list ap = { 0 };
va_start(ap, y);
error = rdpei_pen_process(context, externalId, contactFlags, fieldFlags, x, y, ap);

6
client/Android/Studio/freeRDPCore/src/main/cpp/android_jni_callback.c
View File

@@ -201,7 +201,7 @@ finish:
/* callback to freerdp class */
void freerdp_callback(const char* callback, const char* signature, ...)
{
va_list vl;
va_list vl = { 0 };
va_start(vl, signature);
java_callback_void(jLibFreeRDPObject, callback, signature, vl);
va_end(vl);
@@ -209,7 +209,7 @@ void freerdp_callback(const char* callback, const char* signature, ...)
jboolean freerdp_callback_bool_result(const char* callback, const char* signature, ...)
{
va_list vl;
va_list vl = { 0 };
va_start(vl, signature);
jboolean res = java_callback_bool(jLibFreeRDPObject, callback, signature, vl);
va_end(vl);
@@ -218,7 +218,7 @@ jboolean freerdp_callback_bool_result(const char* callback, const char* signatur
jint freerdp_callback_int_result(const char* callback, const char* signature, ...)
{
va_list vl;
va_list vl = { 0 };
va_start(vl, signature);
jint res = java_callback_int(jLibFreeRDPObject, callback, signature, vl);
va_end(vl);

2
client/SDL/SDL2/dialogs/sdl_connection_dialog.cpp
View File

@@ -455,7 +455,7 @@ std::string SDLConnectionDialog::print(const char* fmt, va_list ap)
if (size > 0)
res.resize(WINPR_ASSERTING_INT_CAST(size_t, size));
va_list copy;
va_list copy = {};
va_copy(copy, ap);
WINPR_PRAGMA_DIAG_PUSH
WINPR_PRAGMA_DIAG_IGNORED_FORMAT_NONLITERAL

2
client/SDL/SDL3/dialogs/sdl_connection_dialog.cpp
View File

@@ -439,7 +439,7 @@ std::string SDLConnectionDialog::print(const char* fmt, va_list ap)
if (size > 0)
res.resize(WINPR_ASSERTING_INT_CAST(uint32_t, size));
va_list copy;
va_list copy = {};
va_copy(copy, ap);
WINPR_PRAGMA_DIAG_PUSH
WINPR_PRAGMA_DIAG_IGNORED_FORMAT_NONLITERAL

12
client/SDL/SDL3/dialogs/sdl_connection_dialog_wrapper.cpp
View File

@@ -75,7 +75,7 @@ bool SdlConnectionDialogWrapper::handleEvent(const SDL_Event& event)
WINPR_ATTR_FORMAT_ARG(1, 0)
static std::string format(WINPR_FORMAT_ARG const char* fmt, va_list ap)
{
va_list ap1;
va_list ap1 = {};
va_copy(ap1, ap);
const int size = vsnprintf(nullptr, 0, fmt, ap1);
va_end(ap1);
@@ -86,7 +86,7 @@ static std::string format(WINPR_FORMAT_ARG const char* fmt, va_list ap)
std::string msg;
msg.resize(static_cast<size_t>(size) + 1);
va_list ap2;
va_list ap2 = {};
va_copy(ap2, ap);
std::ignore = vsnprintf(msg.data(), msg.size(), fmt, ap2);
va_end(ap2);
@@ -95,7 +95,7 @@ static std::string format(WINPR_FORMAT_ARG const char* fmt, va_list ap)
void SdlConnectionDialogWrapper::setTitle(const char* fmt, ...)
{
va_list ap;
va_list ap = {};
va_start(ap, fmt);
setTitle(format(fmt, ap));
va_end(ap);
@@ -108,7 +108,7 @@ void SdlConnectionDialogWrapper::setTitle(const std::string& title)
void SdlConnectionDialogWrapper::showInfo(const char* fmt, ...)
{
va_list ap;
va_list ap = {};
va_start(ap, fmt);
showInfo(format(fmt, ap));
va_end(ap);
@@ -121,7 +121,7 @@ void SdlConnectionDialogWrapper::showInfo(const std::string& info)
void SdlConnectionDialogWrapper::showWarn(const char* fmt, ...)
{
va_list ap;
va_list ap = {};
va_start(ap, fmt);
showWarn(format(fmt, ap));
va_end(ap);
@@ -134,7 +134,7 @@ void SdlConnectionDialogWrapper::showWarn(const std::string& info)
void SdlConnectionDialogWrapper::showError(const char* fmt, ...)
{
va_list ap;
va_list ap = {};
va_start(ap, fmt);
showError(format(fmt, ap));
va_end(ap);

4
client/Windows/wf_client.c
View File

@@ -663,8 +663,8 @@ static WCHAR* wf_format_text(const WCHAR* fmt, ...)
do
{
WCHAR* tmp;
va_list ap;
WCHAR* tmp = NULL;
va_list ap = { 0 };
va_start(ap, fmt);
rc = _vsnwprintf(buffer, size, fmt, ap);
va_end(ap);

4
client/X11/xf_utils.c
View File

@@ -90,7 +90,7 @@ static int write_result_log_expect_success(wLog* log, DWORD level, const char* f
{
if (rc != Success)
{
va_list ap;
va_list ap = { 0 };
(void)write_result_log_va(log, level, fname, fkt, line, display, name, rc, 0, ap);
}
return rc;
@@ -101,7 +101,7 @@ static int write_result_log_expect_one(wLog* log, DWORD level, const char* fname
{
if (rc != 1)
{
va_list ap;
va_list ap = { 0 };
(void)write_result_log_va(log, level, fname, fkt, line, display, name, rc, 0, ap);
}
return rc;

2
client/X11/xf_window.c
View File

@@ -232,7 +232,7 @@ static void xf_SetWindowTitleText(xfContext* xfc, Window window, const char* nam
void xf_SendClientEvent(xfContext* xfc, Window window, Atom atom, unsigned int numArgs, ...)
{
XEvent xevent = { 0 };
va_list argp;
va_list argp = { 0 };
va_start(argp, numArgs);
xevent.xclient.type = ClientMessage;

6
client/common/client.c
View File

@@ -2203,7 +2203,7 @@ BOOL freerdp_client_handle_pen(rdpClientContext* cctx, UINT32 flags, INT32 devic
#if defined(CHANNEL_RDPEI_CLIENT)
if ((flags & FREERDP_PEN_REGISTER) != 0)
{
va_list args;
va_list args = { 0 };
va_start(args, deviceid);
double pressure = va_arg(args, double);
@@ -2231,7 +2231,7 @@ BOOL freerdp_client_handle_pen(rdpClientContext* cctx, UINT32 flags, INT32 devic
UINT16 rotation = 0;
INT16 tiltX = 0;
INT16 tiltY = 0;
va_list args;
va_list args = { 0 };
va_start(args, deviceid);
x = va_arg(args, INT32);
@@ -2572,7 +2572,7 @@ char* freerdp_client_get_aad_url(rdpClientContext* cctx, freerdp_client_aad_type
WINPR_ASSERT(cctx);
char* str = NULL;
va_list ap;
va_list ap = { 0 };
va_start(ap, type);
switch (type)
{

2
client/common/client_cliprdr_file.c
View File

@@ -228,7 +228,7 @@ static CliprdrFuseFile* fuse_file_new(WINPR_FORMAT_ARG const char* fmt, ...)
WINPR_ASSERT(fmt);
{
va_list ap;
va_list ap = { 0 };
va_start(ap, fmt);
const int rc =
winpr_vasprintf(&file->filename_with_root, &file->filename_with_root_len, fmt, ap);

2
client/common/sso_mib_tokens.c
View File

@@ -153,7 +153,7 @@ static BOOL sso_mib_get_access_token(rdpContext* context, AccessTokenType tokenT
const char* scope = NULL;
const char* req_cnf = NULL;
va_list ap;
va_list ap = { 0 };
va_start(ap, count);
if (tokenType == ACCESS_TOKEN_TYPE_AAD)

2
client/iOS/Models/RDPSession.m
View File

@@ -46,7 +46,7 @@ NSString *TSXSessionDidFailToConnectNotification = @"TSXSessionDidFailToConnect"
static BOOL addArgument(int *argc, char ***argv, const char *fmt, ...)
{
va_list ap;
va_list ap = { 0 };
char *arg = NULL;
char **tmp = realloc(*argv, (*argc + 1) * sizeof(char *));

2
libfreerdp/core/credssp_auth.c
View File

@@ -108,7 +108,7 @@ static BOOL log_status_(SECURITY_STATUS status, DWORD level, const char* file, c
if (WLog_IsLevelActive(log, level))
{
char fwhat[128] = { 0 };
va_list ap;
va_list ap = { 0 };
va_start(ap, what);
(void)vsnprintf(fwhat, sizeof(fwhat) - 1, what, ap);
va_end(ap);

2
libfreerdp/core/freerdp.c
View File

@@ -807,7 +807,7 @@ static BOOL freerdp_common_context(rdpContext* context, AccessTokenType tokenTyp
if (!context->instance || !context->instance->GetAccessToken)
return TRUE;
va_list ap;
va_list ap = { 0 };
va_start(ap, count);
switch (tokenType)
{

6
libfreerdp/core/gateway/http.c
View File

@@ -271,7 +271,7 @@ WINPR_ATTR_FORMAT_ARG(2, 0)
static BOOL list_append(HttpContext* context, WINPR_FORMAT_ARG const char* str, va_list ap)
{
BOOL rc = FALSE;
va_list vat;
va_list vat = { 0 };
char* Pragma = NULL;
size_t PragmaSize = 0;
@@ -1703,7 +1703,7 @@ FREERDP_LOCAL BOOL http_context_set_header(HttpContext* context, const char* key
...)
{
WINPR_ASSERT(context);
va_list ap;
va_list ap = { 0 };
va_start(ap, value);
const BOOL rc = http_context_set_header_va(context, key, value, ap);
va_end(ap);
@@ -1715,7 +1715,7 @@ BOOL http_request_set_header(HttpRequest* request, const char* key, const char*
WINPR_ASSERT(request);
char* v = NULL;
size_t vlen = 0;
va_list ap;
va_list ap = { 0 };
va_start(ap, value);
winpr_vasprintf(&v, &vlen, value, ap);
va_end(ap);

4
libfreerdp/core/test/TestSettings.c
View File

@@ -15,7 +15,7 @@
static void log_start_(const char* fkt, ...)
{
(void)fprintf(stderr, "TestSettings [");
va_list ap;
va_list ap = { 0 };
va_start(ap, fkt);
(void)vfprintf(stderr, fkt, ap);
va_end(ap);
@@ -27,7 +27,7 @@ static void log_start_(const char* fkt, ...)
static BOOL log_result_(BOOL value, const char* fkt, ...)
{
(void)fprintf(stderr, "TestSettings [");
va_list ap;
va_list ap = { 0 };
va_start(ap, fkt);
(void)vfprintf(stderr, fkt, ap);
va_end(ap);

2
libfreerdp/crypto/privatekey.c
View File

@@ -408,7 +408,7 @@ BOOL freerdp_key_generate(rdpPrivateKey* key, const char* type, size_t count, ..
WLog_ERR(TAG, "Argument type=%s requires count=1, got %" PRIuz ", aborting", type, count);
return FALSE;
}
va_list ap;
va_list ap = { 0 };
va_start(ap, count);
const int key_length = va_arg(ap, int);
va_end(ap);

2
server/proxy/channels/pf_channel_drdynvc.c
View File

@@ -136,7 +136,7 @@ static void dyn_log_(wLog* log, DWORD level, const pServerDynamicChannelContext*
getDirection(isBackData), channelName, drdynvc_get_packet_type(cmd),
channelId);
va_list ap;
va_list ap = { 0 };
va_start(ap, fmt);
(void)winpr_vasprintf(&msg, &msglen, fmt, ap);
va_end(ap);

2
uwac/libuwac/uwac-display.c
View File

@@ -54,7 +54,7 @@ static const char* event_names[] = {
static bool uwac_default_error_handler(UwacDisplay* display, UwacReturnCode code, const char* msg,
...)
{
va_list args;
va_list args = { 0 };
va_start(args, msg);
(void)vfprintf(stderr, "%s", args);
va_end(args);

2
winpr/include/winpr/platform.h
View File

@@ -594,7 +594,7 @@ WINPR_PRAGMA_DIAG_POP
#if defined(__GNUC__) || defined(__clang__)
#define WINPR_ATTR_FORMAT_ARG(pos, args) __attribute__((__format__(__printf__, pos, args)))
#define WINPR_FORMAT_ARG /**/
#else
#elif defined(_MSC_VER)
#define WINPR_ATTR_FORMAT_ARG(pos, args)
#define WINPR_FORMAT_ARG _Printf_format_string_
#endif

6
winpr/include/winpr/wlog.h
View File

@@ -273,7 +273,11 @@ extern "C"
if (WLog_IsLevelActive(log_cached_ptr, log_level))
{
va_list ap;
#if defined(__cplusplus)
va_list ap = {};
#else
va_list ap = { 0 };
#endif
va_start(ap, fmt);
WLog_PrintTextMessageVA(log_cached_ptr, log_level, line, file, fkt, fmt, ap);
va_end(ap);

2
winpr/libwinpr/path/path.c
View File

@@ -1258,7 +1258,7 @@ char* winpr_GetConfigFilePath(BOOL system, const char* filename)
char* winpr_GetConfigFilePathV(BOOL system, const char* filename, ...)
{
va_list ap;
va_list ap = { 0 };
va_start(ap, filename);
char* str = winpr_GetConfigFilePathVA(system, filename, ap);
va_end(ap);

6
winpr/libwinpr/path/shell.c
View File

@@ -401,7 +401,7 @@ char* GetKnownSubPath(eKnownPathTypes id, const char* path)
char* GetKnownSubPathV(eKnownPathTypes id, const char* path, ...)
{
va_list ap;
va_list ap = { 0 };
va_start(ap, path);
char* str = GetKnownSubPathVA(id, path, ap);
@@ -455,7 +455,7 @@ char* GetEnvironmentSubPath(char* name, const char* path)
char* GetEnvironmentSubPathV(char* name, const char* path, ...)
{
va_list ap;
va_list ap = { 0 };
va_start(ap, path);
char* str = GetEnvironmentSubPathVA(name, path, ap);
va_end(ap);
@@ -483,7 +483,7 @@ char* GetCombinedPath(const char* basePath, const char* subPathFmt)
char* GetCombinedPathV(const char* basePath, const char* subPathFmt, ...)
{
va_list ap;
va_list ap = { 0 };
va_start(ap, subPathFmt);
char* str = GetCombinedPathVA(basePath, subPathFmt, ap);

2
winpr/libwinpr/utils/collections/ArrayList.c
View File

@@ -546,7 +546,7 @@ BOOL ArrayList_ForEach(wArrayList* arrayList, ArrayList_ForEachFkt fkt, ...)
BOOL ArrayList_ForEachAP(wArrayList* arrayList, ArrayList_ForEachFkt fkt, va_list ap)
{
BOOL rc = FALSE;
va_list cap;
va_list cap = { 0 };
WINPR_ASSERT(arrayList);
WINPR_ASSERT(fkt);

8
winpr/libwinpr/utils/stream.c
View File

@@ -312,7 +312,7 @@ BOOL Stream_CheckAndLogRequiredCapacityEx(const char* tag, DWORD level, wStream*
if (actual < nmemb)
{
va_list args;
va_list args = { 0 };
va_start(args, fmt);
Stream_CheckAndLogRequiredCapacityExVa(tag, level, s, nmemb, size, fmt, args);
@@ -370,7 +370,7 @@ BOOL Stream_CheckAndLogRequiredCapacityWLogEx(wLog* log, DWORD level, wStream* s
if (actual < nmemb)
{
va_list args;
va_list args = { 0 };
va_start(args, fmt);
Stream_CheckAndLogRequiredCapacityWLogExVa(log, level, s, nmemb, size, fmt, args);
@@ -390,7 +390,7 @@ BOOL Stream_CheckAndLogRequiredLengthEx(const char* tag, DWORD level, wStream* s
if (actual < nmemb)
{
va_list args;
va_list args = { 0 };
va_start(args, fmt);
Stream_CheckAndLogRequiredLengthExVa(tag, level, s, nmemb, size, fmt, args);
@@ -421,7 +421,7 @@ BOOL Stream_CheckAndLogRequiredLengthWLogEx(wLog* log, DWORD level, wStream* s,
if (actual < nmemb)
{
va_list args;
va_list args = { 0 };
va_start(args, fmt);
Stream_CheckAndLogRequiredLengthWLogExVa(log, level, s, nmemb, size, fmt, args);

2
winpr/libwinpr/utils/wlog/Layout.c
View File

@@ -91,7 +91,7 @@ WINPR_ATTR_FORMAT_ARG(3, 4)
static void WLog_PrintMessagePrefix(char* prefix, size_t prefixlen,
WINPR_FORMAT_ARG const char* format, ...)
{
va_list args;
va_list args = { 0 };
va_start(args, format);
WLog_PrintMessagePrefixVA(prefix, prefixlen, format, args);
va_end(args);

4
winpr/libwinpr/utils/wlog/wlog.c
View File

@@ -429,7 +429,7 @@ BOOL WLog_PrintMessage(wLog* log, DWORD type, DWORD level, size_t line, const ch
const char* function, ...)
{
BOOL status = 0;
va_list args;
va_list args = { 0 };
va_start(args, function);
status = WLog_PrintMessageVA(log, type, level, line, file, function, args);
va_end(args);
@@ -440,7 +440,7 @@ BOOL WLog_PrintTextMessage(wLog* log, DWORD level, size_t line, const char* file
const char* function, const char* fmt, ...)
{
BOOL status = 0;
va_list args;
va_list args = { 0 };
va_start(args, fmt);
status = WLog_PrintTextMessageVA(log, level, line, file, function, fmt, args);
va_end(args);