morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-14 00:14:11 +09:00
Code Issues Packages Projects Releases Wiki Activity

[warnings] initialize all va_list

Browse Source
This commit is contained in:
Armin Novak
2026-02-25 05:50:15 +01:00
parent b7892a7cc1
commit 3fcc287b16
28 changed files with 59 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
client/Android/Studio/freeRDPCore/src/main/cpp/android_jni_callback.c
View File

@@ -201,7 +201,7 @@ finish:
/* callback to freerdp class */
void freerdp_callback(const char* callback, const char* signature, ...)
{
va_list vl;
va_list vl = { 0 };
va_start(vl, signature);
java_callback_void(jLibFreeRDPObject, callback, signature, vl);
va_end(vl);
@@ -209,7 +209,7 @@ void freerdp_callback(const char* callback, const char* signature, ...)
jboolean freerdp_callback_bool_result(const char* callback, const char* signature, ...)
{
va_list vl;
va_list vl = { 0 };
va_start(vl, signature);
jboolean res = java_callback_bool(jLibFreeRDPObject, callback, signature, vl);
va_end(vl);
@@ -218,7 +218,7 @@ jboolean freerdp_callback_bool_result(const char* callback, const char* signatur
jint freerdp_callback_int_result(const char* callback, const char* signature, ...)
{
va_list vl;
va_list vl = { 0 };
va_start(vl, signature);
jint res = java_callback_int(jLibFreeRDPObject, callback, signature, vl);
va_end(vl);

2
client/SDL/SDL2/dialogs/sdl_connection_dialog.cpp
View File

@@ -455,7 +455,7 @@ std::string SDLConnectionDialog::print(const char* fmt, va_list ap)
if (size > 0)
res.resize(WINPR_ASSERTING_INT_CAST(size_t, size));
va_list copy;
va_list copy = {};
va_copy(copy, ap);
WINPR_PRAGMA_DIAG_PUSH
WINPR_PRAGMA_DIAG_IGNORED_FORMAT_NONLITERAL

2
client/SDL/SDL3/dialogs/sdl_connection_dialog.cpp
View File

@@ -439,7 +439,7 @@ std::string SDLConnectionDialog::print(const char* fmt, va_list ap)
if (size > 0)
res.resize(WINPR_ASSERTING_INT_CAST(uint32_t, size));
va_list copy;
va_list copy = {};
va_copy(copy, ap);
WINPR_PRAGMA_DIAG_PUSH
WINPR_PRAGMA_DIAG_IGNORED_FORMAT_NONLITERAL

12
client/SDL/SDL3/dialogs/sdl_connection_dialog_wrapper.cpp
View File

@@ -75,7 +75,7 @@ bool SdlConnectionDialogWrapper::handleEvent(const SDL_Event& event)
WINPR_ATTR_FORMAT_ARG(1, 0)
static std::string format(WINPR_FORMAT_ARG const char* fmt, va_list ap)
{
va_list ap1;
va_list ap1 = {};
va_copy(ap1, ap);
const int size = vsnprintf(nullptr, 0, fmt, ap1);
va_end(ap1);
@@ -86,7 +86,7 @@ static std::string format(WINPR_FORMAT_ARG const char* fmt, va_list ap)
std::string msg;
msg.resize(static_cast<size_t>(size) + 1);
va_list ap2;
va_list ap2 = {};
va_copy(ap2, ap);
std::ignore = vsnprintf(msg.data(), msg.size(), fmt, ap2);
va_end(ap2);
@@ -95,7 +95,7 @@ static std::string format(WINPR_FORMAT_ARG const char* fmt, va_list ap)
void SdlConnectionDialogWrapper::setTitle(const char* fmt, ...)
{
va_list ap;
va_list ap = {};
va_start(ap, fmt);
setTitle(format(fmt, ap));
va_end(ap);
@@ -108,7 +108,7 @@ void SdlConnectionDialogWrapper::setTitle(const std::string& title)
void SdlConnectionDialogWrapper::showInfo(const char* fmt, ...)
{
va_list ap;
va_list ap = {};
va_start(ap, fmt);
showInfo(format(fmt, ap));
va_end(ap);
@@ -121,7 +121,7 @@ void SdlConnectionDialogWrapper::showInfo(const std::string& info)
void SdlConnectionDialogWrapper::showWarn(const char* fmt, ...)
{
va_list ap;
va_list ap = {};
va_start(ap, fmt);
showWarn(format(fmt, ap));
va_end(ap);
@@ -134,7 +134,7 @@ void SdlConnectionDialogWrapper::showWarn(const std::string& info)
void SdlConnectionDialogWrapper::showError(const char* fmt, ...)
{
va_list ap;
va_list ap = {};
va_start(ap, fmt);
showError(format(fmt, ap));
va_end(ap);

4
client/Windows/wf_client.c
View File

@@ -663,8 +663,8 @@ static WCHAR* wf_format_text(const WCHAR* fmt, ...)
do
{
WCHAR* tmp;
va_list ap;
WCHAR* tmp = NULL;
va_list ap = { 0 };
va_start(ap, fmt);
rc = _vsnwprintf(buffer, size, fmt, ap);
va_end(ap);

4
client/X11/xf_utils.c
View File

@@ -90,7 +90,7 @@ static int write_result_log_expect_success(wLog* log, DWORD level, const char* f
{
if (rc != Success)
{
va_list ap;
va_list ap = { 0 };
(void)write_result_log_va(log, level, fname, fkt, line, display, name, rc, 0, ap);
}
return rc;
@@ -101,7 +101,7 @@ static int write_result_log_expect_one(wLog* log, DWORD level, const char* fname
{
if (rc != 1)
{
va_list ap;
va_list ap = { 0 };
(void)write_result_log_va(log, level, fname, fkt, line, display, name, rc, 0, ap);
}
return rc;

2
client/X11/xf_window.c
View File

@@ -232,7 +232,7 @@ static void xf_SetWindowTitleText(xfContext* xfc, Window window, const char* nam
void xf_SendClientEvent(xfContext* xfc, Window window, Atom atom, unsigned int numArgs, ...)
{
XEvent xevent = { 0 };
va_list argp;
va_list argp = { 0 };
va_start(argp, numArgs);
xevent.xclient.type = ClientMessage;

6
client/common/client.c
View File

@@ -2203,7 +2203,7 @@ BOOL freerdp_client_handle_pen(rdpClientContext* cctx, UINT32 flags, INT32 devic
#if defined(CHANNEL_RDPEI_CLIENT)
if ((flags & FREERDP_PEN_REGISTER) != 0)
{
va_list args;
va_list args = { 0 };
va_start(args, deviceid);
double pressure = va_arg(args, double);
@@ -2231,7 +2231,7 @@ BOOL freerdp_client_handle_pen(rdpClientContext* cctx, UINT32 flags, INT32 devic
UINT16 rotation = 0;
INT16 tiltX = 0;
INT16 tiltY = 0;
va_list args;
va_list args = { 0 };
va_start(args, deviceid);
x = va_arg(args, INT32);
@@ -2572,7 +2572,7 @@ char* freerdp_client_get_aad_url(rdpClientContext* cctx, freerdp_client_aad_type
WINPR_ASSERT(cctx);
char* str = NULL;
va_list ap;
va_list ap = { 0 };
va_start(ap, type);
switch (type)
{

2
client/common/client_cliprdr_file.c
View File

@@ -228,7 +228,7 @@ static CliprdrFuseFile* fuse_file_new(WINPR_FORMAT_ARG const char* fmt, ...)
WINPR_ASSERT(fmt);
{
va_list ap;
va_list ap = { 0 };
va_start(ap, fmt);
const int rc =
winpr_vasprintf(&file->filename_with_root, &file->filename_with_root_len, fmt, ap);

2
client/common/sso_mib_tokens.c
View File

@@ -153,7 +153,7 @@ static BOOL sso_mib_get_access_token(rdpContext* context, AccessTokenType tokenT
const char* scope = NULL;
const char* req_cnf = NULL;
va_list ap;
va_list ap = { 0 };
va_start(ap, count);
if (tokenType == ACCESS_TOKEN_TYPE_AAD)

2
client/iOS/Models/RDPSession.m
View File

@@ -46,7 +46,7 @@ NSString *TSXSessionDidFailToConnectNotification = @"TSXSessionDidFailToConnect"
static BOOL addArgument(int *argc, char ***argv, const char *fmt, ...)
{
va_list ap;
va_list ap = { 0 };
char *arg = NULL;
char **tmp = realloc(*argv, (*argc + 1) * sizeof(char *));