morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-14 08:24:16 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5988 from akallabeth/rdp_parser_leak

Browse Source 
Fixed memory leak in rdp file parser.
This commit is contained in:
Martin Fleisz
2020-03-24 12:17:05 +01:00
committed by GitHub
parent 38d1be72b4 fdf151698d
commit 43d3f89ce7
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
client/common/file.c
View File

@@ -1992,9 +1992,7 @@ rdpFile* freerdp_client_rdp_file_new_ex(DWORD flags)
return file;
fail:
free(file->argv);
free(file->lines);
free(file);
freerdp_client_rdp_file_free(file);
return NULL;
}
void freerdp_client_rdp_file_free(rdpFile* file)
@@ -2010,18 +2008,16 @@ void freerdp_client_rdp_file_free(rdpFile* file)
free(file->lines[i].name);
free(file->lines[i].sValue);
}
free(file->lines);
}
free(file->lines);
if (file->argv)
{
size_t i;
for (i = 0; i < file->argc; i++)
free(file->argv[i]);
free(file->argv);
}
free(file->argv);
freerdp_client_file_string_check_free(file->Username);
freerdp_client_file_string_check_free(file->Domain);