morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-14 00:14:11 +09:00
Code Issues Packages Projects Releases Wiki Activity

[warnings] annotate readability-non-const-parameter

Browse Source
This commit is contained in:
akallabeth
2024-09-30 20:32:17 +02:00
parent ae61278d18
commit 574742bae8
12 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
channels/rdpsnd/client/rdpsnd_main.c
View File

@@ -1698,10 +1698,12 @@ static UINT rdpsnd_on_close(IWTSVirtualChannelCallback* pChannelCallback)
return CHANNEL_RC_OK;
}
// NOLINTBEGIN(readability-non-const-parameter)
static UINT rdpsnd_on_new_channel_connection(IWTSListenerCallback* pListenerCallback,
IWTSVirtualChannel* pChannel, BYTE* Data,
BOOL* pbAccept,
IWTSVirtualChannelCallback** ppCallback)
// NOLINTEND(readability-non-const-parameter)
{
GENERIC_CHANNEL_CALLBACK* callback = NULL;
GENERIC_LISTENER_CALLBACK* listener_callback = (GENERIC_LISTENER_CALLBACK*)pListenerCallback;

4
channels/video/client/video_main.c
View File

@@ -1013,10 +1013,12 @@ static UINT video_data_on_close(IWTSVirtualChannelCallback* pChannelCallback)
*
* @return 0 on success, otherwise a Win32 error code
*/
// NOLINTBEGIN(readability-non-const-parameter)
static UINT video_control_on_new_channel_connection(IWTSListenerCallback* listenerCallback,
IWTSVirtualChannel* channel, BYTE* Data,
BOOL* pbAccept,
IWTSVirtualChannelCallback** ppCallback)
// NOLINTEND(readability-non-const-parameter)
{
GENERIC_CHANNEL_CALLBACK* callback = NULL;
GENERIC_LISTENER_CALLBACK* listener_callback = (GENERIC_LISTENER_CALLBACK*)listenerCallback;
@@ -1043,10 +1045,12 @@ static UINT video_control_on_new_channel_connection(IWTSListenerCallback* listen
return CHANNEL_RC_OK;
}
// NOLINTBEGIN(readability-non-const-parameter)
static UINT video_data_on_new_channel_connection(IWTSListenerCallback* pListenerCallback,
IWTSVirtualChannel* pChannel, BYTE* Data,
BOOL* pbAccept,
IWTSVirtualChannelCallback** ppCallback)
// NOLINTEND(readability-non-const-parameter)
{
GENERIC_CHANNEL_CALLBACK* callback = NULL;
GENERIC_LISTENER_CALLBACK* listener_callback = (GENERIC_LISTENER_CALLBACK*)pListenerCallback;

1
libfreerdp/core/gateway/rdg.c
View File

@@ -2063,6 +2063,7 @@ static int rdg_bio_puts(BIO* bio, const char* str)
return -2;
}
// NOLINTNEXTLINE(readability-non-const-parameter)
static int rdg_bio_gets(BIO* bio, char* str, int size)
{
WINPR_UNUSED(bio);

1
libfreerdp/core/gateway/tsg.c
View File

@@ -2970,6 +2970,7 @@ static int transport_bio_tsg_puts(BIO* bio, const char* str)
return 1;
}
// NOLINTNEXTLINE(readability-non-const-parameter)
static int transport_bio_tsg_gets(BIO* bio, char* str, int size)
{
WINPR_UNUSED(bio);

1
libfreerdp/core/gateway/wst.c
View File

@@ -608,6 +608,7 @@ static int wst_bio_puts(BIO* bio, const char* str)
return -2;
}
// NOLINTNEXTLINE(readability-non-const-parameter)
static int wst_bio_gets(BIO* bio, char* str, int size)
{
WINPR_UNUSED(bio);

2
libfreerdp/primitives/prim_YUV.c
View File

@@ -630,10 +630,12 @@ static INLINE BYTE RGB2V(INT32 R, INT32 G, INT32 B)
return ((128 * R - 116 * G - 12 * B) >> 8) + 128;
}
// NOLINTBEGIN(readability-non-const-parameter)
static pstatus_t general_RGBToYUV444_8u_P3AC4R(const BYTE* WINPR_RESTRICT pSrc, UINT32 SrcFormat,
const UINT32 srcStep, BYTE* WINPR_RESTRICT pDst[3],
UINT32 dstStep[3],
const prim_size_t* WINPR_RESTRICT roi)
// NOLINTEND(readability-non-const-parameter)
{
const UINT32 bpp = FreeRDPGetBytesPerPixel(SrcFormat);
UINT32 nWidth = 0;

1
libfreerdp/utils/test/TestPodArrays.c
View File

@@ -18,6 +18,7 @@
*/
#include <freerdp/utils/pod_arrays.h>
// NOLINTNEXTLINE(readability-non-const-parameter)
static BOOL cb_compute_sum(UINT32* v, void* target)
{
UINT32* ret = (UINT32*)target;

2
winpr/libwinpr/file/file.c
View File

@@ -116,8 +116,10 @@ static BOOL FileSetEndOfFile(HANDLE hFile)
return TRUE;
}
// NOLINTBEGIN(readability-non-const-parameter)
static DWORD FileSetFilePointer(HANDLE hFile, LONG lDistanceToMove,
const PLONG lpDistanceToMoveHigh, DWORD dwMoveMethod)
// NOLINTEND(readability-non-const-parameter)
{
WINPR_FILE* pFile = (WINPR_FILE*)hFile;
INT64 offset = 0;

2
winpr/libwinpr/pipe/pipe.c
View File

@@ -863,8 +863,10 @@ BOOL WaitNamedPipeW(LPCWSTR lpNamedPipeName, DWORD nTimeOut)
return FALSE;
}
// NOLINTBEGIN(readability-non-const-parameter)
BOOL SetNamedPipeHandleState(HANDLE hNamedPipe, LPDWORD lpMode, LPDWORD lpMaxCollectionCount,
LPDWORD lpCollectDataTimeout)
// NOLINTEND(readability-non-const-parameter)
{
int fd = 0;
int flags = 0;

4
winpr/libwinpr/registry/registry.c
View File

@@ -354,8 +354,10 @@ static LONG reg_read_int(const RegVal* pValue, LPBYTE lpData, LPDWORD lpcbData)
return ERROR_SUCCESS;
}
// NOLINTBEGIN(readability-non-const-parameter)
LONG RegQueryValueExW(HKEY hKey, LPCWSTR lpValueName, LPDWORD lpReserved, LPDWORD lpType,
LPBYTE lpData, LPDWORD lpcbData)
// NOLINTEND(readability-non-const-parameter)
{
LONG status = ERROR_FILE_NOT_FOUND;
RegKey* key = NULL;
@@ -431,8 +433,10 @@ end:
return status;
}
// NOLINTBEGIN(readability-non-const-parameter)
LONG RegQueryValueExA(HKEY hKey, LPCSTR lpValueName, LPDWORD lpReserved, LPDWORD lpType,
LPBYTE lpData, LPDWORD lpcbData)
// NOLINTEND(readability-non-const-parameter)
{
RegKey* key = NULL;
RegVal* pValue = NULL;

1
winpr/libwinpr/smartcard/smartcard_pcsc.c
View File

@@ -2257,6 +2257,7 @@ static LONG WINAPI PCSC_SCardTransmit(SCARDHANDLE hCard, LPCSCARD_IO_REQUEST pio
return PCSC_MapErrorCodeToWinSCard(status);
}
// NOLINTNEXTLINE(readability-non-const-parameter)
static LONG WINAPI PCSC_SCardGetTransmitCount(SCARDHANDLE hCard, LPDWORD pcTransmitCount)
{
WINPR_UNUSED(pcTransmitCount);

2
winpr/libwinpr/timezone/timezone.c
View File

@@ -901,8 +901,10 @@ DWORD EnumDynamicTimeZoneInformation(const DWORD dwIndex,
return ERROR_SUCCESS;
}
// NOLINTBEGIN(readability-non-const-parameter)
DWORD GetDynamicTimeZoneInformationEffectiveYears(
const PDYNAMIC_TIME_ZONE_INFORMATION lpTimeZoneInformation, LPDWORD FirstYear, LPDWORD LastYear)
// NOLINTEND(readability-non-const-parameter)
{
WINPR_UNUSED(lpTimeZoneInformation);
WINPR_UNUSED(FirstYear);