Commit Graph

3273 Commits

Author SHA1 Message Date
Armin Novak
4b4368fc19 [compiler,gcc] fix function pointer casts
use dedicated macro WINPR_FUNC_PTR_CAST to cast function pointers
without warnings.
2026-03-03 17:24:10 +01:00
Armin Novak
81526b19a2 [string,format] fix format strings for debug messages 2026-03-03 14:07:49 +01:00
Armin Novak
2b8ecce7a9 [channels,rdpecam] fix return checks 2026-03-03 13:49:59 +01:00
Armin Novak
1fb02134e6 [channels,drive] fix missing return checks 2026-03-03 13:49:58 +01:00
Armin Novak
1220c7af1c [channels,video] fix missing return checks 2026-03-03 13:49:58 +01:00
Armin Novak
17163d3738 [winpr,collections] fix PubSub_OnEvent return checks
* proper return checks on use
* fix return on invalid input arguments
* fix return on no event registered
2026-03-03 13:49:54 +01:00
Armin Novak
b724ba546d [checks,return] fix various unchecked return values 2026-03-03 09:40:27 +01:00
Armin Novak
23fc8778cb [channels,usb] fix possible deadlock
newly introduced error handling did lead to a deadlock. refactor to
avoid this.
2026-03-03 09:30:33 +01:00
Armin Novak
eba2bf463c [channels,rail] refactor server side functions
* proper error handling
* use [[nodiscard]]
2026-03-03 09:12:35 +01:00
Armin Novak
8316bca9dd [winpr,stream] fix Stream_Write_UTF16_String return checks 2026-03-02 17:36:41 +01:00
Armin Novak
b909b0cf1c [channels] Check HashTable_SetHashFunction return 2026-03-02 16:30:35 +01:00
Armin Novak
e6fca2c021 [winpr,stream] Fix Stream_SetPosition return checks 2026-03-02 11:37:20 +01:00
Armin Novak
5a532269ef [winpr,stream] Check Stream_SetLength return 2026-03-02 11:08:08 +01:00
Armin Novak
92ab55c5e1 [winpr,stream] Add Stream_ResetPosition
A helper function that does not require return checks, in contrast to
Stream_SetPosition, which might fail.
2026-03-01 06:11:59 +01:00
Armin Novak
ea77d2d922 [nodiscard] fix all InitOnceExecuteOnce usages 2026-02-27 15:52:28 +01:00
Armin Novak
2c0c55dc46 [c23,channels] replace NULL with nullptr 2026-02-26 13:43:54 +01:00
Armin Novak
e58819830a [c23] simplify boolean checks 2026-02-26 11:51:05 +01:00
Armin Novak
0531803808 [warnings] make function declaration names consistent
Use the same parameter names for declaration and implementation.
2026-02-26 10:35:25 +01:00
Armin Novak
208bcbd153 [winpr] Add initializer functions
* Add initializer for wStream
* Add initializer for ASN1 decoder
2026-02-25 19:39:24 +01:00
Armin Novak
48267edf2f [winpr] add WINPR_C_ARRAY_INIT
since C23 allows c++ style initializing replace direct use with this
macro
2026-02-25 19:23:08 +01:00
Armin Novak
58c541f723 [channels,rdpgfx] fix wrong function attributes 2026-02-25 12:00:50 +01:00
Armin Novak
76d6e7755c [channels,rdpdr] fix return value type mismatch 2026-02-25 11:51:12 +01:00
Armin Novak
e9723d1b61 [attributes] update attribute definitions
* support C++
* support C23
* replace __inline et al with C11 inline
2026-02-25 11:51:11 +01:00
akallabeth
d606a734c7 Merge pull request #12325 from akallabeth/attr-nodiscard-channels
Attr nodiscard channels
2026-02-25 10:12:42 +01:00
Armin Novak
3fcc287b16 [warnings] initialize all va_list 2026-02-25 07:41:39 +01:00
Armin Novak
8a24443ed6 [nodiscard] fix wrong attribute position 2026-02-24 16:10:11 +01:00
Armin Novak
f14096d468 [channels] mark functions [[nodiscard]] 2026-02-24 11:31:57 +01:00
Armin Novak
f06c066f0a [channels,printer] fix missing includes and format string 2026-02-24 09:05:46 +01:00
Armin Novak
042d0dfd77 [channel,smartcard] fix logging issues 2026-02-20 12:04:57 +01:00
Armin Novak
43f30eb03c [channels,smartcard] refactor channel handling
* Eliminate global sSmartcard instance
* Add logging to device create/init/destroy
* Add logging to context create/destroy
* Do not release context when a device is initialized.
2026-02-20 11:07:49 +01:00
Armin Novak
98f37bdf8c [channel,urbdrc] fix warnings 2026-02-20 10:04:37 +01:00
Armin Novak
0890f24ebc [channel,usb] fix message parsing and creation
* 2.2.10.3 TS_URB_SELECT_INTERFACE_RESULT was generated incorrect
* 2.2.9.4 TS_URB_PIPE_REQUEST OutputBuffer check was wrong
2026-02-19 20:22:23 +01:00
Armin Novak
5f10ae9599 [channels,rdpdr] fix IRP handling
* clean up IRP creation
* Properly handle each IRP, call irp->Complete or irp->Discard only once
  for each IRP
* For each channel split IRP handling, one function prepares the data
  and a single evaluate function later calls irp->Complete or irp->Discard
2026-02-17 16:38:31 +01:00
akallabeth
1b744c15fe Merge pull request #12319 from akallabeth/grow-reasonable
[allocations] fix growth of preallocated buffers
2026-02-17 15:23:17 +01:00
Armin Novak
118afc0b95 [allocations] fix growth of preallocated buffers
* Replace * 2 with * sizeof(WCHAR) for string usages
* Grow streams and other buffers reasonably, e.g. add 128 elements per
  try and check for possible overflows
* Add constant postfix to force them to 64bit
2026-02-17 13:54:34 +01:00
Armin Novak
df64d00a97 [warnings,api] fix -Wunused-result
With marking publid API [[nodiscard]] some problematic error checks in
the core library were uncovered. This commit addresses these
shortcomings.
2026-02-17 11:07:08 +01:00
Armin Novak
bf99266c2e [channels,warnings] properly handle function return 2026-02-16 09:18:38 +01:00
Armin Novak
93dc6b8691 [channels,tsmf] fix function misnaming 2026-02-16 09:18:36 +01:00
Armin Novak
775ee2615a [freerdp,channels] mark function pointers [[nodiscard]] 2026-02-16 09:18:34 +01:00
Armin Novak
6a1cc0f031 [freerdp,api] mark function pointers [[nodiscard]] 2026-02-16 09:18:30 +01:00
Armin Novak
eb0b74a908 [channels,rdpecam] fix sign warnings 2026-02-13 12:17:47 +01:00
Armin Novak
5c682eee86 [channels,video] make channel less verbose
The channel did spam the log with frame updates, remove that message in
the hot path.
2026-02-11 17:02:41 +01:00
Armin Novak
fff62ff919 [channels,rdpecam] fix integer types and warnings 2026-02-10 19:07:10 +01:00
Armin Novak
e3981d8f02 [channels,rdpecam] fix integer types and warnings 2026-02-10 17:02:15 +01:00
Armin Novak
f3ab7b65b9 [channels,rdpear] fix uninitialized variable warnings 2026-02-10 16:56:48 +01:00
Armin Novak
0fefdd1274 [channels,audin|rdpsnd] fix enum cast warnings 2026-02-10 15:53:06 +01:00
akallabeth
cb3fb59a89 Merge pull request #12285 from akallabeth/pulse-name
Use application details for names
2026-02-10 12:18:25 +01:00
Armin Novak
0a4122fb27 [channels,drive] name volume with freerdp_getApplicationDetailsString 2026-02-10 11:20:13 +01:00
Armin Novak
3df54a3e79 [channels,tsmf] use freerdp_getApplicationDetailsString
Name pulse source/sinc properly
2026-02-10 11:20:12 +01:00
Armin Novak
5f410772b6 [channels,printer] use freerdp_getApplicationDetailsString
Use proper vendor/product name for job name
2026-02-10 11:20:08 +01:00