Commit Graph

426 Commits

Author SHA1 Message Date
akallabeth
8b9335aa90 [CMake,libfreerdp] add pkg-config dependencies 2025-09-11 07:17:42 +02:00
akallabeth
e52d024071 [core,settings] unify config path determination 2025-08-29 10:53:26 +02:00
Armin Novak
058cfa972f [macros] #ifndef MAX
on some platforms the macro is part of the standard library, only define
if not already there.
2025-08-20 11:38:46 +02:00
akallabeth
65f18983ed [warnings] Fix format string errors
* Fix casts of format string arguments (%p requires void*)
* Fix format string to match type of arguments
2025-08-13 15:09:48 +02:00
akallabeth
c3e507a82e [winpr,wlog] Replace WLog_PrintMessage calls
Prefer WLog_PrintTextMessage to have proper format string checks in
place.
2025-08-13 15:08:01 +02:00
akallabeth
d690ea0cb2 [utils,smartcard] fix possible assertion 2025-06-10 16:27:16 +02:00
akallabeth
6b80a2d4ef [utils,smartcard] better logging and error checks
* Use wLog as argument where possible to reduce the number of WLog_Get
  calls
* Do better failure checks to avoid reading invalid memory
2025-05-27 10:33:37 +02:00
akallabeth
50cef020de [utils,helpers] add freerdp_GetJSONConfigFile 2025-05-26 19:36:40 +02:00
akallabeth
60330fc771 [utils,smartcard] handle output buffer too small 2025-05-07 21:13:50 +02:00
Armin Novak
4cb1536d2c [utils,smartcard] ignore ConvertWCharToUtf8 return 2025-04-15 10:12:18 +02:00
akallabeth
2e7e6dde87 [utils,smartcard] improve trace log 2025-04-14 22:36:45 +02:00
Armin Novak
f5435740d4 [utils,smartcard] assert and improve log 2025-04-14 13:56:24 +02:00
Armin Novak
de7d253e79 [utils,smartcard] only check return length if success 2025-04-09 10:22:02 +02:00
akallabeth
c06bf6ccb0 [warnings] fix format warnings 2025-03-24 21:23:10 +01:00
akallabeth
9f90d22c9b [utils,pcap] code cleanup 2025-03-04 12:42:40 +01:00
Armin Novak
f24a562f1e [utils,smartcard] check output buffer length
check the resulting length to the one preallocated.
2025-02-26 18:24:51 +01:00
akallabeth
74cd8d8fe0 [freerdp,warnings] fix -Wunused-parameter 2025-02-13 15:53:54 +01:00
akallabeth
5b1c254f2d [utils,smartcard] fix return checks for SCardListReaders 2025-02-13 12:00:12 +01:00
akallabeth
25b5dec23d [utils,smartcard] return proper list for smartcard listing 2025-02-10 17:32:12 +01:00
akallabeth
44f5b6c409 [warnings] fix various clang warnings 2025-02-04 11:22:00 +01:00
akallabeth
0354dd33e1 [utils,passphrase] fix missing include 2025-01-31 12:17:02 +01:00
akallabeth
ea2022b76b [clang,tidy] fix warnings 2025-01-15 09:32:52 +01:00
akallabeth
3092313d49 [channes,rdpdr] use NTSTATUS for IoStatus
the IoStatus will hold NTSTATUS values but is defined unsigned in
[MS-RDPEFS] whereas NTSTATUS is defined as signed integer. Ignore the
spec here and just treat it as signed (eliminates warnings and twos
complement will ensure the values are equal in bit representation)
2025-01-07 10:11:21 +01:00
akallabeth
cc934795e4 [warnings] fix integer casting
* use asserting casts to detect overflows or sign conversions
* code cleanup for issues uncovered by casts
2025-01-01 12:58:34 +01:00
akallabeth
25521917e2 [utils,passphrase] allow popen
silence clang-analyzer as we require popen for FREERDP_ASKPASS
2024-12-10 18:03:42 +01:00
Armin Novak
cc0e1c0910 [utils,ringbuffer] assert arguments 2024-12-10 11:39:59 +01:00
akallabeth
0780628270 [utils,signal] ignore SIGTSTP
Ignore keyboard stop signal, do not quit application.
2024-12-09 13:13:44 +01:00
akallabeth
83f2f21ad3 [warnigns] fix lots of bugprone warnings
* update-settings-tests: properly cast types in getter/setter
* wtypes: fix PHANDLE definition
* wStream: fix INT64 write function warnings
* Simplify HANDLE copy in channels, just assign after proper cast
2024-12-06 09:15:48 +01:00
akallabeth
faae38120c [cmake,format] reformat all cmake files 2024-11-27 20:41:48 +01:00
stephanebill
4f2afa8c47 spell check with codespell 2024-11-20 16:53:40 -05:00
akallabeth
38dab4b2ab [utils,test] fix invalid format string 2024-11-19 17:56:45 +01:00
akallabeth
08839a11de [utils,passphrase] NULL checks 2024-11-12 16:46:04 +01:00
akallabeth
78acedb40e [warnigns] fix Wshorten-64-to-32 2024-11-11 10:22:37 +01:00
akallabeth
dcf5a8e28c [warnings] fix -Wswitch-default 2024-10-31 11:42:24 +01:00
akallabeth
6b6ae5fa9d [utils,helpers] revert removed define
the define was conditionally unused. guard it now so it does not show up
as unused
2024-10-31 08:51:55 +01:00
akallabeth
dc76879e0b [warnings] fix some compiler warnings
* fix compiler warnings found in a lot of places
* add missing enum type for clipboard channel
* mark deallocator for winpr image function
2024-10-30 16:12:20 +01:00
akallabeth
24ab4b297f [utils,string] fix freerdp_extract_key_value
reset errno before strtoul to avoid aborting due to a previous errno
value from a different function call
2024-10-29 16:50:00 +01:00
akallabeth
a3aa01214c [resource root] unify locations
unify resource locations in case WITH_BINARY_VERSIONING is set.
2024-10-25 11:40:40 +02:00
Armin Novak
527db6783b [cmake] split tests
* Keep BUILD_TESTING, but only run tests compatible with API (for
  packaging)
* Add BUILD_TESTING_INTERNAL for all tests including internal function
  tests that modify API to be run on our CI
2024-10-24 09:45:44 +02:00
akallabeth
f346b94835 replace SIZE_T with size_t 2024-10-17 12:40:22 +02:00
akallabeth
dc8d8553e8 [utils,smartcard] ensure '\0' termination for NDR
NDR read functions do not exactly know which kind of string is read and
if it contains a '\0', so ensure that we add one large enought to hold a
unicode '\0'
2024-10-10 16:25:41 +02:00
akallabeth
6c8c67b385 Merge pull request #10677 from akallabeth/int-narrow
Int narrow
2024-10-03 21:17:56 +02:00
akallabeth
e13273d94d [utils,test] fix integer narrow 2024-10-03 18:58:44 +02:00
Martin Fleisz
966ddd13df Merge pull request #10694 from akallabeth/qa-fixes
Qa fixes
2024-10-03 13:09:06 +02:00
Armin Novak
dcdb0bb3b2 [utils,helpers] add a function to get FreeRDP config file paths 2024-10-02 23:28:00 +02:00
akallabeth
fe8555a4fd [warnings] annotate cert-err34-c 2024-10-01 13:05:36 +02:00
akallabeth
f6eb6ad4d7 [utils,string] add freerdp_extract_key_value
* Add new function freerdp_extract_key_value to extract key/value pairs
  from a string
* replace all sscanf usages with this new function
2024-10-01 13:05:34 +02:00
akallabeth
574742bae8 [warnings] annotate readability-non-const-parameter 2024-10-01 13:05:19 +02:00
akallabeth
8a0194c105 [clang-tidy] annotate suspicious-memory-comparison 2024-10-01 13:05:11 +02:00
akallabeth
47c5070805 Merge pull request #10635 from akallabeth/initialize-variables
Initialize variables
2024-09-30 16:04:20 +02:00