morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-14 00:14:11 +09:00
Code Issues Packages Projects Releases Wiki Activity
23,057 Commits 3 Branches 0 Tags
81526b19a2933e93d37d2007f4fe24e9df699123
Commit Graph

23057 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Armin Novak
81526b19a2 [string,format] fix format strings for debug messages 2026-03-03 14:07:49 +01:00
Armin Novak
a9e0abf2ea [core,orders] improve input validation 
check length before subtracting. Might underflow and be cought by the
next check, but lets be strict.
 2026-03-03 13:58:52 +01:00
Armin Novak
125b1ce99e [utils,ringbuffer] fix debug log messages 
Renaming some variables also in debug messages
 2026-03-03 13:49:59 +01:00
Armin Novak
2b8ecce7a9 [channels,rdpecam] fix return checks 2026-03-03 13:49:59 +01:00
Armin Novak
1fb02134e6 [channels,drive] fix missing return checks 2026-03-03 13:49:58 +01:00
Armin Novak
1220c7af1c [channels,video] fix missing return checks 2026-03-03 13:49:58 +01:00
Armin Novak
ce3f205cd6 [core,gateway] fix missing return checks 2026-03-03 13:49:58 +01:00
Armin Novak
17163d3738 [winpr,collections] fix PubSub_OnEvent return checks 
* proper return checks on use
* fix return on invalid input arguments
* fix return on no event registered
 2026-03-03 13:49:54 +01:00
akallabeth
32b2bd22aa Merge pull request #12412 from akallabeth/more-return-checks 
More return checks
 2026-03-03 12:17:41 +01:00
Armin Novak
ba11055d66 [utils,smartcard] log all call failures 
Use GNU expression statement to log a call failure if the compiler
supports that extension.
 2026-03-03 11:59:14 +01:00
Armin Novak
75d8f295b4 [checks,return] Fix missing *_foreach return checks 
* Check HashTable_Foreach return
* Check ArrayList_ForEach return
 2026-03-03 11:07:59 +01:00
akallabeth
ef3e4a39c9 Merge pull request #12411 from akallabeth/multifrag-add-checks 
Address various error handling inconsistencies
 2026-03-03 10:31:09 +01:00
Armin Novak
b724ba546d [checks,return] fix various unchecked return values 2026-03-03 09:40:27 +01:00
Armin Novak
103e0907cc [core,caps] use getter/setter for MultifragMaxRequestSize 
to ease debugging use the getter/setters instead of direct struct
access.
 2026-03-03 09:30:34 +01:00
Armin Novak
4475e21b7e [codec,rfx] return nullptr if input parameters are invalid 
rfx_encode_messages maxDataSize must be > 1024 or the function will
fail. Add a check to abort early if this is the case.
while this is a usage error, it is helpful to have proper error handling
in the function as well.
 2026-03-03 09:30:33 +01:00
Armin Novak
23fc8778cb [channels,usb] fix possible deadlock 
newly introduced error handling did lead to a deadlock. refactor to
avoid this.
 2026-03-03 09:30:33 +01:00
Armin Novak
d34f41a30b [winpr,sspi] fix missing return check 2026-03-03 09:30:32 +01:00
akallabeth
fd642b57b1 Merge pull request #12410 from larsch/fix/uwac-damage-glitch 
[uwac] fix rectangular glitch around surface damage regions
 2026-03-03 09:21:56 +01:00
Armin Novak
eba2bf463c [channels,rail] refactor server side functions 
* proper error handling
* use [[nodiscard]]
 2026-03-03 09:12:35 +01:00
Lars Christensen
6bf6ac26ab [uwac] fix rectangular glitch around surface damage regions 
Commit 09c12699 ("[uwac] window: fix damage region dimensions (rounding
errors)") added a 1-pixel expansion to the damage rect passed to
wl_surface_damage() (i.e. x-=1, y-=1, w+=2, h+=2) to guard against
rounding errors when a display scale factor is in use.

This causes visible rectangular glitches around every updated region.
The Wayland compositor re-composites exactly the declared damage region
from the attached buffer onto the screen. Because wlf_copy_image() only
writes pixels for the exact update rectangle, the 1-pixel border in the
buffer is never updated. With double-buffering the border pixels contain
stale data from the last time that buffer was used, and the compositor
faithfully composites those stale pixels, producing the artifact.

The floor/ceil rounding applied before the expansion is already
sufficient to cover any sub-pixel precision lost when converting from
buffer coordinates to surface coordinates. Remove the extra ±1 padding.
 2026-03-02 19:42:26 +01:00
akallabeth
98eb11b253 Merge pull request #12409 from akallabeth/various-return-checks 
Various return checks
 2026-03-02 19:05:12 +01:00
Armin Novak
7de0a5bba4 [winpr] fix various return checks 2026-03-02 18:39:42 +01:00
Armin Novak
212d4d5e29 [client,common] add return checks 2026-03-02 18:32:38 +01:00
Armin Novak
9de3eaa037 [server,proxy] add return checks 2026-03-02 18:32:38 +01:00
Armin Novak
35831303ea [various] add proper return checks 2026-03-02 18:32:38 +01:00
Armin Novak
b1e4933c78 [winpr,clipboard] ClipboardRegisterSynthesizer return checks 2026-03-02 18:32:37 +01:00
akallabeth
9774cd06f5 Merge pull request #12408 from akallabeth/stream-return 
[winpr,stream] fix Stream_Write_UTF16_String return checks
 2026-03-02 18:06:14 +01:00
Armin Novak
8316bca9dd [winpr,stream] fix Stream_Write_UTF16_String return checks 2026-03-02 17:36:41 +01:00
akallabeth
a16e6a632f Merge pull request #12407 from akallabeth/return-checks 
Return checks
 2026-03-02 16:58:34 +01:00
Armin Novak
a694b4f22b [winpr,crypto] simplify expression 2026-03-02 16:31:09 +01:00
Armin Novak
b909b0cf1c [channels] Check HashTable_SetHashFunction return 2026-03-02 16:30:35 +01:00
Armin Novak
56f4337220 [server] Check WTSRegisterWtsApiFunctionTable return 2026-03-02 16:19:17 +01:00
akallabeth
c7622dffa0 Merge pull request #12406 from akallabeth/nodiscard-more-more 
Nodiscard more more
 2026-03-02 12:21:57 +01:00
Armin Novak
7d2f75881c [core,license] fix unused result warnings 2026-03-02 12:08:44 +01:00
Armin Novak
2b0637d629 [nodiscard] mark more internal functions 2026-03-02 11:57:27 +01:00
Armin Novak
be5c9bed64 [utils,pcap] check _fseeki64 return 2026-03-02 11:57:23 +01:00
akallabeth
f58eb53b98 Merge pull request #12403 from akallabeth/winpr-set-pos 
Winpr set pos
 2026-03-02 11:56:28 +01:00
Armin Novak
e6fca2c021 [winpr,stream] Fix Stream_SetPosition return checks 2026-03-02 11:37:20 +01:00
Armin Novak
0f46216a24 [winpr,ssl] check winpr_InitializeSSL return 2026-03-02 11:21:21 +01:00
akallabeth
90536b924e Merge pull request #12405 from akallabeth/winpr-set-length 
[winpr,stream] Check Stream_SetLength return
 2026-03-02 11:20:59 +01:00
Armin Novak
5a532269ef [winpr,stream] Check Stream_SetLength return 2026-03-02 11:08:08 +01:00
akallabeth
b8c32fbdd5 Merge pull request #12404 from akallabeth/scard-signal-stop 
[server,proxy] check for nullptr before using scard_call_context
 2026-03-02 10:26:34 +01:00
Armin Novak
fc6f76d23b [server,proxy] expect element to be NULL 
channel_stop_and_wait might be called with incompletely allocated
elements. Assume each member of the struct might be NULL
 2026-03-02 09:57:03 +01:00
Armin Novak
cc5f1bbb82 [server,proxy] check for nullptr before using scard_call_context 
* Make smartcard_call_cancel_all_context return FALSE if a NULL context
  is supplied.

* Do not call smartcard_call_context_signal_stop if the context is NULL
 2026-03-02 09:45:27 +01:00
akallabeth
d9e1b494d6 Merge pull request #12400 from akallabeth/bounds-checks 
Bounds checks
 2026-03-01 09:38:51 +01:00
Armin Novak
4ff57b68c2 [client,x11] refactor locking 
X11 and railWindows lock must be held at the same time to avoid
deadlocking.
 2026-03-01 09:23:42 +01:00
Armin Novak
5b4fae7afb [client,sdl] ignore input events unless connected 
Ignore events that occur while the client is not fully connected.
 2026-03-01 08:02:42 +01:00
Armin Novak
92ab55c5e1 [winpr,stream] Add Stream_ResetPosition 
A helper function that does not require return checks, in contrast to
Stream_SetPosition, which might fail.
 2026-03-01 06:11:59 +01:00
Armin Novak
41c9286c3c [gdi,gfx] tighter bounds checks for gfx updates 2026-03-01 06:11:55 +01:00
Armin Novak
ffad58fd2b [cache,bitmap] overallocate bitmap cache 2026-02-28 11:53:29 +01:00