Commit Graph

87 Commits

Author SHA1 Message Date
Armin Novak
b724ba546d [checks,return] fix various unchecked return values 2026-03-03 09:40:27 +01:00
Armin Novak
212d4d5e29 [client,common] add return checks 2026-03-02 18:32:38 +01:00
Armin Novak
465a6353d5 [c23,client] replace NULL with nullptr 2026-02-26 15:42:59 +01:00
Armin Novak
e58819830a [c23] simplify boolean checks 2026-02-26 11:51:05 +01:00
Armin Novak
48267edf2f [winpr] add WINPR_C_ARRAY_INIT
since C23 allows c++ style initializing replace direct use with this
macro
2026-02-25 19:23:08 +01:00
Armin Novak
3fcc287b16 [warnings] initialize all va_list 2026-02-25 07:41:39 +01:00
Armin Novak
df64d00a97 [warnings,api] fix -Wunused-result
With marking publid API [[nodiscard]] some problematic error checks in
the core library were uncovered. This commit addresses these
shortcomings.
2026-02-17 11:07:08 +01:00
Armin Novak
f4b0549c5b [client,warnings] properly handle function return 2026-02-16 09:18:38 +01:00
akallabeth
495a82c463 [client] mark all WINPR_ATTR_MALLOC also nodiscard 2026-01-26 13:22:28 +01:00
Armin Novak
de00daba43 [clang,warnings] fix Wjump-misses-init 2026-01-08 11:32:36 +01:00
akallabeth
65f18983ed [warnings] Fix format string errors
* Fix casts of format string arguments (%p requires void*)
* Fix format string to match type of arguments
2025-08-13 15:09:48 +02:00
akallabeth
c3e507a82e [winpr,wlog] Replace WLog_PrintMessage calls
Prefer WLog_PrintTextMessage to have proper format string checks in
place.
2025-08-13 15:08:01 +02:00
akallabeth
9763297d6a [client,common] (re)initialize fuse root in cliprdr_file_context_init
The clipboard might be (re)initialized multiple times, to do
initialization and deinitialization in cliprdr_file_context_init and
cliprdr_file_context_uninit.
2025-06-02 09:20:22 +02:00
akallabeth
5d088ce9c0 [client,cliprdr] refactor file clipboard 2025-05-23 15:23:28 +02:00
akallabeth
03a72a56db [client,common] lock clipboard on update 2025-05-22 14:58:21 +02:00
akallabeth
36c5826f45 [client,warnings] fix -Wunused-parameter for common 2025-02-13 15:54:04 +01:00
akallabeth
00e61074b2 [unused] eliminate unused functions 2025-02-10 09:32:19 +01:00
fossdd
38aebbca64 [client,common] Avoid use of reserved types
__off_t is a internal type of glibc and does not exist on other libc's.
2025-02-07 19:12:04 +01:00
akallabeth
44f5b6c409 [warnings] fix various clang warnings 2025-02-04 11:22:00 +01:00
akallabeth
6701359cc1 [warnings] fix integer casting
* use WINPR_ASSERTING_INT_CAST where possible
* clean up client code
2024-12-19 12:45:23 +01:00
akallabeth
78acedb40e [warnigns] fix Wshorten-64-to-32 2024-11-11 10:22:37 +01:00
akallabeth
dcf5a8e28c [warnings] fix -Wswitch-default 2024-10-31 11:42:24 +01:00
Armin Novak
d3f8cd3073 [client,common] fix data race 2024-10-23 11:39:29 +02:00
akallabeth
1cd0d0ab6e [client,common] use uintptr_t instad of UINT_PTR 2024-10-01 13:04:40 +02:00
akallabeth
a23d45a419 [client,common] make time a 64bit signed integer 2024-10-01 13:04:37 +02:00
akallabeth
47c5070805 Merge pull request #10635 from akallabeth/initialize-variables
Initialize variables
2024-09-30 16:04:20 +02:00
akallabeth
ce30f80d2c [client,common] disable clang-tidy for function
change_lock moves ownership of allocated CliprdrLocalStream to
file->local_streams. Do not complain about possible memory leak (false
positive)
2024-09-30 15:41:42 +02:00
akallabeth
26003e59cc [va_list] initialize with ={0}; 2024-09-24 11:06:18 +02:00
akallabeth
239440e28d [warnings] remove or comment unused macros 2024-09-20 18:49:38 +02:00
akallabeth
bb242b9a89 [return checks] fix use of WaitForSingleObject 2024-09-16 08:22:37 +02:00
akallabeth
965d231e49 [return checks] fix use of CloseHandle 2024-09-16 08:22:31 +02:00
akallabeth
cd18dea174 [return checks] fix use of unicode functions 2024-09-16 06:48:26 +02:00
akallabeth
7d67b8e204 [return checks] fix use of SetEvent 2024-09-16 06:47:58 +02:00
akallabeth
16cec716e0 [strtok] replace function with strtok_s
Since strtok is not thread safe replace it with strtok_s (WinPR wrapper
around strtok_r for systems not supporting the ISO function names)
2024-09-13 21:19:17 +02:00
akallabeth
5e123735fa [warnings] fixed sign-compare 2024-09-04 10:14:05 +02:00
akallabeth
baa70d1ab6 [warnings] fix compare integers of different signs 2024-09-03 15:10:46 +02:00
akallabeth
5a4a1a40ad fix declaration and implementation parameter names 2024-09-03 12:24:53 +02:00
akallabeth
15456e1ee1 [warnings] fix implicit widening conversion 2024-08-29 10:47:20 +02:00
akallabeth
1d33095500 [warnings] fix cert-err33-c
Fix unused return values, cast to void if on purpose
2024-08-29 10:19:27 +02:00
Armin Novak
c3939a750c [coverity] 1543120 Check of thread-shared field evades lock acquisition 2024-04-15 12:40:01 +02:00
Armin Novak
30f489c2a0 [cliprdr,common] fix file_context->request_table 2024-04-15 12:40:01 +02:00
akallabeth
af1c890295 [coverity] 1543263 Missing unlock 2024-04-12 09:45:09 +02:00
akallabeth
fbc5dfffac [coverity] 1543183 Resource leak 2024-04-11 12:04:07 +02:00
akallabeth
d7ebec5a65 [tidy] move loop variable declaration to loop 2024-02-22 12:31:50 +01:00
akallabeth
d0dc657412 [build] delete unused static functions 2024-02-15 11:49:16 +01:00
akallabeth
0e44b2c674 [clang-tidy] clang-analyzer-unix.Malloc 2024-02-15 11:49:16 +01:00
akallabeth
0ba995655d [clang-tidy] cppcoreguidelines-init-variables 2024-02-15 11:49:16 +01:00
akallabeth
207def5c56 [clang-tidy] readability-isolate-declaration 2024-02-15 11:49:16 +01:00
akallabeth
2fffcd64b9 [winpr] use winpr_strerror instead of strerror
use the wrapper from WinPR to use the best implementation available.
2024-02-06 15:45:47 +01:00
akallabeth
ba8cf8cf21 [build] fix Wmismatched-deallocator warnings
With custom malloc function attributes the fail path in the _New
functions produces warnings due to allocator mismatches. Silence them.
2024-02-05 08:16:55 +01:00