Fix globals guideline

https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources

src/appIcons.js

@@ -49,6 +49,7 @@ import {
   DESKTOPSETTINGS,
   TERMINALSETTINGS,
   EXTENSION_PATH,
+  tracker,
 } from './extension.js'
 import {
   gettext as _,
@@ -99,8 +100,6 @@ let recentlyClickedAppWindows = null
 let recentlyClickedAppIndex = 0
 let recentlyClickedAppMonitorIndex
 
-let tracker = Shell.WindowTracker.get_default()
-
 /**
  * Extend AppIcon
  *

src/extension.js

@@ -19,6 +19,7 @@
 
 import Gio from 'gi://Gio'
 import GLib from 'gi://GLib'
+import Shell from 'gi://Shell'
 
 import * as Main from 'resource:///org/gnome/shell/ui/main.js'
 import { EventEmitter } from 'resource:///org/gnome/shell/misc/signals.js'
@@ -45,6 +46,7 @@ export let TERMINALSETTINGS = null
 export let NOTIFICATIONSSETTINGS = null
 export let PERSISTENTSTORAGE = null
 export let EXTENSION_PATH = null
+export let tracker = null
 
 export default class DashToPanelExtension extends Extension {
   constructor(metadata) {
@@ -70,6 +72,8 @@ export default class DashToPanelExtension extends Extension {
     })
     EXTENSION_PATH = this.path
 
+    tracker = Shell.WindowTracker.get_default()
+
     //create a global object that can emit signals and conveniently expose functionalities to other extensions
     global.dashToPanel = new EventEmitter()
 

src/notificationsMonitor.js

@@ -16,15 +16,14 @@
  */
 
 import Gio from 'gi://Gio'
-import Shell from 'gi://Shell'
 
 import * as Main from 'resource:///org/gnome/shell/ui/main.js'
 import * as MessageTray from 'resource:///org/gnome/shell/ui/messageTray.js'
 import { EventEmitter } from 'resource:///org/gnome/shell/misc/signals.js'
 
+import { tracker } from './extension.js'
 import * as Utils from './utils.js'
 
-const tracker = Shell.WindowTracker.get_default()
 const knownIdMappings = {
   'org.gnome.Evolution': [/^org\.gnome\.[eE]volution([.-].+)?$/g],
 }

src/overview.js

@@ -213,7 +213,10 @@ export const Overview = class {
     let apps = []
 
     this.taskbar._getAppIcons().forEach((appIcon) => {
-      if (!seenApps[appIcon.app] || this.taskbar.allowSplitApps) {
+      if (
+        (!appIcon.app.hideDetails && !seenApps[appIcon.app]) ||
+        this.taskbar.allowSplitApps
+      ) {
         apps.push(appIcon)
       }
 

src/panel.js

@@ -49,20 +49,23 @@ import * as PanelMenu from 'resource:///org/gnome/shell/ui/panelMenu.js'
 import St from 'gi://St'
 import Meta from 'gi://Meta'
 import Pango from 'gi://Pango'
-import Shell from 'gi://Shell'
 import * as PopupMenu from 'resource:///org/gnome/shell/ui/popupMenu.js'
 import * as DateMenu from 'resource:///org/gnome/shell/ui/dateMenu.js'
 import * as Volume from 'resource:///org/gnome/shell/ui/status/volume.js'
 
 import * as Intellihide from './intellihide.js'
 import * as Transparency from './transparency.js'
-import { SETTINGS, DESKTOPSETTINGS, PERSISTENTSTORAGE } from './extension.js'
+import {
+  SETTINGS,
+  DESKTOPSETTINGS,
+  PERSISTENTSTORAGE,
+  tracker,
+} from './extension.js'
 import {
   gettext as _,
   InjectionManager,
 } from 'resource:///org/gnome/shell/extensions/extension.js'
 
-let tracker = Shell.WindowTracker.get_default()
 export const panelBoxes = ['_leftBox', '_centerBox', '_rightBox']
 
 //timeout names

src/panelManager.js

@@ -33,7 +33,7 @@ import * as PanelSettings from './panelSettings.js'
 import * as Proximity from './proximity.js'
 import * as Utils from './utils.js'
 import * as DesktopIconsIntegration from './desktopIconsIntegration.js'
-import { DTP_EXTENSION, SETTINGS } from './extension.js'
+import { DTP_EXTENSION, SETTINGS, tracker } from './extension.js'
 
 import GLib from 'gi://GLib'
 import GObject from 'gi://GObject'
@@ -55,8 +55,6 @@ import {
   WorkspacesView,
 } from 'resource:///org/gnome/shell/ui/workspacesView.js'
 
-let tracker = Shell.WindowTracker.get_default()
-
 export const PanelManager = class {
   constructor() {
     this.overview = new Overview.Overview(this)

src/taskbar.js

@@ -42,7 +42,7 @@ import * as PanelSettings from './panelSettings.js'
 import * as Pos from './panelPositions.js'
 import * as Utils from './utils.js'
 import * as WindowPreview from './windowPreview.js'
-import { DTP_EXTENSION, SETTINGS } from './extension.js'
+import { DTP_EXTENSION, SETTINGS, tracker } from './extension.js'
 
 const SearchController = Main.overview.searchController
 
@@ -1222,7 +1222,6 @@ export const Taskbar = class extends EventEmitter {
   }
 
   _getRunningApps() {
-    let tracker = Shell.WindowTracker.get_default()
     let windows = Utils.getAllMetaWindows()
     let apps = []
 
@@ -1242,7 +1241,6 @@ export const Taskbar = class extends EventEmitter {
       let separateApps = []
 
       if (apps.length) {
-        let tracker = Shell.WindowTracker.get_default()
         let windows = AppIcons.getInterestingWindows(
           null,
           this.dtpPanel.monitor,
@@ -1613,7 +1611,6 @@ export const Taskbar = class extends EventEmitter {
 
   popupFocusedAppSecondaryMenu() {
     let appIcons = this._getAppIcons()
-    let tracker = Shell.WindowTracker.get_default()
 
     for (let i in appIcons) {
       if (appIcons[i].app == tracker.focus_app) {