morgan/helium
1
0
Fork 0
mirror of https://github.com/morgan9e/helium synced 2026-04-14 00:14:20 +09:00
Code Issues Packages Projects Releases Wiki Activity

upstream-fixes/macos-widget: update to prevent parent overlap (#523)

Browse Source 
fixes the main window being clipped by the menu bar

partial copy of chromium/chromium@4f0076b
This commit is contained in:
wukko
2025-11-26 16:01:02 +06:00
committed by GitHub
parent ccb227dc03
commit 7e1d9dd767
1 changed files with 9 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
patches/upstream-fixes/fix-macos-widget-rect.patch
View File

@@ -1,24 +1,20 @@
--- a/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm
+++ b/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm
@@ -352,12 +352,12 @@ struct NSEdgeAndCornerThicknesses {
@@ -352,8 +352,12 @@ struct NSEdgeAndCornerThicknesses {
}
- (NSRect)constrainFrameRect:(NSRect)frameRect toScreen:(NSScreen*)screen {
- // Headless windows should not be constrained within the physical screen.
- if (_isHeadless) {
- return frameRect;
- }
-
- return [super constrainFrameRect:frameRect toScreen:screen];
+ // AppKit's default implementation moves child windows down to avoid
+ // the menu bar. We don't want that behavior, because widgets like the
+ // Omnibox may have a big shadow that could cause invisible menu bar collision
+ // in fullscreen/maximized state. We override it here to return the original
+ // frameRect before the adjustment.
+ return frameRect;
}
+ if (_isHeadless || self.parentWindow) {
+ // AppKit's default implementation moves child windows down to avoid
+ // the menu bar. We don't want that behavior, because widgets like the
+ // Omnibox may have a big shadow that could cause invisible menu bar
+ // collision in fullscreen/maximized state. We override it here to
+ // return the original frameRect before the adjustment.
return frameRect;
}
// Private methods.
--- a/components/remote_cocoa/app_shim/native_widget_mac_overlay_nswindow.mm
+++ b/components/remote_cocoa/app_shim/native_widget_mac_overlay_nswindow.mm
@@ -6,8 +6,6 @@